From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA9642165EA; Sun, 28 Sep 2025 07:49:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.211.166.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759045762; cv=none; b=IlYtzJaaRfFqXvzEw8wM7MyGr9FsAU1IA3p/pFSd5+n6SWwRgR2dXPbMSV6KuHGYlkPGgElldRJ9xJ7RdABZISJUCMna1dd3pnJsyHKWANt9ixfjNOgVFwabL7DP/FUjLbSKeEV7J0ZjRmDzA7CP0RQ7NdgGvgaI4sfQeMNHiBI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759045762; c=relaxed/simple; bh=2YV+0KGn2R8iUl35WZkf0yYVQ3nz90R5l1xCjXP7o/8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BxKmcLNlOvFHtO1Q6xpIKtD2fCVMuo5gq9Uk3vazuHEsLUHfOpmOPz+EoicggNQZe9rhWIzjHWYeYvFvjLXPhNeSvfTIDinUm4dM059lFv8iozT2ZN/uW32Aw9FUMZFEIXbxJ7Mq+9gEFSlDfxwx+VHctDOvcXt54rphQv8VSv8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org; spf=pass smtp.mailfrom=gentoo.org; arc=none smtp.client-ip=140.211.166.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gentoo.org Received: from localhost (unknown [180.158.240.90]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange secp256r1 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dlan) by smtp.gentoo.org (Postfix) with ESMTPSA id BC76E340D6C; Sun, 28 Sep 2025 07:49:19 +0000 (UTC) Date: Sun, 28 Sep 2025 15:49:14 +0800 From: Yixun Lan To: Troy Mitchell Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yangyu Chen , Troy Mitchell , devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: riscv: spacemit: Add MusePi Pro board Message-ID: <20250928074914-GYA1344940@gentoo.org> References: <20250928-k1-musepi-pro-dts-v1-0-64d0659dfdbc@linux.spacemit.com> <20250928-k1-musepi-pro-dts-v1-1-5efcca0ce3ae@linux.spacemit.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250928-k1-musepi-pro-dts-v1-1-5efcca0ce3ae@linux.spacemit.com> Hi Troy, On 12:16 Sun 28 Sep , Troy Mitchell wrote: > From: Troy Mitchell > > Document the compatible string for the MusePi Pro [1]. > It is a 1.8-inch single board computer based on the > SpacemiT K1/M1 RISC-V SoC [2]. you could wrap at slightly more characters, I remember 72 chars (haven't spent time to find a formal document link..) > > Link: > https://developer.spacemit.com/documentation?token=YJtdwnvvViPVcmkoPDpcvwfVnrh&type=pdf I'd suggest to list core features of this board, while using this link as a complement, base on previous experience, vendor may change the link address, thus the link vanish > [1] > https://www.spacemit.com/en/key-stone-k1 [2] > pleae keep them in one line, no break, and no blank line between SoB, something as below Link: https://.. [1] > Signed-off-by: Troy Mitchell > --- > Documentation/devicetree/bindings/riscv/spacemit.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/riscv/spacemit.yaml b/Documentation/devicetree/bindings/riscv/spacemit.yaml > index c56b62a6299ac24d3cdef7edcdfc407dc62a1846..52fe39296031f21d1c28c4f1ea5ca9fe28caf45a 100644 > --- a/Documentation/devicetree/bindings/riscv/spacemit.yaml > +++ b/Documentation/devicetree/bindings/riscv/spacemit.yaml > @@ -22,6 +22,7 @@ properties: > - enum: > - bananapi,bpi-f3 > - milkv,jupiter > + - spacemit,musepi-pro > - xunlong,orangepi-rv2 > - const: spacemit,k1 > > > -- > 2.51.0 > -- Yixun Lan (dlan)