From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E7FB278753 for ; Tue, 30 Sep 2025 05:50:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759211422; cv=none; b=NJczdEN9e0q2exUiLPqLktia0aaiHEcxx34dOYS++KHR3prJp2k5/F8ldAszXDHFGhHjaHpxaGtrSE74T2TVuSWRavmC8Tnnglj8oGm9EbuiSIKyLDY8NWyb2XysoQTF/5to5uZpAAo8QuWOLiLsTbm53cVZFCR6Fwfg9IDCRFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759211422; c=relaxed/simple; bh=HQNn0GpSr5MaoATHj12j1OfeIQxkRKUAuDUx63OS8o0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eU/ehFfdaYrG0p3YluPca55DmA1LNd1f1VbS8CVprghi1UoyNETHo89QVcXyxj3NrG3OZD+UYCeOOvh+//axXp9eEQnI48f88eb7OOWEGCIRkpdZ/4KJlwqBhDVkByHoPsA//bjcxYoJ89I/gyO1DIBkD7GmWl4FmFm1fGnogI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Lt/QzqV2; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Lt/QzqV2" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58U4IE0i013512 for ; Tue, 30 Sep 2025 05:50:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= b3KVfEGjSay2MX7CoJvLOzV1CqboHslXk9pdc9qozsE=; b=Lt/QzqV2PX0S0ruc 9FWTfzCCUYcj+zhi2JgJw3zmuSYHFNZMybigdd8EJV3x4fVNPlNqnx8UurLNECAW gws+NNgNM9/UKdVNpMw+M5b73MCaGr0L/HqhJ9ZwxQq35nnQ8RHWG49xjbtKmt7X rEbUWklmsdd+s3bePJey5K9eVrBmJuhyw7E37nQG7VjF3YElTsNWiexjeEE9CMNK GQEGJUyhfpn/h8Nmq19Y4JX0NUD9LdSvQvG6N37/TQN/xaUUH+VpDItV9NL+3GLv 0IgqdowmcND1Fd7UBVlF92ASDyBah9lThER1cUZj/TItiDw5UO3I5tKaAGYRWhiK WjCcPA== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49e8a5yssp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 30 Sep 2025 05:50:19 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3304def7909so5398808a91.3 for ; Mon, 29 Sep 2025 22:50:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759211418; x=1759816218; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b3KVfEGjSay2MX7CoJvLOzV1CqboHslXk9pdc9qozsE=; b=a+6AKa9cHXU6dnB5slsVkLSuzmN5vvlUZBClLqWOWT6gnOA8+07+b0zVpSVrkEyVnE bMxZgLzzIvBPj/eCVge2dciD4vI7ZxIplkiPhVJa24b0m3Yx/hmKb/ra+LE9/ZH8raUN qbObUAwL6UxxlgE4tQcUYXmXOiuUGWYRLx4nBmv8pCsCyX2ykFMvUbSjjW6YNiwxqVkY 0rIU7H/LyaFHIpybhzPVtKAya9N1lC1TMU0KCDXspYnukglr+UmVBRRo2BCejXAmJfhA elWcZkmWNicW7xK8Mgio7XXQvek5cFk7mWeOvF7txEjIHh/rgvCOv1W3QAWN4nHbOVQD 9cIw== X-Forwarded-Encrypted: i=1; AJvYcCWX+E3fEcSx5Sl7rcbkd1Q28AtOsVrYtCxp5IFMs+i7ZGRt7GMHaeH9oqZ4AxRorZYpBJjaoujvzmlp@vger.kernel.org X-Gm-Message-State: AOJu0YyOYuPin2NQlm+GM/DzRAhdxpe7UEUKSp1cVGqG3Jh9a8K32OL2 CoLzx96fNyaEJzB3t3JyCoyVnY+SX2eaoyMFUYuU7yGAn2lPZjLM8D7LLOUfzWFCM/YgAWSx+sr FcCEKyu49irGdaH7ZvqWo3mI+9DJ3BzovZK9tYCaMuzy37jafWgjl4mkyE7jx+cFW X-Gm-Gg: ASbGncuypCSUekVp1tdSLwC0Mbawno+Eue60oz9EZbyeP/bF21euPORyN6YfbfcZf9j fzcHlm3NBFuvRJcD9ldOBgUDfhSNE4q7Q+OsyX+fWJ5XFQaYr71dxGTFvcIYw9lnhV5TxXpp/O0 9rBS8wVFpK8aUMQJ1jrrCtqwtkfG1UqubC40Xo2Lf/4wUFkpgecDdpj+eB30wDlr5xeSKRmpQDV 2GZfdgsj/qv1hwgGrP+X9SmV0zxhFqp4fO4ZHGSu0NtsWSD0mM+QkQPntvlHie/U27QhkcHlYRv xfUe6DGLFYlYYYAA9s56U1gahFv8JnwK8QDEczyyJeObvKqE8+fRBxZ2JfHgnvnJrXPWjw== X-Received: by 2002:a17:90b:314c:b0:32e:96b1:fb6e with SMTP id 98e67ed59e1d1-3342a29906dmr20304946a91.18.1759211418002; Mon, 29 Sep 2025 22:50:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFo0RE2YKa4ZygxZu6kxjp8Q2RIAaVkJ/MyZNvDXmSDipKXnnMeHOY/Pjn5S54HjeUH61NjDQ== X-Received: by 2002:a17:90b:314c:b0:32e:96b1:fb6e with SMTP id 98e67ed59e1d1-3342a29906dmr20304912a91.18.1759211417534; Mon, 29 Sep 2025 22:50:17 -0700 (PDT) Received: from hu-akhilpo-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3341be23412sm19029779a91.20.2025.09.29.22.50.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Sep 2025 22:50:17 -0700 (PDT) From: Akhil P Oommen Date: Tue, 30 Sep 2025 11:18:09 +0530 Subject: [PATCH 04/17] drm/msm/adreno: Create adreno_func->submit_flush() Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250930-kaana-gpu-support-v1-4-73530b0700ed@oss.qualcomm.com> References: <20250930-kaana-gpu-support-v1-0-73530b0700ed@oss.qualcomm.com> In-Reply-To: <20250930-kaana-gpu-support-v1-0-73530b0700ed@oss.qualcomm.com> To: Rob Clark , Bjorn Andersson , Konrad Dybcio , Sean Paul , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Jonathan Marek , Jordan Crouse , Will Deacon , Robin Murphy , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, Akhil P Oommen X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1759211380; l=2662; i=akhilpo@oss.qualcomm.com; s=20240726; h=from:subject:message-id; bh=HQNn0GpSr5MaoATHj12j1OfeIQxkRKUAuDUx63OS8o0=; b=R/N87ADKLI885gc4zTsGjeVFnAH7lthAW1ze2DZJAlARQpSnNO9Y+gAiY+MUbS9j70fOi7I4V Whw/OBdpDLmDwFAQAOu1zNCO8SxfWv4eBVJ1taJgS1R0W3pl7D4FPDR X-Developer-Key: i=akhilpo@oss.qualcomm.com; a=ed25519; pk=lmVtttSHmAUYFnJsQHX80IIRmYmXA4+CzpGcWOOsfKA= X-Authority-Analysis: v=2.4 cv=RZKdyltv c=1 sm=1 tr=0 ts=68db6f9b cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=geZ1VMdEqvdXz0YL0KoA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-GUID: FZKXY06_gSld9yUwa7jTuy_lH1k_-Hdw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTI3MDAzMyBTYWx0ZWRfX4ZKnk6k4AbAT yHwViVOBr6B4T5rsnaxTcuAuElIoK7cp228NGpQRzo7CQ8G9Zg+A8V0K7DwcxJms2/HwVcs1wJv JCxW+i9DtFATiLpmxttBdSfuKQ6i94e68LyARgKUuDvNz32dTH3ME5SQUIWK9XlRj54yD7Vi+2h /Oaw7t/40CVciaQORNWmh0/gf8aYEFLdEoQVpUvokSAUJd/qLEqN3sBCyHiSo3Kws8zWi9lP+oJ Pyse3WZ+w0nOptTaYx8l2boggCM+vtgGcFitLbWtrTMCIgWy7h8np+V2fWX2n45JE3OP1oHawAI BCoaQHtVBbdZMfQ9aSZVq2U2qIrpqm80TJ553fuUy8hqvFq/YUWV8KYLb5iRViL+zTBDrurbAYy NL1Jov2krmNv9zRInLnVRa7ESakXDw== X-Proofpoint-ORIG-GUID: FZKXY06_gSld9yUwa7jTuy_lH1k_-Hdw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-30_01,2025-09-29_04,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 priorityscore=1501 adultscore=0 phishscore=0 impostorscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2509270033 To dynamically decide the right flush routine, convert a6xx_flush to an adreno_func op. This will help us to reuse a7xx_submit() along with a8xx_flush op. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 7 +++++-- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 1 + 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index b8f8ae940b55f5578abdbdec6bf1e90a53e721a5..9cc2f008388929f0c8e8f70a3e3e79fb4d35ab38 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -391,7 +391,7 @@ static void a6xx_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit) trace_msm_gpu_submit_flush(submit, read_gmu_ao_counter(a6xx_gpu)); - a6xx_flush(gpu, ring); + adreno_gpu->funcs->submit_flush(gpu, ring); } static void a6xx_emit_set_pseudo_reg(struct msm_ringbuffer *ring, @@ -591,7 +591,7 @@ static void a7xx_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit) trace_msm_gpu_submit_flush(submit, read_gmu_ao_counter(a6xx_gpu)); - a6xx_flush(gpu, ring); + adreno_gpu->funcs->submit_flush(gpu, ring); /* Check to see if we need to start preemption */ a6xx_preempt_trigger(gpu); @@ -2557,6 +2557,7 @@ static const struct adreno_gpu_funcs funcs = { .sysprof_setup = a6xx_gmu_sysprof_setup, }, .get_timestamp = a6xx_gmu_get_timestamp, + .submit_flush = a6xx_flush, }; static const struct adreno_gpu_funcs funcs_gmuwrapper = { @@ -2586,6 +2587,7 @@ static const struct adreno_gpu_funcs funcs_gmuwrapper = { .progress = a6xx_progress, }, .get_timestamp = a6xx_get_timestamp, + .submit_flush = a6xx_flush, }; static const struct adreno_gpu_funcs funcs_a7xx = { @@ -2618,6 +2620,7 @@ static const struct adreno_gpu_funcs funcs_a7xx = { .sysprof_setup = a6xx_gmu_sysprof_setup, }, .get_timestamp = a6xx_gmu_get_timestamp, + .submit_flush = a6xx_flush, }; struct msm_gpu *a6xx_gpu_init(struct drm_device *dev) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h index 390fa6720d9b096f4fa7d1639645d453d43b153a..77b1c73ff8946fb0f8ff279e16c973cade50c130 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h @@ -74,6 +74,7 @@ enum adreno_family { struct adreno_gpu_funcs { struct msm_gpu_funcs base; int (*get_timestamp)(struct msm_gpu *gpu, uint64_t *value); + void (*submit_flush)(struct msm_gpu *gpu, struct msm_ringbuffer *ring); }; struct adreno_reglist { -- 2.51.0