Re: [PATCH] dt-bindings: mfd: dlg,da9063: allow 'interrupts-extended' property

[Rob Herring <robh@kernel.org>]

On Mon, Sep 29, 2025 at 09:20:47AM +0200, Wolfram Sang wrote:
> If nested, DT schema cannot extend required 'interrupts' to include
> 'interrupts-extended'. It needs to be added manually. Fixes:
> 
> arch/arm/boot/dts/renesas/r8a7791-koelsch.dtb: pmic@58 (dlg,da9063): 'interrupts' is a required property
> 	from schema $id: http://devicetree.org/schemas/mfd/dlg,da9063.yaml#
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> 
> Copied this solution 1:1 from:
>   Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml
> 
>  Documentation/devicetree/bindings/mfd/dlg,da9063.yaml | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml b/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml
> index 51612dc22748..4af5fcb856c7 100644
> --- a/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml
> +++ b/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml
> @@ -110,10 +110,16 @@ allOf:
>              "^buck[1-4]$": false
>          thermal: false
>        required:
> -        - interrupts
>          - interrupt-controller
>          - '#interrupt-cells'
>  
> +      # oneOf is required, because dtschema's fixups.py doesn't handle this
> +      # nesting here. Its special treatment to allow either interrupt property
> +      # when only one is specified in the binding works at the top level only.

The solution is to fix dtschema. I'll take a look at it.

> +      oneOf:
> +        - required: [interrupts]
> +        - required: [interrupts-extended]
> +
>    - if:
>        properties:
>          compatible:
> -- 
> 2.47.2
>