From: Rob Herring <robh@kernel.org>
To: Zhengnan Chen <zhengnan.chen@mediatek.com>
Cc: Yong Wu <yong.wu@mediatek.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH 1/2] dt-bindings: memory-controllers: mtk-smi: Add support for mt8189
Date: Wed, 1 Oct 2025 19:06:57 -0500 [thread overview]
Message-ID: <20251002000657.GA2511095-robh@kernel.org> (raw)
In-Reply-To: <20250919081014.14100-2-zhengnan.chen@mediatek.com>
On Fri, Sep 19, 2025 at 04:09:55PM +0800, Zhengnan Chen wrote:
> From: "zhengnan.chen" <zhengnan.chen@mediatek.com>
Please fix your name here so the S-o-b matches.
>
> Add binding description for mt8189.
>
> Signed-off-by: Zhengnan Chen <zhengnan.chen@mediatek.com>
> ---
> .../bindings/memory-controllers/mediatek,smi-common.yaml | 2 ++
> .../bindings/memory-controllers/mediatek,smi-larb.yaml | 3 +++
> 2 files changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
> index 0762e0ff66ef..aac8368b210c 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
> @@ -40,6 +40,8 @@ properties:
> - mediatek,mt8186-smi-common
> - mediatek,mt8188-smi-common-vdo
> - mediatek,mt8188-smi-common-vpp
> + - mediatek,mt8189-smi-common
> + - mediatek,mt8189-smi-sub-common
Perhaps some explanation what 'sub-common' is compared to just 'common'.
> - mediatek,mt8192-smi-common
> - mediatek,mt8195-smi-common-vdo
> - mediatek,mt8195-smi-common-vpp
> diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
> index 2e7fac4b5094..9a5dafd7c07e 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
> @@ -27,6 +27,7 @@ properties:
> - mediatek,mt8183-smi-larb
> - mediatek,mt8186-smi-larb
> - mediatek,mt8188-smi-larb
> + - mediatek,mt8189-smi-larb
> - mediatek,mt8192-smi-larb
> - mediatek,mt8195-smi-larb
>
> @@ -85,6 +86,7 @@ allOf:
> - mediatek,mt8183-smi-larb
> - mediatek,mt8186-smi-larb
> - mediatek,mt8188-smi-larb
> + - mediatek,mt8189-smi-larb
> - mediatek,mt8195-smi-larb
>
> then:
> @@ -119,6 +121,7 @@ allOf:
> - mediatek,mt6779-smi-larb
> - mediatek,mt8186-smi-larb
> - mediatek,mt8188-smi-larb
> + - mediatek,mt8189-smi-larb
> - mediatek,mt8192-smi-larb
> - mediatek,mt8195-smi-larb
>
> --
> 2.46.0
>
next prev parent reply other threads:[~2025-10-02 0:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 8:09 [PATCH 0/2] MT8189 SMI SUPPORT Zhengnan Chen
2025-09-19 8:09 ` [PATCH 1/2] dt-bindings: memory-controllers: mtk-smi: Add support for mt8189 Zhengnan Chen
2025-09-23 9:55 ` AngeloGioacchino Del Regno
2025-10-02 0:06 ` Rob Herring [this message]
2025-10-24 8:41 ` Zhengnan Chen (陈征南)
2025-10-24 8:45 ` Krzysztof Kozlowski
2025-09-19 8:09 ` [PATCH 2/2] memory: mtk-smi: Add mt8189 support Zhengnan Chen
2025-09-23 9:55 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251002000657.GA2511095-robh@kernel.org \
--to=robh@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=yong.wu@mediatek.com \
--cc=zhengnan.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).