[PATCH] dt-bindings: mailbox: qcom-ipcc: Add bindings for physical client ids

[PATCH] dt-bindings: mailbox: qcom-ipcc: Add bindings for physical client ids

[Jingyi Wang]

Physical client IDs instead of virtual client IDs are used for qcom new
platforms in the Inter Process Communication Controller (IPCC) driver
as virtual physical mapping logic is removed in HW. Add the bindings.

Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
---
 include/dt-bindings/mailbox/qcom-ipcc.h | 48 +++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/include/dt-bindings/mailbox/qcom-ipcc.h b/include/dt-bindings/mailbox/qcom-ipcc.h
index fd85a79381b3..dc07ca27db09 100644
--- a/include/dt-bindings/mailbox/qcom-ipcc.h
+++ b/include/dt-bindings/mailbox/qcom-ipcc.h
@@ -36,4 +36,52 @@
 #define IPCC_CLIENT_GPDSP0		31
 #define IPCC_CLIENT_GPDSP1		32
 
+/* Physical client IDs */
+#define IPCC_MPROC_AOP                  0
+#define IPCC_MPROC_TZ                   1
+#define IPCC_MPROC_MPSS                 2
+#define IPCC_MPROC_LPASS                3
+#define IPCC_MPROC_SDC                  4
+#define IPCC_MPROC_CDSP                 5
+#define IPCC_MPROC_APSS                 6
+#define IPCC_MPROC_SOCCP                13
+#define IPCC_MPROC_DCP                  14
+#define IPCC_MPROC_SPSS                 15
+#define IPCC_MPROC_TME                  16
+
+#define IPCC_COMPUTE_L0_CDSP            2
+#define IPCC_COMPUTE_L0_APSS            3
+#define IPCC_COMPUTE_L0_GPU             4
+#define IPCC_COMPUTE_L0_CVP             8
+#define IPCC_COMPUTE_L0_CAM             9
+#define IPCC_COMPUTE_L0_CAM1            10
+#define IPCC_COMPUTE_L0_DCP             11
+#define IPCC_COMPUTE_L0_VPU             12
+#define IPCC_COMPUTE_L0_SOCCP           16
+
+#define IPCC_COMPUTE_L1_CDSP            2
+#define IPCC_COMPUTE_L1_APSS            3
+#define IPCC_COMPUTE_L1_GPU             4
+#define IPCC_COMPUTE_L1_CVP             8
+#define IPCC_COMPUTE_L1_CAM             9
+#define IPCC_COMPUTE_L1_CAM1            10
+#define IPCC_COMPUTE_L1_DCP             11
+#define IPCC_COMPUTE_L1_VPU             12
+#define IPCC_COMPUTE_L1_SOCCP           16
+
+#define IPCC_PERIPH_CDSP                2
+#define IPCC_PERIPH_APSS                3
+#define IPCC_PERIPH_PCIE0               4
+#define IPCC_PERIPH_PCIE1               5
+
+#define IPCC_FENCE_CDSP                 2
+#define IPCC_FENCE_APSS                 3
+#define IPCC_FENCE_GPU                  4
+#define IPCC_FENCE_CVP                  8
+#define IPCC_FENCE_CAM                  8
+#define IPCC_FENCE_VPU                  20
+#define IPCC_FENCE_SOCCP                24
+#define IPCC_FENCE_CAM1                 10
+#define IPCC_FENCE_DCP                  11
+
 #endif

---
base-commit: ae2d20002576d2893ecaff25db3d7ef9190ac0b6
change-id: 20250922-ipcc-header-c17cb4eea4b2

Best regards,
-- 
Jingyi Wang <jingyi.wang@oss.qualcomm.com>

Re: [PATCH] dt-bindings: mailbox: qcom-ipcc: Add bindings for physical client ids

[Rob Herring]

On Mon, Sep 22, 2025 at 08:34:20PM -0700, Jingyi Wang wrote:
> Physical client IDs instead of virtual client IDs are used for qcom new
> platforms in the Inter Process Communication Controller (IPCC) driver
> as virtual physical mapping logic is removed in HW. Add the bindings.
> 
> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> ---
>  include/dt-bindings/mailbox/qcom-ipcc.h | 48 +++++++++++++++++++++++++++++++++
>  1 file changed, 48 insertions(+)

This looks incomplete. Where's the binding additions for the new h/w 
that uses these ids. This series looks more complete:

https://lore.kernel.org/all/20250924183726.509202-3-sibi.sankar@oss.qualcomm.com

Can QCom please coordinate your work so we're not getting the same thing 
a day apart.

Rob

Re: [PATCH] dt-bindings: mailbox: qcom-ipcc: Add bindings for physical client ids

[Jingyi Wang]

On 10/2/2025 8:34 AM, Rob Herring wrote:
> On Mon, Sep 22, 2025 at 08:34:20PM -0700, Jingyi Wang wrote:
>> Physical client IDs instead of virtual client IDs are used for qcom new
>> platforms in the Inter Process Communication Controller (IPCC) driver
>> as virtual physical mapping logic is removed in HW. Add the bindings.
>>
>> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
>> ---
>>  include/dt-bindings/mailbox/qcom-ipcc.h | 48 +++++++++++++++++++++++++++++++++
>>  1 file changed, 48 insertions(+)
> 
> This looks incomplete. Where's the binding additions for the new h/w 
> that uses these ids. This series looks more complete:
> 
> https://lore.kernel.org/all/20250924183726.509202-3-sibi.sankar@oss.qualcomm.com
> 
> Can QCom please coordinate your work so we're not getting the same thing 
> a day apart.
> 
> Rob

Hi Rob,

Sorry we thought all the platform use the same phy id at first, as different platform
has different IDs, maybe it is better to maintain it in different header files
like qcom-ipcc-kaanapali.h? Please let me know if you have disagreement for this.

Thanks,
Jingyi