devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/5] dt-bindings: remoteproc: Document Glymur ADSP/CDSP PAS
@ 2025-09-24 18:37 Sibi Sankar
  2025-09-24 18:37 ` [PATCH 1/5] dt-bindings: mailbox: qcom-ipcc: Document the Glymur IPCC Sibi Sankar
                   ` (4 more replies)
  0 siblings, 5 replies; 12+ messages in thread
From: Sibi Sankar @ 2025-09-24 18:37 UTC (permalink / raw)
  To: jassisinghbrar, robh, krzk+dt, conor+dt, mani, andersson,
	mathieu.poirier, konradybcio
  Cc: linux-kernel, linux-arm-msm, devicetree, linux-remoteproc

The series documents the AOSS, IPCC and ADSP/CDSP remoteproc bindings
required to add initial support for ADSP/CDSP remoteprocs on Glymur SoCs.

Dependencies:
Peripheral Image Loader support for Qualcomm SoCs running Linux host at EL2:
https://patchwork.kernel.org/project/linux-arm-msm/cover/20250921-kvm_rproc_pas-v3-0-458f09647920@oss.qualcomm.com/
Patches 4/5 have a dependency on the iommu binding added in ^^ series.

Sibi Sankar (5):
  dt-bindings: mailbox: qcom-ipcc: Document the Glymur IPCC
  dt-bindings: mailbox: qcom-ipcc: Document Glymur physical client IDs
  dt-bindings: soc: qcom,aoss-qmp: Document the Glymur AOSS side channel
  dt-bindings: remoteproc: qcom,sm8550-pas: Document Glymur ADSP
  dt-bindings: remoteproc: qcom,sm8550-pas: Document Glymur CDSP

 .../bindings/mailbox/qcom-ipcc.yaml           |  1 +
 .../bindings/remoteproc/qcom,sm8550-pas.yaml  | 22 ++++++-
 .../bindings/soc/qcom/qcom,aoss-qmp.yaml      |  1 +
 include/dt-bindings/mailbox/qcom-ipcc.h       | 61 +++++++++++++++++++
 4 files changed, 84 insertions(+), 1 deletion(-)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH 1/5] dt-bindings: mailbox: qcom-ipcc: Document the Glymur IPCC
  2025-09-24 18:37 [PATCH 0/5] dt-bindings: remoteproc: Document Glymur ADSP/CDSP PAS Sibi Sankar
@ 2025-09-24 18:37 ` Sibi Sankar
  2025-10-02  0:39   ` Rob Herring
  2025-09-24 18:37 ` [PATCH 2/5] dt-bindings: mailbox: qcom-ipcc: Document Glymur physical client IDs Sibi Sankar
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 12+ messages in thread
From: Sibi Sankar @ 2025-09-24 18:37 UTC (permalink / raw)
  To: jassisinghbrar, robh, krzk+dt, conor+dt, mani, andersson,
	mathieu.poirier, konradybcio
  Cc: linux-kernel, linux-arm-msm, devicetree, linux-remoteproc

Document the Inter-Processor Communication Controller on the Glymur SoCs.

Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
index e5c423130db6..129870185884 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
+++ b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
@@ -24,6 +24,7 @@ properties:
   compatible:
     items:
       - enum:
+          - qcom,glymur-ipcc
           - qcom,milos-ipcc
           - qcom,qcs8300-ipcc
           - qcom,qdu1000-ipcc
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 2/5] dt-bindings: mailbox: qcom-ipcc: Document Glymur physical client IDs
  2025-09-24 18:37 [PATCH 0/5] dt-bindings: remoteproc: Document Glymur ADSP/CDSP PAS Sibi Sankar
  2025-09-24 18:37 ` [PATCH 1/5] dt-bindings: mailbox: qcom-ipcc: Document the Glymur IPCC Sibi Sankar
@ 2025-09-24 18:37 ` Sibi Sankar
  2025-10-02  0:37   ` Rob Herring
  2025-09-24 18:37 ` [PATCH 3/5] dt-bindings: soc: qcom,aoss-qmp: Document the Glymur AOSS side channel Sibi Sankar
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 12+ messages in thread
From: Sibi Sankar @ 2025-09-24 18:37 UTC (permalink / raw)
  To: jassisinghbrar, robh, krzk+dt, conor+dt, mani, andersson,
	mathieu.poirier, konradybcio
  Cc: linux-kernel, linux-arm-msm, devicetree, linux-remoteproc

Document the physical client IDs specific to Glymur SoCs. Physical client
IDs are used on newer Qualcomm platforms including Glymur, since the Inter
Process Communication Controller (IPCC) HW block no longer has the virtual
to physical mapping in place.

Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
---

https://patchwork.kernel.org/project/linux-arm-msm/patch/20250922-ipcc-header-v1-1-f0b12715e118@oss.qualcomm.com/
^^ patch seems to assume physical IDs are common across SoCs but it doesn't
seem to hold true on Glymur.

 include/dt-bindings/mailbox/qcom-ipcc.h | 61 +++++++++++++++++++++++++
 1 file changed, 61 insertions(+)

diff --git a/include/dt-bindings/mailbox/qcom-ipcc.h b/include/dt-bindings/mailbox/qcom-ipcc.h
index fd85a79381b3..61cef29e43f0 100644
--- a/include/dt-bindings/mailbox/qcom-ipcc.h
+++ b/include/dt-bindings/mailbox/qcom-ipcc.h
@@ -36,4 +36,65 @@
 #define IPCC_CLIENT_GPDSP0		31
 #define IPCC_CLIENT_GPDSP1		32
 
+/* Platform specific physical client IDs */
+
+/* Glymur physical client IDs */
+#define GLYMUR_MPROC_AOP		0
+#define GLYMUR_MPROC_TZ			1
+#define GLYMUR_MPROC_MPSS		2
+#define GLYMUR_MPROC_LPASS		3
+#define GLYMUR_MPROC_SLPI		4
+#define GLYMUR_MPROC_SDC		5
+#define GLYMUR_MPROC_CDSP		6
+#define GLYMUR_MPROC_NPU		7
+#define GLYMUR_MPROC_APSS		8
+#define GLYMUR_MPROC_GPU		9
+#define GLYMUR_MPROC_ICP		11
+#define GLYMUR_MPROC_VPU		12
+#define GLYMUR_MPROC_PCIE0		13
+#define GLYMUR_MPROC_PCIE1		14
+#define GLYMUR_MPROC_PCIE2		15
+#define GLYMUR_MPROC_SPSS		16
+#define GLYMUR_MPROC_PCIE3		19
+#define GLYMUR_MPROC_PCIE4		20
+#define GLYMUR_MPROC_PCIE5		21
+#define GLYMUR_MPROC_PCIE6		22
+#define GLYMUR_MPROC_TME		23
+#define GLYMUR_MPROC_WPSS		24
+#define GLYMUR_MPROC_PCIE7		44
+#define GLYMUR_MPROC_SOCCP		46
+
+#define GLYMUR_COMPUTE_L0_LPASS		0
+#define GLYMUR_COMPUTE_L0_CDSP		1
+#define GLYMUR_COMPUTE_L0_APSS		2
+#define GLYMUR_COMPUTE_L0_GPU		3
+#define GLYMUR_COMPUTE_L0_CVP		6
+#define GLYMUR_COMPUTE_L0_ICP		7
+#define GLYMUR_COMPUTE_L0_VPU		8
+#define GLYMUR_COMPUTE_L0_DPU		9
+#define GLYMUR_COMPUTE_L0_SOCCP		11
+
+#define GLYMUR_COMPUTE_L1_LPASS		0
+#define GLYMUR_COMPUTE_L1_CDSP		1
+#define GLYMUR_COMPUTE_L1_APSS		2
+#define GLYMUR_COMPUTE_L1_GPU		3
+#define GLYMUR_COMPUTE_L1_CVP		6
+#define GLYMUR_COMPUTE_L1_ICP		7
+#define GLYMUR_COMPUTE_L1_VPU		8
+#define GLYMUR_COMPUTE_L1_DPU		9
+#define GLYMUR_COMPUTE_L1_SOCCP		11
+
+#define GLYMUR_PERIPH_LPASS		0
+#define GLYMUR_PERIPH_APSS		1
+#define GLYMUR_PERIPH_PCIE0		2
+#define GLYMUR_PERIPH_PCIE1		3
+#define GLYMUR_PERIPH_PCIE2		6
+#define GLYMUR_PERIPH_PCIE3		7
+#define GLYMUR_PERIPH_PCIE4		8
+#define GLYMUR_PERIPH_PCIE5		9
+#define GLYMUR_PERIPH_PCIE6		10
+#define GLYMUR_PERIPH_PCIE7		11
+#define GLYMUR_PERIPH_SOCCP		13
+#define GLYMUR_PERIPH_WPSS		16
+
 #endif
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 3/5] dt-bindings: soc: qcom,aoss-qmp: Document the Glymur AOSS side channel
  2025-09-24 18:37 [PATCH 0/5] dt-bindings: remoteproc: Document Glymur ADSP/CDSP PAS Sibi Sankar
  2025-09-24 18:37 ` [PATCH 1/5] dt-bindings: mailbox: qcom-ipcc: Document the Glymur IPCC Sibi Sankar
  2025-09-24 18:37 ` [PATCH 2/5] dt-bindings: mailbox: qcom-ipcc: Document Glymur physical client IDs Sibi Sankar
@ 2025-09-24 18:37 ` Sibi Sankar
  2025-09-24 18:37 ` [PATCH 4/5] dt-bindings: remoteproc: qcom,sm8550-pas: Document Glymur ADSP Sibi Sankar
  2025-09-24 18:37 ` [PATCH 5/5] dt-bindings: remoteproc: qcom,sm8550-pas: Document Glymur CDSP Sibi Sankar
  4 siblings, 0 replies; 12+ messages in thread
From: Sibi Sankar @ 2025-09-24 18:37 UTC (permalink / raw)
  To: jassisinghbrar, robh, krzk+dt, conor+dt, mani, andersson,
	mathieu.poirier, konradybcio
  Cc: linux-kernel, linux-arm-msm, devicetree, linux-remoteproc

Document the Always-on Subsystem side channel on the Glymur SoC.

Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml
index 851a1260f8dc..bee107bf7e81 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml
@@ -25,6 +25,7 @@ properties:
   compatible:
     items:
       - enum:
+          - qcom,glymur-aoss-qmp
           - qcom,milos-aoss-qmp
           - qcom,qcs615-aoss-qmp
           - qcom,qcs8300-aoss-qmp
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 4/5] dt-bindings: remoteproc: qcom,sm8550-pas: Document Glymur ADSP
  2025-09-24 18:37 [PATCH 0/5] dt-bindings: remoteproc: Document Glymur ADSP/CDSP PAS Sibi Sankar
                   ` (2 preceding siblings ...)
  2025-09-24 18:37 ` [PATCH 3/5] dt-bindings: soc: qcom,aoss-qmp: Document the Glymur AOSS side channel Sibi Sankar
@ 2025-09-24 18:37 ` Sibi Sankar
  2025-10-02  0:54   ` Rob Herring
  2025-09-24 18:37 ` [PATCH 5/5] dt-bindings: remoteproc: qcom,sm8550-pas: Document Glymur CDSP Sibi Sankar
  4 siblings, 1 reply; 12+ messages in thread
From: Sibi Sankar @ 2025-09-24 18:37 UTC (permalink / raw)
  To: jassisinghbrar, robh, krzk+dt, conor+dt, mani, andersson,
	mathieu.poirier, konradybcio
  Cc: linux-kernel, linux-arm-msm, devicetree, linux-remoteproc

Document compatible for Qualcomm Glymur SoC ADSP which is fully compatible
with SM8750 ADSP. Also with the Linux Host running on EL2, the remoteprocs
need to be hypervisor independent, the iommu property is mandatory to
ensure proper functionality.

Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
---

Dependencies:
Peripheral Image Loader support for Qualcomm SoCs running Linux host at EL2:
https://patchwork.kernel.org/project/linux-arm-msm/cover/20250921-kvm_rproc_pas-v3-0-458f09647920@oss.qualcomm.com/
This patch has a dependency on the iommu binding added in ^^ series.

 .../bindings/remoteproc/qcom,sm8550-pas.yaml     | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
index 2dd479cf4821..cba45ce2865e 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
@@ -28,7 +28,9 @@ properties:
           - qcom,x1e80100-adsp-pas
           - qcom,x1e80100-cdsp-pas
       - items:
-          - const: qcom,sm8750-adsp-pas
+          - enum:
+              - qcom,glymur-adsp-pas
+              - qcom,sm8750-adsp-pas
           - const: qcom,sm8550-adsp-pas
       - items:
           - const: qcom,sm8750-cdsp-pas
@@ -95,6 +97,7 @@ allOf:
         compatible:
           contains:
             enum:
+              - qcom,glymur-adsp-pas
               - qcom,sm8750-adsp-pas
     then:
       properties:
@@ -185,6 +188,7 @@ allOf:
         compatible:
           contains:
             enum:
+              - qcom,glymur-adsp-pas
               - qcom,sm8550-adsp-pas
               - qcom,sm8650-adsp-pas
               - qcom,sm8750-adsp-pas
@@ -238,6 +242,16 @@ allOf:
             - const: cx
             - const: mxc
             - const: nsp
+  - if:
+      properties:
+        compatible:
+          enum:
+            - qcom,glymur-adsp-pas
+    then:
+      properties:
+        iommus:
+          minItems: 1
+          maxItems: 1
 
 unevaluatedProperties: false
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 5/5] dt-bindings: remoteproc: qcom,sm8550-pas: Document Glymur CDSP
  2025-09-24 18:37 [PATCH 0/5] dt-bindings: remoteproc: Document Glymur ADSP/CDSP PAS Sibi Sankar
                   ` (3 preceding siblings ...)
  2025-09-24 18:37 ` [PATCH 4/5] dt-bindings: remoteproc: qcom,sm8550-pas: Document Glymur ADSP Sibi Sankar
@ 2025-09-24 18:37 ` Sibi Sankar
  2025-10-02  0:55   ` Rob Herring (Arm)
  4 siblings, 1 reply; 12+ messages in thread
From: Sibi Sankar @ 2025-09-24 18:37 UTC (permalink / raw)
  To: jassisinghbrar, robh, krzk+dt, conor+dt, mani, andersson,
	mathieu.poirier, konradybcio
  Cc: linux-kernel, linux-arm-msm, devicetree, linux-remoteproc

Document compatible for Qualcomm Glymur SoC CDSP which is fully compatible
with SM8550 CDSP. Also with the Linux Host running on EL2, the remoteprocs
need to be hypervisor independent, the iommu property is mandatory to
ensure proper functionality.

Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
---

Dependencies:
Peripheral Image Loader support for Qualcomm SoCs running Linux host at EL2:
https://patchwork.kernel.org/project/linux-arm-msm/cover/20250921-kvm_rproc_pas-v3-0-458f09647920@oss.qualcomm.com/
This patch has a dependency on the iommu binding added in ^^ series.

 .../devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml     | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
index cba45ce2865e..8a15e0c47a78 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
@@ -35,6 +35,9 @@ properties:
       - items:
           - const: qcom,sm8750-cdsp-pas
           - const: qcom,sm8650-cdsp-pas
+      - items:
+          - const: qcom,glymur-cdsp-pas
+          - const: qcom,sm8550-cdsp-pas
 
   reg:
     maxItems: 1
@@ -98,6 +101,7 @@ allOf:
           contains:
             enum:
               - qcom,glymur-adsp-pas
+              - qcom,glymur-cdsp-pas
               - qcom,sm8750-adsp-pas
     then:
       properties:
@@ -227,6 +231,7 @@ allOf:
         compatible:
           contains:
             enum:
+              - qcom,glymur-cdsp-pas
               - qcom,sm8550-cdsp-pas
               - qcom,sm8650-cdsp-pas
               - qcom,x1e80100-cdsp-pas
@@ -247,6 +252,7 @@ allOf:
         compatible:
           enum:
             - qcom,glymur-adsp-pas
+            - qcom,glymur-cdsp-pas
     then:
       properties:
         iommus:
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/5] dt-bindings: mailbox: qcom-ipcc: Document Glymur physical client IDs
  2025-09-24 18:37 ` [PATCH 2/5] dt-bindings: mailbox: qcom-ipcc: Document Glymur physical client IDs Sibi Sankar
@ 2025-10-02  0:37   ` Rob Herring
  0 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2025-10-02  0:37 UTC (permalink / raw)
  To: Sibi Sankar
  Cc: jassisinghbrar, krzk+dt, conor+dt, mani, andersson,
	mathieu.poirier, konradybcio, linux-kernel, linux-arm-msm,
	devicetree, linux-remoteproc

On Thu, Sep 25, 2025 at 12:07:23AM +0530, Sibi Sankar wrote:
> Document the physical client IDs specific to Glymur SoCs. Physical client
> IDs are used on newer Qualcomm platforms including Glymur, since the Inter
> Process Communication Controller (IPCC) HW block no longer has the virtual
> to physical mapping in place.
> 
> Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
> ---
> 
> https://patchwork.kernel.org/project/linux-arm-msm/patch/20250922-ipcc-header-v1-1-f0b12715e118@oss.qualcomm.com/
> ^^ patch seems to assume physical IDs are common across SoCs but it doesn't
> seem to hold true on Glymur.

Maybe QCom should sort that out before sending us stuff...

> 
>  include/dt-bindings/mailbox/qcom-ipcc.h | 61 +++++++++++++++++++++++++
>  1 file changed, 61 insertions(+)

This belongs with patch 1 as it is part of the binding/ABI.

Rob

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/5] dt-bindings: mailbox: qcom-ipcc: Document the Glymur IPCC
  2025-09-24 18:37 ` [PATCH 1/5] dt-bindings: mailbox: qcom-ipcc: Document the Glymur IPCC Sibi Sankar
@ 2025-10-02  0:39   ` Rob Herring
  2025-10-09 10:07     ` Sibi Sankar
  0 siblings, 1 reply; 12+ messages in thread
From: Rob Herring @ 2025-10-02  0:39 UTC (permalink / raw)
  To: Sibi Sankar
  Cc: jassisinghbrar, krzk+dt, conor+dt, mani, andersson,
	mathieu.poirier, konradybcio, linux-kernel, linux-arm-msm,
	devicetree, linux-remoteproc

On Thu, Sep 25, 2025 at 12:07:22AM +0530, Sibi Sankar wrote:
> Document the Inter-Processor Communication Controller on the Glymur SoCs.

That's obvious. Say something useful here like how the h/w compares to 
existing documented h/w. Like perhaps the change from virtual ids to 
physical ids, whatever that means...

> 
> Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> index e5c423130db6..129870185884 100644
> --- a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
> @@ -24,6 +24,7 @@ properties:
>    compatible:
>      items:
>        - enum:
> +          - qcom,glymur-ipcc
>            - qcom,milos-ipcc
>            - qcom,qcs8300-ipcc
>            - qcom,qdu1000-ipcc
> -- 
> 2.34.1
> 

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 4/5] dt-bindings: remoteproc: qcom,sm8550-pas: Document Glymur ADSP
  2025-09-24 18:37 ` [PATCH 4/5] dt-bindings: remoteproc: qcom,sm8550-pas: Document Glymur ADSP Sibi Sankar
@ 2025-10-02  0:54   ` Rob Herring
  2025-10-09 10:09     ` Sibi Sankar
  0 siblings, 1 reply; 12+ messages in thread
From: Rob Herring @ 2025-10-02  0:54 UTC (permalink / raw)
  To: Sibi Sankar
  Cc: jassisinghbrar, krzk+dt, conor+dt, mani, andersson,
	mathieu.poirier, konradybcio, linux-kernel, linux-arm-msm,
	devicetree, linux-remoteproc

On Thu, Sep 25, 2025 at 12:07:25AM +0530, Sibi Sankar wrote:
> Document compatible for Qualcomm Glymur SoC ADSP which is fully compatible
> with SM8750 ADSP. Also with the Linux Host running on EL2, the remoteprocs
> need to be hypervisor independent, the iommu property is mandatory to
> ensure proper functionality.
> 
> Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
> ---
> 
> Dependencies:
> Peripheral Image Loader support for Qualcomm SoCs running Linux host at EL2:
> https://patchwork.kernel.org/project/linux-arm-msm/cover/20250921-kvm_rproc_pas-v3-0-458f09647920@oss.qualcomm.com/
> This patch has a dependency on the iommu binding added in ^^ series.
> 
>  .../bindings/remoteproc/qcom,sm8550-pas.yaml     | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> index 2dd479cf4821..cba45ce2865e 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> @@ -28,7 +28,9 @@ properties:
>            - qcom,x1e80100-adsp-pas
>            - qcom,x1e80100-cdsp-pas
>        - items:
> -          - const: qcom,sm8750-adsp-pas
> +          - enum:
> +              - qcom,glymur-adsp-pas
> +              - qcom,sm8750-adsp-pas
>            - const: qcom,sm8550-adsp-pas
>        - items:
>            - const: qcom,sm8750-cdsp-pas
> @@ -95,6 +97,7 @@ allOf:
>          compatible:
>            contains:
>              enum:
> +              - qcom,glymur-adsp-pas
>                - qcom,sm8750-adsp-pas
>      then:
>        properties:
> @@ -185,6 +188,7 @@ allOf:
>          compatible:
>            contains:
>              enum:
> +              - qcom,glymur-adsp-pas
>                - qcom,sm8550-adsp-pas
>                - qcom,sm8650-adsp-pas
>                - qcom,sm8750-adsp-pas
> @@ -238,6 +242,16 @@ allOf:
>              - const: cx
>              - const: mxc
>              - const: nsp
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - qcom,glymur-adsp-pas
> +    then:
> +      properties:
> +        iommus:
> +          minItems: 1

The min can never be 0, so it is already 1. Drop.

> +          maxItems: 1
>  
>  unevaluatedProperties: false
>  
> -- 
> 2.34.1
> 

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 5/5] dt-bindings: remoteproc: qcom,sm8550-pas: Document Glymur CDSP
  2025-09-24 18:37 ` [PATCH 5/5] dt-bindings: remoteproc: qcom,sm8550-pas: Document Glymur CDSP Sibi Sankar
@ 2025-10-02  0:55   ` Rob Herring (Arm)
  0 siblings, 0 replies; 12+ messages in thread
From: Rob Herring (Arm) @ 2025-10-02  0:55 UTC (permalink / raw)
  To: Sibi Sankar
  Cc: konradybcio, linux-kernel, conor+dt, mani, krzk+dt,
	linux-remoteproc, andersson, linux-arm-msm, jassisinghbrar,
	devicetree, mathieu.poirier


On Thu, 25 Sep 2025 00:07:26 +0530, Sibi Sankar wrote:
> Document compatible for Qualcomm Glymur SoC CDSP which is fully compatible
> with SM8550 CDSP. Also with the Linux Host running on EL2, the remoteprocs
> need to be hypervisor independent, the iommu property is mandatory to
> ensure proper functionality.
> 
> Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
> ---
> 
> Dependencies:
> Peripheral Image Loader support for Qualcomm SoCs running Linux host at EL2:
> https://patchwork.kernel.org/project/linux-arm-msm/cover/20250921-kvm_rproc_pas-v3-0-458f09647920@oss.qualcomm.com/
> This patch has a dependency on the iommu binding added in ^^ series.
> 
>  .../devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml     | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/5] dt-bindings: mailbox: qcom-ipcc: Document the Glymur IPCC
  2025-10-02  0:39   ` Rob Herring
@ 2025-10-09 10:07     ` Sibi Sankar
  0 siblings, 0 replies; 12+ messages in thread
From: Sibi Sankar @ 2025-10-09 10:07 UTC (permalink / raw)
  To: Rob Herring
  Cc: jassisinghbrar, krzk+dt, conor+dt, mani, andersson,
	mathieu.poirier, konradybcio, linux-kernel, linux-arm-msm,
	devicetree, linux-remoteproc


On 10/2/2025 6:09 AM, Rob Herring wrote:
> On Thu, Sep 25, 2025 at 12:07:22AM +0530, Sibi Sankar wrote:
>> Document the Inter-Processor Communication Controller on the Glymur SoCs.
> That's obvious. Say something useful here like how the h/w compares to
> existing documented h/w. Like perhaps the change from virtual ids to
> physical ids, whatever that means...

Hey Rob,

Thanks for taking time to review the series :)

Will add more relevant information during the next re-spin.

- Sibi Sankar

>
>> Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
>> ---
>>   Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
>> index e5c423130db6..129870185884 100644
>> --- a/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
>> +++ b/Documentation/devicetree/bindings/mailbox/qcom-ipcc.yaml
>> @@ -24,6 +24,7 @@ properties:
>>     compatible:
>>       items:
>>         - enum:
>> +          - qcom,glymur-ipcc
>>             - qcom,milos-ipcc
>>             - qcom,qcs8300-ipcc
>>             - qcom,qdu1000-ipcc
>> -- 
>> 2.34.1
>>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 4/5] dt-bindings: remoteproc: qcom,sm8550-pas: Document Glymur ADSP
  2025-10-02  0:54   ` Rob Herring
@ 2025-10-09 10:09     ` Sibi Sankar
  0 siblings, 0 replies; 12+ messages in thread
From: Sibi Sankar @ 2025-10-09 10:09 UTC (permalink / raw)
  To: Rob Herring
  Cc: jassisinghbrar, krzk+dt, conor+dt, mani, andersson,
	mathieu.poirier, konradybcio, linux-kernel, linux-arm-msm,
	devicetree, linux-remoteproc


On 10/2/2025 6:24 AM, Rob Herring wrote:
> On Thu, Sep 25, 2025 at 12:07:25AM +0530, Sibi Sankar wrote:
>> Document compatible for Qualcomm Glymur SoC ADSP which is fully compatible
>> with SM8750 ADSP. Also with the Linux Host running on EL2, the remoteprocs
>> need to be hypervisor independent, the iommu property is mandatory to
>> ensure proper functionality.
>>
>> Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
>> ---
>>
>> Dependencies:
>> Peripheral Image Loader support for Qualcomm SoCs running Linux host at EL2:
>> https://patchwork.kernel.org/project/linux-arm-msm/cover/20250921-kvm_rproc_pas-v3-0-458f09647920@oss.qualcomm.com/
>> This patch has a dependency on the iommu binding added in ^^ series.
>>
>>   .../bindings/remoteproc/qcom,sm8550-pas.yaml     | 16 +++++++++++++++-
>>   1 file changed, 15 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
>> index 2dd479cf4821..cba45ce2865e 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
>> @@ -28,7 +28,9 @@ properties:
>>             - qcom,x1e80100-adsp-pas
>>             - qcom,x1e80100-cdsp-pas
>>         - items:
>> -          - const: qcom,sm8750-adsp-pas
>> +          - enum:
>> +              - qcom,glymur-adsp-pas
>> +              - qcom,sm8750-adsp-pas
>>             - const: qcom,sm8550-adsp-pas
>>         - items:
>>             - const: qcom,sm8750-cdsp-pas
>> @@ -95,6 +97,7 @@ allOf:
>>           compatible:
>>             contains:
>>               enum:
>> +              - qcom,glymur-adsp-pas
>>                 - qcom,sm8750-adsp-pas
>>       then:
>>         properties:
>> @@ -185,6 +188,7 @@ allOf:
>>           compatible:
>>             contains:
>>               enum:
>> +              - qcom,glymur-adsp-pas
>>                 - qcom,sm8550-adsp-pas
>>                 - qcom,sm8650-adsp-pas
>>                 - qcom,sm8750-adsp-pas
>> @@ -238,6 +242,16 @@ allOf:
>>               - const: cx
>>               - const: mxc
>>               - const: nsp
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          enum:
>> +            - qcom,glymur-adsp-pas
>> +    then:
>> +      properties:
>> +        iommus:
>> +          minItems: 1
> The min can never be 0, so it is already 1. Drop.

Ack, will drop it.

- Sibi Sankar

>> +          maxItems: 1
>>   
>>   unevaluatedProperties: false
>>   
>> -- 
>> 2.34.1
>>

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2025-10-09 10:09 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-24 18:37 [PATCH 0/5] dt-bindings: remoteproc: Document Glymur ADSP/CDSP PAS Sibi Sankar
2025-09-24 18:37 ` [PATCH 1/5] dt-bindings: mailbox: qcom-ipcc: Document the Glymur IPCC Sibi Sankar
2025-10-02  0:39   ` Rob Herring
2025-10-09 10:07     ` Sibi Sankar
2025-09-24 18:37 ` [PATCH 2/5] dt-bindings: mailbox: qcom-ipcc: Document Glymur physical client IDs Sibi Sankar
2025-10-02  0:37   ` Rob Herring
2025-09-24 18:37 ` [PATCH 3/5] dt-bindings: soc: qcom,aoss-qmp: Document the Glymur AOSS side channel Sibi Sankar
2025-09-24 18:37 ` [PATCH 4/5] dt-bindings: remoteproc: qcom,sm8550-pas: Document Glymur ADSP Sibi Sankar
2025-10-02  0:54   ` Rob Herring
2025-10-09 10:09     ` Sibi Sankar
2025-09-24 18:37 ` [PATCH 5/5] dt-bindings: remoteproc: qcom,sm8550-pas: Document Glymur CDSP Sibi Sankar
2025-10-02  0:55   ` Rob Herring (Arm)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).