[PATCH v2 0/2] Add video reset to aspeed-clk

[PATCH v2 0/2] Add video reset to aspeed-clk

[Jammy Huang]

Add missing video reset to aspeed clock controller drivers.

 v2 changes:
  - Add patch for drivers/clk/clk-aspeed.c
  - Update index of ASPEED_RESET_VIDEO

Jammy Huang (2):
  dt-bindings: clock: aspeed: Add VIDEO reset definition
  clk: aspeed: Add reset for HACE/VIDEO

 drivers/clk/clk-aspeed.c                 | 2 ++
 include/dt-bindings/clock/aspeed-clock.h | 1 +
 2 files changed, 3 insertions(+)


base-commit: 7f7072574127c9e971cad83a0274e86f6275c0d5
-- 
2.25.1

[PATCH v2 1/2] dt-bindings: clock: aspeed: Add VIDEO reset definition

[Jammy Huang]

ASPEED clock controller provides a couple of resets. Add the define of
video to allow referring to it.

Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>
---
 v2 changes:
  - Update index of ASPEED_RESET_VIDEO
---
 include/dt-bindings/clock/aspeed-clock.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/dt-bindings/clock/aspeed-clock.h b/include/dt-bindings/clock/aspeed-clock.h
index 06d568382c77..671e5a476eae 100644
--- a/include/dt-bindings/clock/aspeed-clock.h
+++ b/include/dt-bindings/clock/aspeed-clock.h
@@ -53,5 +53,6 @@
 #define ASPEED_RESET_AHB		8
 #define ASPEED_RESET_CRT1		9
 #define ASPEED_RESET_HACE		10
+#define ASPEED_RESET_VIDEO		11
 
 #endif
-- 
2.25.1

Re: [PATCH v2 1/2] dt-bindings: clock: aspeed: Add VIDEO reset definition

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 944 bytes --]

On Fri, Oct 03, 2025 at 09:58:44AM +0800, Jammy Huang wrote:
> ASPEED clock controller provides a couple of resets. Add the define of
> video to allow referring to it.
> 
> Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>
> ---
>  v2 changes:
>   - Update index of ASPEED_RESET_VIDEO

Ah, so here is the next version. I don't see how this can be correct if
21 was correct before. Was 21 wrong?
> ---
>  include/dt-bindings/clock/aspeed-clock.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/dt-bindings/clock/aspeed-clock.h b/include/dt-bindings/clock/aspeed-clock.h
> index 06d568382c77..671e5a476eae 100644
> --- a/include/dt-bindings/clock/aspeed-clock.h
> +++ b/include/dt-bindings/clock/aspeed-clock.h
> @@ -53,5 +53,6 @@
>  #define ASPEED_RESET_AHB		8
>  #define ASPEED_RESET_CRT1		9
>  #define ASPEED_RESET_HACE		10
> +#define ASPEED_RESET_VIDEO		11
>  
>  #endif
> -- 
> 2.25.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 1/2] dt-bindings: clock: aspeed: Add VIDEO reset definition

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1192 bytes --]

On Fri, Oct 03, 2025 at 09:49:00PM +0100, Conor Dooley wrote:
> On Fri, Oct 03, 2025 at 09:58:44AM +0800, Jammy Huang wrote:
> > ASPEED clock controller provides a couple of resets. Add the define of
> > video to allow referring to it.
> > 
> > Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>
> > ---
> >  v2 changes:
> >   - Update index of ASPEED_RESET_VIDEO
> 
> Ah, so here is the next version. I don't see how this can be correct if
> 21 was correct before. Was 21 wrong?

Given the driver has mappings, I guess this is actually correct.
Acked-by: Conor Dooley <conor.dooley@microchip.com>

> > ---
> >  include/dt-bindings/clock/aspeed-clock.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/dt-bindings/clock/aspeed-clock.h b/include/dt-bindings/clock/aspeed-clock.h
> > index 06d568382c77..671e5a476eae 100644
> > --- a/include/dt-bindings/clock/aspeed-clock.h
> > +++ b/include/dt-bindings/clock/aspeed-clock.h
> > @@ -53,5 +53,6 @@
> >  #define ASPEED_RESET_AHB		8
> >  #define ASPEED_RESET_CRT1		9
> >  #define ASPEED_RESET_HACE		10
> > +#define ASPEED_RESET_VIDEO		11
> >  
> >  #endif
> > -- 
> > 2.25.1
> > 



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[PATCH v2 2/2] clk: aspeed: Add reset for HACE/VIDEO

[Jammy Huang]

Add mappings of reset per hw's definition.

Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>
---
 drivers/clk/clk-aspeed.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clk/clk-aspeed.c b/drivers/clk/clk-aspeed.c
index ff84191d0fe8..74c8c1377b70 100644
--- a/drivers/clk/clk-aspeed.c
+++ b/drivers/clk/clk-aspeed.c
@@ -278,6 +278,8 @@ static const u8 aspeed_resets[] = {
 	[ASPEED_RESET_PECI]	= 10,
 	[ASPEED_RESET_I2C]	=  2,
 	[ASPEED_RESET_AHB]	=  1,
+	[ASPEED_RESET_HACE]	=  4,
+	[ASPEED_RESET_VIDEO]	=  6,
 
 	/*
 	 * SCUD4 resets start at an offset to separate them from
-- 
2.25.1