From: "André Draszik" <andre.draszik@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Peter Griffin" <peter.griffin@linaro.org>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Will McVicker" <willmcvicker@google.com>,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
"André Draszik" <andre.draszik@linaro.org>
Subject: [PATCH 02/10] dt-bindings: soc: samsung: exynos-pmu: allow power domains as child on g101
Date: Mon, 06 Oct 2025 17:43:28 +0100 [thread overview]
Message-ID: <20251006-gs101-pd-v1-2-f0cb0c01ea7b@linaro.org> (raw)
In-Reply-To: <20251006-gs101-pd-v1-0-f0cb0c01ea7b@linaro.org>
The power domains are a property of / implemented in the PMU. As such,
they should be modelled as child nodes of the PMU.
Update the example while at it.
Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
Note: Ideally, the newly added properties (ranges, etc.) should only be
'required' if "^power-domain@[0-9a-f]+$" exists as a patternProperty,
as they're needed only in that case. As-is, this patch now causes
warnings for existing DTs as they don't specify the new properties (and
they shouldn't need to). Only if DTs are updated to include
power-domains, such an update should also add the new properties.
I've not been able to come up with the correct schema syntax to achieve
that. dependencies, dependentRequired, and dependentSchemas don't seem
to support patterns. Similarly,
- if:
required:
- ...
then:
required:
- ...
doesn't allow patterns in the 'if' block (or I didn't get the syntax
right).
---
.../bindings/soc/samsung/exynos-pmu.yaml | 53 +++++++++++++++++++++-
1 file changed, 52 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
index f0fb24156da9b8980dcfd5339ae75f12a71cf6d6..c2db1cbb969a9a6fea5208dc2990f2144fa480e6 100644
--- a/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/exynos-pmu.yaml
@@ -93,6 +93,14 @@ properties:
minItems: 1
maxItems: 32
+ '#address-cells':
+ const: 1
+
+ '#size-cells':
+ const: 1
+
+ ranges: true
+
dp-phy:
$ref: /schemas/phy/samsung,dp-video-phy.yaml
unevaluatedProperties: false
@@ -138,7 +146,7 @@ required:
- compatible
- reg
-additionalProperties: false
+unevaluatedProperties: false
allOf:
- if:
@@ -201,10 +209,27 @@ allOf:
enum:
- google,gs101-pmu
then:
+ patternProperties:
+ "^power-domain@[0-9a-f]+$":
+ type: object
+ description: Child node describing one power domain within the PMU
+
+ additionalProperties: true
+
+ properties:
+ compatible:
+ const: google,gs101-pd
+
required:
+ - '#address-cells'
+ - '#size-cells'
+ - ranges
- google,pmu-intr-gen-syscon
else:
properties:
+ '#address-cells': false
+ '#size-cells': false
+ ranges: false
google,pmu-intr-gen-syscon: false
examples:
@@ -231,3 +256,29 @@ examples:
#phy-cells = <1>;
};
};
+
+ - |
+ system-controller@17460000 {
+ compatible = "google,gs101-pmu", "syscon";
+ reg = <0x17460000 0x10000>;
+ ranges;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ google,pmu-intr-gen-syscon = <&pmu_intr_gen>;
+
+ pd_g3d: power-domain@1e00 {
+ compatible = "google,gs101-pd";
+ reg = <0x1e00 0x80>;
+ #power-domain-cells = <0>;
+ label = "g3d";
+ };
+
+ power-domain@2000 {
+ compatible = "google,gs101-pd";
+ reg = <0x2000 0x80>;
+ #power-domain-cells = <0>;
+ power-domains = <&pd_g3d>;
+ label = "embedded_g3d";
+ };
+ };
--
2.51.0.618.g983fd99d29-goog
next prev parent reply other threads:[~2025-10-06 16:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-06 16:43 [PATCH 00/10] pmdomain: samsung: add supoort for Google GS101 André Draszik
2025-10-06 16:43 ` [PATCH 01/10] dt-bindings: power: samsung: add google,gs101-pd André Draszik
2025-10-07 20:46 ` Peter Griffin
2025-10-06 16:43 ` André Draszik [this message]
2025-10-09 0:09 ` [PATCH 02/10] dt-bindings: soc: samsung: exynos-pmu: allow power domains as child on g101 Krzysztof Kozlowski
2025-10-06 16:43 ` [PATCH 03/10] pmdomain: samsung: use to devm_kstrdup_const() to simplify error handling André Draszik
2025-10-07 20:53 ` Peter Griffin
2025-10-09 0:13 ` Krzysztof Kozlowski
2025-10-09 13:31 ` André Draszik
2025-10-09 14:00 ` André Draszik
2025-10-10 0:35 ` Krzysztof Kozlowski
2025-10-10 5:29 ` André Draszik
2025-10-06 16:43 ` [PATCH 04/10] pmdomain: samsung: convert to using regmap André Draszik
2025-10-06 16:43 ` [PATCH 05/10] pmdomain: samsung: convert to regmap_read_poll_timeout() André Draszik
2025-10-06 16:43 ` [PATCH 06/10] pmdomain: samsung: don't hardcode offset for registers to 0 and 4 André Draszik
2025-10-06 16:43 ` [PATCH 07/10] pmdomain: samsung: selectively handle enforced sync_state André Draszik
2025-10-09 0:15 ` Krzysztof Kozlowski
2025-10-06 16:43 ` [PATCH 08/10] pmdomain: samsung: try to get PMU (syscon) regmap André Draszik
2025-10-06 16:43 ` [PATCH 09/10] pmdomain: samsung: use dev_err() instead of pr_err() André Draszik
2025-10-09 0:18 ` Krzysztof Kozlowski
2025-10-06 16:43 ` [PATCH 10/10] pmdomain: samsung: add support for google,gs101-pd André Draszik
2025-10-09 0:19 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251006-gs101-pd-v1-2-f0cb0c01ea7b@linaro.org \
--to=andre.draszik@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=ulf.hansson@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).