devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "André Draszik" <andre.draszik@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	 Alim Akhtar <alim.akhtar@samsung.com>,
	Rob Herring <robh@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Peter Griffin" <peter.griffin@linaro.org>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>,
	"Will McVicker" <willmcvicker@google.com>,
	kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	"André Draszik" <andre.draszik@linaro.org>
Subject: [PATCH 07/10] pmdomain: samsung: selectively handle enforced sync_state
Date: Mon, 06 Oct 2025 17:43:33 +0100	[thread overview]
Message-ID: <20251006-gs101-pd-v1-7-f0cb0c01ea7b@linaro.org> (raw)
In-Reply-To: <20251006-gs101-pd-v1-0-f0cb0c01ea7b@linaro.org>

Unconditionally calling of_genpd_sync_state() causes issues on
platforms with child domains as the parent domain will be turned off
before the child domain was even registered during boot.

This in particular is an issue for the upcoming Google gs101 support -
all operations on child domains registered after the parent domain
misbehave.

Add a flag to the probe data to be able to sync_state conditionally
only, and enable that flag on the two platforms currently supported by
this driver.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
 drivers/pmdomain/samsung/exynos-pm-domains.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/pmdomain/samsung/exynos-pm-domains.c b/drivers/pmdomain/samsung/exynos-pm-domains.c
index 638d286b57f716140b2401092415644a6805870e..5a87802cff394945cb0202d08f2cf6bcbbcc774d 100644
--- a/drivers/pmdomain/samsung/exynos-pm-domains.c
+++ b/drivers/pmdomain/samsung/exynos-pm-domains.c
@@ -20,6 +20,7 @@
 struct exynos_pm_domain_config {
 	/* Value for LOCAL_PWR_CFG and STATUS fields for each domain */
 	u32 local_pwr_cfg;
+	unsigned int need_early_sync_state:1;
 };
 
 /*
@@ -69,10 +70,12 @@ static int exynos_pd_power_off(struct generic_pm_domain *domain)
 
 static const struct exynos_pm_domain_config exynos4210_cfg = {
 	.local_pwr_cfg		= 0x7,
+	.need_early_sync_state	= true,
 };
 
 static const struct exynos_pm_domain_config exynos5433_cfg = {
 	.local_pwr_cfg		= 0xf,
+	.need_early_sync_state	= true,
 };
 
 static const struct of_device_id exynos_pm_domain_of_match[] = {
@@ -179,7 +182,7 @@ static int exynos_pd_probe(struct platform_device *pdev)
 	 * reset during boot. As a temporary hack to manage this, let's enforce
 	 * a sync_state.
 	 */
-	if (!ret)
+	if (pm_domain_cfg->need_early_sync_state && !ret)
 		of_genpd_sync_state(np);
 
 	pm_runtime_enable(dev);

-- 
2.51.0.618.g983fd99d29-goog


  parent reply	other threads:[~2025-10-06 16:43 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-06 16:43 [PATCH 00/10] pmdomain: samsung: add supoort for Google GS101 André Draszik
2025-10-06 16:43 ` [PATCH 01/10] dt-bindings: power: samsung: add google,gs101-pd André Draszik
2025-10-07 20:46   ` Peter Griffin
2025-10-06 16:43 ` [PATCH 02/10] dt-bindings: soc: samsung: exynos-pmu: allow power domains as child on g101 André Draszik
2025-10-09  0:09   ` Krzysztof Kozlowski
2025-10-06 16:43 ` [PATCH 03/10] pmdomain: samsung: use to devm_kstrdup_const() to simplify error handling André Draszik
2025-10-07 20:53   ` Peter Griffin
2025-10-09  0:13   ` Krzysztof Kozlowski
2025-10-09 13:31     ` André Draszik
2025-10-09 14:00       ` André Draszik
2025-10-10  0:35         ` Krzysztof Kozlowski
2025-10-10  5:29           ` André Draszik
2025-10-06 16:43 ` [PATCH 04/10] pmdomain: samsung: convert to using regmap André Draszik
2025-10-06 16:43 ` [PATCH 05/10] pmdomain: samsung: convert to regmap_read_poll_timeout() André Draszik
2025-10-06 16:43 ` [PATCH 06/10] pmdomain: samsung: don't hardcode offset for registers to 0 and 4 André Draszik
2025-10-06 16:43 ` André Draszik [this message]
2025-10-09  0:15   ` [PATCH 07/10] pmdomain: samsung: selectively handle enforced sync_state Krzysztof Kozlowski
2025-10-06 16:43 ` [PATCH 08/10] pmdomain: samsung: try to get PMU (syscon) regmap André Draszik
2025-10-06 16:43 ` [PATCH 09/10] pmdomain: samsung: use dev_err() instead of pr_err() André Draszik
2025-10-09  0:18   ` Krzysztof Kozlowski
2025-10-06 16:43 ` [PATCH 10/10] pmdomain: samsung: add support for google,gs101-pd André Draszik
2025-10-09  0:19   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251006-gs101-pd-v1-7-f0cb0c01ea7b@linaro.org \
    --to=andre.draszik@linaro.org \
    --cc=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel-team@android.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=tudor.ambarus@linaro.org \
    --cc=ulf.hansson@linaro.org \
    --cc=willmcvicker@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).