From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34C382D7804 for ; Mon, 6 Oct 2025 16:26:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759768001; cv=none; b=ccvK0rsk21p6W/3BHUmJmS+6PcBJ1sAzzhRbrcEN/0TuAKFKkQeNQD1KhmZ0OOZOpW5zFxBGC+68r7rFRfac/O8ZQGFRpMsu6B0jxqaGngphv3gWXVguBae97481VTmgmkNVcq+8clDqD+dfd9wX1fzT7uAh7mmuzvjN+yeD7SY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759768001; c=relaxed/simple; bh=urAPi5PtnmEjVyblteohOkDho6JfrnjSMqTu5Ai3YXk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mvqZUxBF0MnaeL+rEEjuLlsyAeq/pTSOMBaRNg/lzMU5rPqQJfPO7Nv0hrMvTw9rEv43jlMPC/a/PlzCtoU+THdXWiAB3MuxBjmkAfZxuk6zOOFfviETE1rn2a7GLH6fC3R24/ZXVNKyLFcxK0ICtxnbZGIypBpkouu+kvUyCgQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=H/eQo43q; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="H/eQo43q" Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 1464CB7D; Mon, 6 Oct 2025 18:25:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1759767906; bh=urAPi5PtnmEjVyblteohOkDho6JfrnjSMqTu5Ai3YXk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H/eQo43qbQUcC3DL3yzFPzCSmJbqB7E//sIkVmKsAfpQ8l39r7q7ZfkDderkgM5eo 433Zf89qFnNQVhH/crzs8biSG5JaIZtKzdkXHe+BDNI7JZTjYs3R09QELaITQ3aOVa MGov8SwXecILaVDWMRZFWVY/hu3mn7sTLXADweLk= Date: Mon, 6 Oct 2025 19:26:31 +0300 From: Laurent Pinchart To: Cristian Ciocaltea Cc: Dmitry Baryshkov , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Alexey Charkov , Algea Cao , Andy Yan , Cenk Uluisik , Conor Dooley , Heiko Stuebner , Jimmy Hon , Kever Yang , Krzysztof Kozlowski , Maxime Ripard , Muhammed Efe Cetin , Ondrej Jirman , Rob Herring , Sandy Huang Subject: Re: [PATCH v2 2/5] drm/rockchip: dw_hdmi_qp: Improve error handling with dev_err_probe() Message-ID: <20251006162631.GK5944@pendragon.ideasonboard.com> References: <20251005235542.1017-1-laurent.pinchart@ideasonboard.com> <20251005235542.1017-3-laurent.pinchart@ideasonboard.com> <8706f168-5598-4f91-9ad0-fdbd04b410b7@collabora.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8706f168-5598-4f91-9ad0-fdbd04b410b7@collabora.com> On Mon, Oct 06, 2025 at 05:37:23PM +0300, Cristian Ciocaltea wrote: > On 10/6/25 3:02 PM, Dmitry Baryshkov wrote: > > On Mon, Oct 06, 2025 at 02:55:38AM +0300, Laurent Pinchart wrote: > >> From: Cristian Ciocaltea > >> > >> The error handling in dw_hdmi_qp_rockchip_bind() is quite inconsistent, > >> i.e. in some cases the error code is not included in the message, while > >> in some other cases there is no check for -EPROBE_DEFER. > >> > >> Since this is part of the probe path, address the aforementioned issues > >> by switching to dev_err_probe(), which also reduces the code a bit. > >> > >> Signed-off-by: Cristian Ciocaltea > >> Signed-off-by: Laurent Pinchart > >> --- > >> .../gpu/drm/rockchip/dw_hdmi_qp-rockchip.c | 62 +++++++------------ > >> 1 file changed, 24 insertions(+), 38 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c > >> index 7d531b6f4c09..4e7794aa2dde 100644 > >> --- a/drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c > >> +++ b/drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c > >> @@ -457,10 +457,8 @@ static int dw_hdmi_qp_rockchip_bind(struct device *dev, struct device *master, > >> return -ENODEV; > >> > >> if (!cfg->ctrl_ops || !cfg->ctrl_ops->io_init || > >> - !cfg->ctrl_ops->irq_callback || !cfg->ctrl_ops->hardirq_callback) { > >> - dev_err(dev, "Missing platform ctrl ops\n"); > >> - return -ENODEV; > >> - } > >> + !cfg->ctrl_ops->irq_callback || !cfg->ctrl_ops->hardirq_callback) > >> + return dev_err_probe(dev, -ENODEV, "Missing platform ctrl ops\n"); > > > > This only makes sense for the purpose of unification. > > Right, as mentioned in the commit description, the intention was to ensure > consistent error handling across the probe path rather than limiting the scope > to -EPROBE_DEFER exclusively. Should I revert this change in v3 or keep it ? I see value in unification, but I don't mind either way. Dmitry, what's your preference ? -- Regards, Laurent Pinchart