From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3817E3D987 for ; Tue, 7 Oct 2025 05:36:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759815379; cv=none; b=to4cP4JT/egk4FOdUwaBEe/iZFZ7WsgCCkoOAzOIBAWokersxt7aA2ax5t2F2mURi7h4vhUNa74mhU/BgFHjbKQ4lq4h9Aoh6xjClp1uIxvTsrhpnxN3D2ZU6aY2aEV+oj7BBrBgpj5ECYzsKQ0AqhV5VI+IRr0xLq9dM3imdsI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759815379; c=relaxed/simple; bh=zz6lPYQ1IJfuZS0Yj9SN8f1ym0BJqcUgvwAez0hXJaY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=KSyG3HLv65X9g94JTh1/J9/44UvRXvBI9XBut3zV6XdZabjLw16bA6SQhrq8scsIB099iXwFnF9U0O6UtWCVxxb1beGfXXH6NYtL4cEQFxVkM9w56ZvnqKnvb2fSZ8ATjisjpmh2Snkz0yA/in4BjfH8bDUJV4FjnDG7pkWXCeg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1v60Mv-0002SK-Fp; Tue, 07 Oct 2025 07:36:13 +0200 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v60Mu-002Li7-11; Tue, 07 Oct 2025 07:36:12 +0200 Received: from localhost ([::1] helo=dude05.red.stw.pengutronix.de) by dude05.red.stw.pengutronix.de with esmtp (Exim 4.98.2) (envelope-from ) id 1v60Mu-0000000C6Jh-12wQ; Tue, 07 Oct 2025 07:36:12 +0200 From: Ahmad Fatoum Date: Tue, 07 Oct 2025 07:36:02 +0200 Subject: [PATCH] ARM: dts: stm32: lxa: drop unnecessary vusb_d/a-supply Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251007-lxa-usb-dt-v1-1-cacde8088bb9@pengutronix.de> X-B4-Tracking: v=1; b=H4sIAMGm5GgC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDI1NDAwNz3ZyKRN3S4iTdlBLd5NQkA0MLS2NLs1QzJaCGgqLUtMwKsGHRsbW 1AF85bcxcAAAA X-Change-ID: 20251007-lxa-usb-dt-ceb0189396e6 To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue Cc: devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Ahmad Fatoum X-Mailer: b4 0.14.2 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org The LXA device trees are the only STM32MP1 device tree that specify vusb_d/usb_a-supply and apparently not for good reason: - vusb_d-supply (vdd_usb) is the same as the phy-supply for usbphyc_port1 - vusb_a-supply (reg18) is the same as vdda1v8-supply for usbphyc_port1 and usbphyc_port1 is linked to the usbotg_hs node via the phys property. Specifying the regulators in the &usbotg_hs node is thus superfluous and has been even found to be harmful in one instance: Linux v6.10 was found to lock up every 50-125 or so reboots on the LXA TAC when the DWC2 driver probe enables the regulators in bulk, unless both properties were removed. This issue was so far not reproducible on v6.17 (> 500 reboots), but as these properties are unnecessary and different from other STM32MP1 boards, remove them anyway. Signed-off-by: Ahmad Fatoum --- arch/arm/boot/dts/st/stm32mp153c-lxa-fairytux2.dtsi | 3 --- arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi | 3 --- 2 files changed, 6 deletions(-) diff --git a/arch/arm/boot/dts/st/stm32mp153c-lxa-fairytux2.dtsi b/arch/arm/boot/dts/st/stm32mp153c-lxa-fairytux2.dtsi index 9eeb9d6b5eb0ed35d4a83b743e8007f19422e2ed..7d3a6a3b5d09ea06689ebca11eda48785207aa31 100644 --- a/arch/arm/boot/dts/st/stm32mp153c-lxa-fairytux2.dtsi +++ b/arch/arm/boot/dts/st/stm32mp153c-lxa-fairytux2.dtsi @@ -374,9 +374,6 @@ &usbotg_hs { phys = <&usbphyc_port1 0>; phy-names = "usb2-phy"; - vusb_d-supply = <&vdd_usb>; - vusb_a-supply = <®18>; - status = "okay"; }; diff --git a/arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi b/arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi index be0c355d3105b89d4374d4f6972c7927970f06b1..9179075f2ead14a4deb45fcd2cefd60ab426a8d8 100644 --- a/arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi +++ b/arch/arm/boot/dts/st/stm32mp15xc-lxa-tac.dtsi @@ -493,9 +493,6 @@ &usbotg_hs { phys = <&usbphyc_port1 0>; phy-names = "usb2-phy"; - vusb_d-supply = <&vdd_usb>; - vusb_a-supply = <®18>; - g-rx-fifo-size = <512>; g-np-tx-fifo-size = <32>; g-tx-fifo-size = <128 128 64 16 16 16 16 16>; --- base-commit: 33f3d92bd1bee0e37d68124dd6e7df793a6af745 change-id: 20251007-lxa-usb-dt-ceb0189396e6 Best regards, -- Ahmad Fatoum