From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAA1C1F0E25 for ; Thu, 9 Oct 2025 15:25:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760023512; cv=none; b=eXmwhB464XnfegyAY0edqica0mYVNCvbW/z8Oksk/JSuUsJoJu0qM6E7a+0/xbKVKEjxjKDSDWYlG4RUJTrn4a7DB9XTvtmUhoLLujg4nuYSn4ol2vz2cKaBuAqMUhReDvStHxfA+ysnMIm/Nizw7DcDKLrwYspPN1+Pfq0M4ts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760023512; c=relaxed/simple; bh=8Ji8C7SpUzRnr4uMcWokKZW8lUvYX6JJLUSo4lu5Nb0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dyiK7nXASpfTAzlG31YJcpsPfSgAGv4Sf75fD/zoeoAQEZhJTw6KjQUlTHoY/WQ7p953J9yrU42LkuvirWGxgeim73TSSM/Z0XDnIxTU3ax6yYEx0/sIN5QXVhonCI3RQZOluw6B11k5ffn32JvwRL9OVtDdLInLYmodT/hhZAA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=txHzJWNF; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="txHzJWNF" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-afcb7ae6ed0so166674166b.3 for ; Thu, 09 Oct 2025 08:25:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760023507; x=1760628307; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ousPsrsRzOuJ9D//mwlWhy/3PCTfUESlugicNK8z87Q=; b=txHzJWNFiTE2JcnC5bG/2BCoGJAALc13E+ze6lvCIdC1ko4/4SY5l9qMQr+GBNDgxN OiS3lN1EMVH7eWdRPwPz221avsGZuWhF3rSzIOa3r0h+y1MB9O8572mwfHkSHosz8g6L aG7MIrvX1bqhP993pyHFq7zAm1Ied0ThMOpJixADrCRzhlvfXpBumRVYeq6N4p6gkVZm W8Ug8Q6nnSeqe5yTT2EI+/MvO/dYrkS4muRChBf0FcPXauk4yQRCDxiz05BzBOe0MUgG ucdD2Y9lj+pnpDeE6GDhA6ZoSZ6+RUYAWEx3rSfsh/28C1VwAsAOLXHprOGCj78ERZDU F0gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760023507; x=1760628307; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ousPsrsRzOuJ9D//mwlWhy/3PCTfUESlugicNK8z87Q=; b=mflnku+Sk+PHRdxVSNXSBK+H9bgf0Sa8ZZ0rpRRrFekjENm/2T/37mcDZB5I+kTErN w/jTJ5jRFitMzmkML+Br+Ih7i906Ec7GOXZO39Xrt6X6wHHIgOQ8rKxBAHz0sykE7Gb+ D28zhXJqDSghv7rFj6axGssQ/BtDmksVDSo93k/d84HKkLDSYLsprEMzyl3/qJdWJAvK trYwKN3krlVRURQ4s2s8K+tt4KunMtfHHFszBw5tDlrSoUzbCM/ewtYIB1QDDt6PcQzY oVoFoSQjlzNA0M1QcL7e2hU3YY4gKGeQWUd/FTqoefOZVpJ2KPqfMPcxU+59WiSBuezW LPfg== X-Forwarded-Encrypted: i=1; AJvYcCVU6mJZkxKQWZ7GKA0PK60CVHlgJZkQIBPN4l70x4Z9yKKSjJj5OMfNCONmlXgIldk8WTvCKLcubAiR@vger.kernel.org X-Gm-Message-State: AOJu0YwCggUt9UjcjolasON3lnfomFXIUoImz4x+QVWv28z2arqZgb5Q Fbi7a2+UXrqD1Ff/kArBS6fP/1CbztOKS3NKAg+k3iItqsZTUeZb6TjheOc9TT+j5qs= X-Gm-Gg: ASbGncv/T1hnX18iNKNbUGQ+K0UCgKShGslv+JYkWe4ZktMYZdnYpLXiPrDKOn+vnJV v0LiZFLXJ5KgXWUPXJMrKURrQhh5mhWSOVeMdmD+iycaKNcOLlw+1PMTbHmUbbDO472xea7ErJC bBpqKHjD/I/+ebDhN8yj/UKfpRsC8+JV102+GwZcRuw1NPscXmNGSoMSd9a98og99IgbSTkdRba FahfpCT42DbavwpG5dcVXa1T4M9gao7cm+eCMgehDNQPuo++lsucGmwTBTth2vXQNOEq0QO6LmL t4rzYAe5WAnzg1ZS6BR42n1oynnjj5aBzwaB7a8mJtAPTXySzEo84VS8cyvNEPOB7hUf1dP5Z/c L7cxJ/mUl67U82LwqH4r2R2iYn6Zbw+xnC+rh4JeSzLGylM8geCCa7kCot0cuIF5LX5jXfraryd 4EeFOb1bsA3yBrKn1ypTWwbS47XZgTXd8ZxSg0DpZdvot5fKJmPe0= X-Google-Smtp-Source: AGHT+IGU5YJiQEOLDla4H1yxJNOxda/6iu+/j1tDENPR+jWfagJHuOHAMVeCVTX+CKrhpEHAyCcJqQ== X-Received: by 2002:a17:907:934a:b0:b48:730:dbb3 with SMTP id a640c23a62f3a-b50ac1cc3eemr881096366b.32.1760023507336; Thu, 09 Oct 2025 08:25:07 -0700 (PDT) Received: from puffmais2.c.googlers.com (224.138.204.35.bc.googleusercontent.com. [35.204.138.224]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b486970b36fsm1908967566b.62.2025.10.09.08.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Oct 2025 08:25:06 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Thu, 09 Oct 2025 16:25:06 +0100 Subject: [PATCH v2 04/10] pmdomain: samsung: plug potential memleak during probe Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20251009-gs101-pd-v2-4-3f4a6db2af39@linaro.org> References: <20251009-gs101-pd-v2-0-3f4a6db2af39@linaro.org> In-Reply-To: <20251009-gs101-pd-v2-0-3f4a6db2af39@linaro.org> To: Krzysztof Kozlowski , Alim Akhtar , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Ulf Hansson , Marek Szyprowski Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= , stable@vger.kernel.org X-Mailer: b4 0.14.2 of_genpd_add_provider_simple() could fail, in which case this code leaks the domain name, pd->pd.name. Use devm_kstrdup_const() to plug this leak. As a side-effect, we can simplify existing error handling. Fixes: c09a3e6c97f0 ("soc: samsung: pm_domains: Convert to regular platform driver") Cc: stable@vger.kernel.org Reviewed-by: Peter Griffin Signed-off-by: André Draszik --- v2: reword commit message, as this isn't a pure simplification --- drivers/pmdomain/samsung/exynos-pm-domains.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/pmdomain/samsung/exynos-pm-domains.c b/drivers/pmdomain/samsung/exynos-pm-domains.c index 5d478bb37ad68afc7aed7c6ae19b5fefc94a9035..f53e1bd2479807988f969774b4b7b4c5739c1aba 100644 --- a/drivers/pmdomain/samsung/exynos-pm-domains.c +++ b/drivers/pmdomain/samsung/exynos-pm-domains.c @@ -92,13 +92,14 @@ static const struct of_device_id exynos_pm_domain_of_match[] = { { }, }; -static const char *exynos_get_domain_name(struct device_node *node) +static const char *exynos_get_domain_name(struct device *dev, + struct device_node *node) { const char *name; if (of_property_read_string(node, "label", &name) < 0) name = kbasename(node->full_name); - return kstrdup_const(name, GFP_KERNEL); + return devm_kstrdup_const(dev, name, GFP_KERNEL); } static int exynos_pd_probe(struct platform_device *pdev) @@ -115,15 +116,13 @@ static int exynos_pd_probe(struct platform_device *pdev) if (!pd) return -ENOMEM; - pd->pd.name = exynos_get_domain_name(np); + pd->pd.name = exynos_get_domain_name(dev, np); if (!pd->pd.name) return -ENOMEM; pd->base = of_iomap(np, 0); - if (!pd->base) { - kfree_const(pd->pd.name); + if (!pd->base) return -ENODEV; - } pd->pd.power_off = exynos_pd_power_off; pd->pd.power_on = exynos_pd_power_on; -- 2.51.0.710.ga91ca5db03-goog