From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91F3023B63F; Thu, 9 Oct 2025 17:13:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760030022; cv=none; b=G+8EE/IwY36esDsFdTrJFz0XGHjsfq0oC4fjSCa4Vuse6p5FmEnuAzDnGi308FsTCpJk9Z25kD1pjoVAZdmdxzMqTJ3X3qBT8efNkt8hYbDcawMDdv7Df+X2PY4xcwabrOXpwbya/2oNlS/Km48ofOYpoXorNE3AFbWP/ihWInw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760030022; c=relaxed/simple; bh=4m/b40Q8HlHAkCFpCXHLrFt6Ce02CTpjazD5P0VykkE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=l7n5E5FmZW9MJ/1vBbe0lh7J6JtgOjdHENmuYD1cw4WKDZjJiIPe8t/81Z7SsfmEC1E8dM35x1SjmsyTfbZR4QzUGBeY6B9favk+J8ZzS2yDiD40KEy2zS3qHqawHGMEb3N+w+DxUOaW3uw/mr+kz0dgvxaIAc6+VJmDgsvVJO8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sQ3mn/VD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sQ3mn/VD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6127AC4CEE7; Thu, 9 Oct 2025 17:13:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760030022; bh=4m/b40Q8HlHAkCFpCXHLrFt6Ce02CTpjazD5P0VykkE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sQ3mn/VDly7N6oRo4YHgs3kB4pz8mCUs06Vf6MTzzHsGNRnR0UrMzRMakSX0IlDsO IDxfG4ti/zNQx92aK8O4FkV8izUQ88X1aD3M1R6rccbNrgaqDOqVUmw+wKTHXmvXyZ 9gd7gPJF59QtGz5Gd++meMjtLhkcbufX0B2FzNwP1FJti+ONeTDDUvY5usngDNLJkM qzqMhuAFuIU8gNzmjiEWgHMP2w8VIIFi99yzpAR5rR09uEEQLHTUhbUAd2ZNqTCFkY 1H/WAapbKklLusROb8CPfopsy7NKxeDDGtgzpxKWwV6PJtV1Gmv/+VXRK6gduHYyZS pJ9R2ZuMWH5vw== Date: Thu, 9 Oct 2025 18:13:36 +0100 From: Conor Dooley To: Roy Luo Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Thinh Nguyen , Philipp Zabel , Peter Griffin , =?iso-8859-1?Q?Andr=E9?= Draszik , Tudor Ambarus , Joy Chakraborty , Naveen Kumar , Badhri Jagan Sridharan , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v2 1/4] dt-bindings: usb: dwc3: Add Google Tensor G5 DWC3 Message-ID: <20251009-lizard-slapstick-4de7dfe2322d@spud> References: <20251008060000.3136021-1-royluo@google.com> <20251008060000.3136021-2-royluo@google.com> <20251008-slider-uncombed-66790ea92ea0@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="V8Kj8DQ2DFM161Td" Content-Disposition: inline In-Reply-To: --V8Kj8DQ2DFM161Td Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 08, 2025 at 09:40:57PM -0700, Roy Luo wrote: > On Wed, Oct 8, 2025 at 1:58=E2=80=AFPM Conor Dooley wr= ote: > > > > On Wed, Oct 08, 2025 at 05:59:57AM +0000, Roy Luo wrote: > > > +allOf: > > > + - $ref: snps,dwc3-common.yaml# > > > + > > > +unevaluatedProperties: false > > > > So every property from snps,dwc3-common.yaml is valid here, with any of > > the permitted values? >=20 > Conor, >=20 > Appreciate the review. > Ack to all the comments, will fix them in the next patch. > And yes, every property from snps,dwc3-common.yaml is valid here. > You can find more context here [1], essentially the dwc3 glue would be > operating on the same platform device as the dwc3 core, hence all > properties are allowed. >=20 > [1] https://lore.kernel.org/all/20250414-dwc3-refactor-v7-0-f015b358722d@= oss.qualcomm.com/ I find it exceedingly hard to believe that every property from that file, with every permitted value, is possible. AFAIU, the tensor g5 is a phone chip that's only used in pixel devices, not something that people can just buy and integrate into whatever device they feel like. There should be a vanishingly small number of possible configurations, possibly exactly one configuration. There are dozens of properties in the dwc3 common binding, of which at least 10 are for "quirks" or other sorts of hardware errata that are not going to be variable from one phone to another. --V8Kj8DQ2DFM161Td Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaOftPwAKCRB4tDGHoIJi 0orZAQDVQounnZp8XW0MZDnLxiorx4hG4jOujXdg9qHFe7k1qgD/eJp5UpO9UKjh jvA+gND8RxLGnuG3C6H3uJAs4WuugQw= =JWpo -----END PGP SIGNATURE----- --V8Kj8DQ2DFM161Td--