From: Rob Herring <robh@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] dt-bindings: iio: accel: adxl345: document second interrupt
Date: Thu, 9 Oct 2025 15:47:26 -0500 [thread overview]
Message-ID: <20251009204726.GA3306624-robh@kernel.org> (raw)
In-Reply-To: <20251006172119.2888-2-wsa+renesas@sang-engineering.com>
On Mon, Oct 06, 2025 at 07:21:17PM +0200, Wolfram Sang wrote:
> The pinout of all the supported chips in this binding have two interrupt
> pins. Document the second one, too, even though the Linux driver
> currently does not support the second interrupt. Boards may have it
> wired nonetheless.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Passes dt_binding_check. But uncovers another issue. See coverletter.
>
> .../bindings/iio/accel/adi,adxl345.yaml | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> index a23a626bfab6..806b0250ec07 100644
> --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> @@ -35,11 +35,16 @@ properties:
> spi-3wire: true
>
> interrupts:
> - maxItems: 1
> + minItems: 1
> + maxItems: 2
>
> interrupt-names:
> - items:
> - - enum: [INT1, INT2]
> + oneOf:
> + - items:
> + - enum: [INT1, INT2]
> + - items:
> + - const: INT1
> + - const: INT2
This is better written as:
minItems: 1
items:
- enum: [INT1, INT2]
- const: INT2
It is mainly better because using 'oneOf' results in poor error
messages.
Rob
next prev parent reply other threads:[~2025-10-09 20:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-06 17:21 [RFC PATCH 0/2] another 'interrupts-extended' replacement needed? Wolfram Sang
2025-10-06 17:21 ` [RFC PATCH 1/2] dt-bindings: iio: accel: adxl345: document second interrupt Wolfram Sang
2025-10-08 9:51 ` Geert Uytterhoeven
2025-10-09 20:47 ` Rob Herring [this message]
2025-10-09 21:44 ` Wolfram Sang
2025-11-06 8:44 ` Geert Uytterhoeven
2025-10-10 7:55 ` Geert Uytterhoeven
2025-10-06 17:21 ` [RFC PATCH 2/2] ARM: dts: renesas: kzm9g: name interrupts for accelerometer Wolfram Sang
2025-10-08 9:51 ` Geert Uytterhoeven
2025-10-09 20:35 ` [RFC PATCH 0/2] another 'interrupts-extended' replacement needed? Rob Herring
2025-10-09 20:38 ` Rob Herring
2025-10-09 21:47 ` Wolfram Sang
2025-10-10 9:39 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251009204726.GA3306624-robh@kernel.org \
--to=robh@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).