Re: AW: [PATCH v5 1/2] dt-bindings: iio: imu: smi330: Add binding

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 3367 bytes --]

On Fri, Oct 10, 2025 at 08:13:12AM +0000, Shen Jianping (ME-SE/EAD2) wrote:
> Hello Conor and Krzysztof,
> 
> Sorry for that. The patch is automatically generated. The ack shall be automatically added to patch. For some reason the ack was not properly handeled in the automatic generation. This will not happen again.

I don't care if the patch is automatically generated, it is still
your responsibility to do these things correctly - doubly so I would say
if you are using some AI or automatic assistance to create the patch.

You signed off on it, you need to make sure it is right.

> We have a kernel test robot finding in v4.   [jic23-iio:testing 119/122] smi330_core.c:undefined reference to `ffs'.  The patch v5 is to fix this finding.

Given the patch has been applied, the typical thing to do is to send a
follow-up patch fixing the issue.

Maybe you automatic patch generator should also tell you not to top
post, but since it hasn't: don't top post. Also don't use whatever tool
is mangling links.

Thanks,
Conor.

> 
> Best regards
> Jianping
> 
> >>> From: Jianping Shen <Jianping.Shen@de.bosch.com>
> >>>
> >>> Add devicetree binding for Bosch imu smi330.
> >>> The smi330 is a combined three axis angular rate and three axis
> >>> acceleration sensor module.
> >>>
> >>> Signed-off-by: Jianping Shen <Jianping.Shen@de.bosch.com>
> >>
> >> https://lore/
> >> .kernel.org%2Fall%2F20250916-henna-rinsing-32a18a4d30b9%40spud%2F&data
> >>
> >=05%7C02%7CJianping.Shen%40de.bosch.com%7Cb16bd41f74b6439328e908de0
> >7a0
> >>
> >6a33%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C63895658272275205
> >1%7
> >>
> >CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwM
> >CIsIlA
> >>
> >iOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=dA
> >%2F
> >> lUR6HfaamYwPotYUdUrHiaG2LgGJm8LEcmRth%2FjQ%3D&reserved=0
> >>
> >> Why did you ignore my ack?
> >> Didn't Jonathan already apply v4 of this two weeks ago, why is there
> >> even a v5 to begin with?
> >
> >Not only v4, but also v2 and reminder in v3:
> >
> >https://lore.kernel.or/
> >g%2Fall%2F20250514-deserve-marina-
> >224bef5b2db3%40spud%2F&data=05%7C02%7CJianping.Shen%40de.bosch.com
> >%7Cb16bd41f74b6439328e908de07a06a33%7C0ae51e1907c84e4bbb6d648ee58410
> >f4%7C0%7C0%7C638956582722772435%7CUnknown%7CTWFpbGZsb3d8eyJFbXB
> >0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIld
> >UIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=7lgke1m7JvcNjIKigI4ugH4fffFSZBZgZ
> >PQvClYsAsk%3D&reserved=0
> >
> >
> >and here I exactly reminded what has to be done:
> >https://lore.kernel.or/
> >g%2Fall%2F1196da81-ecd7-487c-8afc-
> >e0d3660fa158%40kernel.org%2F&data=05%7C02%7CJianping.Shen%40de.bosch.c
> >om%7Cb16bd41f74b6439328e908de07a06a33%7C0ae51e1907c84e4bbb6d648ee58
> >410f4%7C0%7C0%7C638956582722786576%7CUnknown%7CTWFpbGZsb3d8eyJF
> >bXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCI
> >sIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=toM%2BhpSCP6sNu8PU7Ed8iDG
> >sQIRm6IvdYiWV8sdGjmo%3D&reserved=0
> >
> >which was completely ignored.
> >
> >So I can write detailed instructions and Jianping will just ignore it, because who am I
> >to say anything?
> >
> >I will ignore future contributions from Jianping in such case. It is waste of our time.
> >
> >Best regards,
> >Krzysztof

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]