From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E129127702A; Fri, 10 Oct 2025 22:38:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.211.166.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760135904; cv=none; b=nzeYQWTCSo44B5Gj0o+RxDdeuyeVQ+5rx6ddyS0zPqclFN/dbq5r8wQneQ5/BFZ0jsevdk296YQMYAHSyNAW70gBPEoyP6BU36pCgur+RgJIqA+Z9q8kLxedFT6vtbV4yT5rk1Yi+2eyA3Vwf93IwVaiFOdFxZNwtGYk/eehfoo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760135904; c=relaxed/simple; bh=374wr/b4fL2bo/wwRgCbEqmUug+MPj4XalHAMWo2I98=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bQ79kwZPipAkmKN4oyMGJN3lQ3A+e12fbRhkhKpKKmxAgVHT819pW2TUoUyn5JLK9iAMrWYj09HlvdmK5HvZfgOXJ72dI+cVezYTlxJ2G0vVzQccf9m00SgQGBBhHbR9Q/z8JpGcqfeieQQ8FzFTl3BTcxYufJDFyi5pi1KQGkQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org; spf=pass smtp.mailfrom=gentoo.org; arc=none smtp.client-ip=140.211.166.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gentoo.org Received: from localhost (unknown [116.232.147.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange secp256r1 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dlan) by smtp.gentoo.org (Postfix) with ESMTPSA id EAABC340DCC; Fri, 10 Oct 2025 22:38:21 +0000 (UTC) Date: Sat, 11 Oct 2025 06:38:16 +0800 From: Yixun Lan To: Troy Mitchell Cc: Vivian Wang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yangyu Chen , devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/5] riscv: dts: spacemit: add Ethernet support for MusePi Pro Message-ID: <20251010223816-GYA1444158@gentoo.org> References: <20251010-k1-musepi-pro-dts-v2-0-6e1b491f6f3e@linux.spacemit.com> <20251010-k1-musepi-pro-dts-v2-5-6e1b491f6f3e@linux.spacemit.com> <59657BBB86F7B678+aOilnA5Z-QL7xF9O@kernel.org> <20251010064310-GYA1439398@gentoo.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251010064310-GYA1439398@gentoo.org> Hi Troy, On 14:43 Fri 10 Oct , Yixun Lan wrote: > Hi Troy, Vivian: > > On 14:20 Fri 10 Oct , Troy Mitchell wrote: > > On Fri, Oct 10, 2025 at 02:13:31PM +0800, Vivian Wang wrote: > > > > [snip].. > > > > > > Maybe Yixun can chime in about this as well. > > We have talked here [1] > > > > Personally, I think splitting them makes the commit history clearer. > > I'm happy to merge them if others also think it's more appropriate. > > > I do not have strong preference, either way is fine for me > If you plan to split the DT into fine patches, then go ahead please squash the patches, see Conor's suggestion here: https://lore.kernel.org/all/20251010-confider-raven-0ad7a810e5de@spud/ Also, I'd plan to collect patches once v6.18-rc1 tagged, you can wait and do it after that.. -- Yixun Lan (dlan)