devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Shrikant Raskar <raskar.shree97@gmail.com>,
	jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org
Cc: oe-kbuild-all@lists.linux.dev, dlechner@baylibre.com,
	nuno.sa@analog.com, andy@kernel.org, matt@ranostay.sg,
	skhan@linuxfoundation.org, david.hunter.linux@gmail.com,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linux.dev,
	Shrikant Raskar <raskar.shree97@gmail.com>
Subject: Re: [PATCH v2 2/2] iio: health: max30100: Add pulse-width configuration via DT
Date: Sat, 11 Oct 2025 00:24:06 +0800	[thread overview]
Message-ID: <202510110029.epOLovuF-lkp@intel.com> (raw)
In-Reply-To: <20251008031737.7321-3-raskar.shree97@gmail.com>

Hi Shrikant,

kernel test robot noticed the following build errors:

[auto build test ERROR on jic23-iio/togreg]
[also build test ERROR on robh/for-next v6.17]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Shrikant-Raskar/dt-bindings-iio-max30100-Add-pulse-width-property/20251010-102537
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link:    https://lore.kernel.org/r/20251008031737.7321-3-raskar.shree97%40gmail.com
patch subject: [PATCH v2 2/2] iio: health: max30100: Add pulse-width configuration via DT
config: csky-randconfig-001-20251010 (https://download.01.org/0day-ci/archive/20251011/202510110029.epOLovuF-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251011/202510110029.epOLovuF-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510110029.epOLovuF-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/iio/health/max30100.c: In function 'max30100_chip_init':
>> drivers/iio/health/max30100.c:352:34: error: implicit declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration]
     352 |                                  FIELD_PREP(MAX30100_REG_SPO2_CONFIG_PW_MASK, pulse_width));
         |                                  ^~~~~~~~~~


vim +/FIELD_PREP +352 drivers/iio/health/max30100.c

   327	
   328	static int max30100_chip_init(struct max30100_data *data)
   329	{
   330		int ret;
   331		int pulse_width;
   332		/* set default pulse-width-us to 1600us */
   333		unsigned int pulse_us = 1600;
   334		struct device *dev = &data->client->dev;
   335	
   336		/* setup LED current settings */
   337		ret = max30100_led_init(data);
   338		if (ret)
   339			return ret;
   340	
   341		/* Read pulse-width-us from DT */
   342		device_property_read_u32(dev, "maxim,pulse-width-us", &pulse_us);
   343	
   344		pulse_width = max30100_get_pulse_width(pulse_us);
   345		if (pulse_width < 0)
   346			return dev_err_probe(dev, pulse_width, "invalid pulse-width %uus\n", pulse_us);
   347	
   348		/* enable hi-res SPO2 readings at 100Hz */
   349		ret = regmap_write(data->regmap, MAX30100_REG_SPO2_CONFIG,
   350					 MAX30100_REG_SPO2_CONFIG_HI_RES_EN |
   351					 MAX30100_REG_SPO2_CONFIG_100HZ |
 > 352					 FIELD_PREP(MAX30100_REG_SPO2_CONFIG_PW_MASK, pulse_width));
   353		if (ret)
   354			return ret;
   355	
   356		/* enable SPO2 mode */
   357		ret = regmap_update_bits(data->regmap, MAX30100_REG_MODE_CONFIG,
   358					 MAX30100_REG_MODE_CONFIG_MODE_MASK,
   359					 MAX30100_REG_MODE_CONFIG_MODE_HR_EN |
   360					 MAX30100_REG_MODE_CONFIG_MODE_SPO2_EN);
   361		if (ret)
   362			return ret;
   363	
   364		/* enable FIFO interrupt */
   365		return regmap_update_bits(data->regmap, MAX30100_REG_INT_ENABLE,
   366					 MAX30100_REG_INT_ENABLE_MASK,
   367					 MAX30100_REG_INT_ENABLE_FIFO_EN
   368					 << MAX30100_REG_INT_ENABLE_MASK_SHIFT);
   369	}
   370	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2025-10-10 16:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-08  3:17 [PATCH v2 0/2] iio: health: max30100: Add DT pulse-width support Shrikant Raskar
2025-10-08  3:17 ` [PATCH v2 1/2] dt-bindings: iio: max30100: Add pulse-width property Shrikant Raskar
2025-10-08 12:55   ` Rob Herring (Arm)
2025-10-11 10:38     ` Shrikant
2025-10-09  0:44   ` Krzysztof Kozlowski
2025-10-11 10:52     ` Shrikant
2025-10-10 17:49   ` David Lechner
2025-10-12 17:41     ` Shrikant
2025-10-12 17:06   ` Jonathan Cameron
2025-10-12 17:37     ` Shrikant
2025-10-08  3:17 ` [PATCH v2 2/2] iio: health: max30100: Add pulse-width configuration via DT Shrikant Raskar
2025-10-09 10:52   ` Nuno Sá
2025-10-12 17:45     ` Shrikant
2025-10-10 16:24   ` kernel test robot [this message]
2025-10-10 17:55   ` David Lechner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202510110029.epOLovuF-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=david.hunter.linux@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@ranostay.sg \
    --cc=nuno.sa@analog.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=raskar.shree97@gmail.com \
    --cc=robh@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).