Re: [PATCH v2] dt-bindings: mmc: ti,da830-mmc: convert to DT schema

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 4396 bytes --]

On Sat, Oct 11, 2025 at 08:52:07AM +0000, Charan Pedumuru wrote:
> Convert TI Highspeed MMC host controller binding to YAML format. Define
> 'clocks' and 'interrupts' properties to resolve errors identified by
> 'dt_check' and 'dtb_check'.
> 
> Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>
> ---
> Changes in v2:
> - Modified the commit message.
> - Removed 'interrupts' from required properties following the old binding.
> - Changed the maintainer for the binding to "Conor Dooley".

Bro, what? Where did that come from? I know nothing about this device at
all. Find someone from TI to put there.

Conor.


> - Link to v1: https://lore.kernel.org/r/20250523-davinci-mmc-v1-1-ceebd8352d9c@gmail.com
> ---
>  .../devicetree/bindings/mmc/davinci_mmc.txt        | 32 ------------
>  .../devicetree/bindings/mmc/ti,da830-mmc.yaml      | 61 ++++++++++++++++++++++
>  2 files changed, 61 insertions(+), 32 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/davinci_mmc.txt b/Documentation/devicetree/bindings/mmc/davinci_mmc.txt
> deleted file mode 100644
> index 516fb0143d4c21d1c8e44a8846d55ea5458d7b74..0000000000000000000000000000000000000000
> --- a/Documentation/devicetree/bindings/mmc/davinci_mmc.txt
> +++ /dev/null
> @@ -1,32 +0,0 @@
> -* TI Highspeed MMC host controller for DaVinci
> -
> -The Highspeed MMC Host Controller on TI DaVinci family
> -provides an interface for MMC, SD and SDIO types of memory cards.
> -
> -This file documents the properties used by the davinci_mmc driver.
> -
> -Required properties:
> -- compatible:
> - Should be "ti,da830-mmc": for da830, da850, dm365
> - Should be "ti,dm355-mmc": for dm355, dm644x
> -
> -Optional properties:
> -- bus-width: Number of data lines, can be <1>, <4>, or <8>, default <1>
> -- max-frequency: Maximum operating clock frequency, default 25MHz.
> -- dmas: List of DMA specifiers with the controller specific format
> -	as described in the generic DMA client binding. A tx and rx
> -	specifier is required.
> -- dma-names: RX and TX  DMA request names. These strings correspond
> -	1:1 with the DMA specifiers listed in dmas.
> -
> -Example:
> -mmc0: mmc@1c40000 {
> -	compatible = "ti,da830-mmc",
> -	reg = <0x40000 0x1000>;
> -	interrupts = <16>;
> -	bus-width = <4>;
> -	max-frequency = <50000000>;
> -	dmas = <&edma 16
> -		&edma 17>;
> -	dma-names = "rx", "tx";
> -};
> diff --git a/Documentation/devicetree/bindings/mmc/ti,da830-mmc.yaml b/Documentation/devicetree/bindings/mmc/ti,da830-mmc.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..1a97c3e447fd10f14bfe0af9e22f9479304f0f26
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/ti,da830-mmc.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/ti,da830-mmc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI Highspeed MMC host controller for DaVinci
> +
> +description:
> +  The Highspeed MMC Host Controller on TI DaVinci family
> +  provides an interface for MMC, SD and SDIO types of memory cards.
> +
> +allOf:
> +  - $ref: mmc-controller.yaml
> +
> +maintainers:
> +  - Conor Dooley <conor+dt@kernel.org>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,da830-mmc
> +      - ti,dm355-mmc
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 2
> +
> +  dmas:
> +    maxItems: 2
> +
> +  dma-names:
> +    items:
> +      - const: rx
> +      - const: tx
> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    mmc@1c40000 {
> +        compatible = "ti,da830-mmc";
> +        reg = <0x40000 0x1000>;
> +        interrupts = <16 IRQ_TYPE_LEVEL_HIGH>,
> +                     <17 IRQ_TYPE_LEVEL_HIGH>;
> +        bus-width = <4>;
> +        max-frequency = <50000000>;
> +        dmas = <&edma 16>, <&edma 17>;
> +        dma-names = "rx", "tx";
> +    };
> +...
> 
> ---
> base-commit: 7bac2c97af4078d7a627500c9bcdd5b033f97718
> change-id: 20250523-davinci-mmc-c704440c3dd0
> 
> Best regards,
> -- 
> Charan Pedumuru <charan.pedumuru@gmail.com>
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]