Re: [PATCH 1/2] dt-bindings: clk: si522xx: Clock driver for Skyworks Si522xx I2C PCIe clock generators

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 3775 bytes --]

On Sun, Oct 12, 2025 at 12:35:59AM +0200, Marek Vasut wrote:
> Document the Skyworks Si522xx PCIe clock generators. Supported models are
> Si52202/Si52204/Si52208/Si52212. While chip is similar to Si521xx, it also
> contains many subtle differences to justify separate driver.
> 
> The Si522xx has different register and bit layout, supports spread spectrum
> clocking and slew rate settings, and no longer contains the old BC Byte Count
> configuration register. Instead, the I2C protocol is yet again very slightly
> different, but this time at least compatible with regmap.
> 
> Signed-off-by: Marek Vasut <marek.vasut@mailbox.org>
> ---
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: linux-clk@vger.kernel.org
> ---
>  .../bindings/clock/skyworks,si522xx.yaml      | 79 +++++++++++++++++++
>  1 file changed, 79 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/skyworks,si522xx.yaml
> 
> diff --git a/Documentation/devicetree/bindings/clock/skyworks,si522xx.yaml b/Documentation/devicetree/bindings/clock/skyworks,si522xx.yaml
> new file mode 100644
> index 0000000000000..6ad26543f9d21
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/skyworks,si522xx.yaml

Can you just pick one of the compatibles here?

> @@ -0,0 +1,79 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/skyworks,si522xx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Skyworks Si522xx I2C PCIe clock generators
> +
> +description: |
> +  The Skyworks Si522xx are I2C PCIe clock generators providing
> +  from 2 to 12 output clocks.
> +
> +maintainers:
> +  - Marek Vasut <marek.vasut@mailbox.org>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - skyworks,si52202
> +      - skyworks,si52204
> +      - skyworks,si52208
> +      - skyworks,si52212
> +
> +  reg:
> +    const: 0x6a
> +
> +  '#clock-cells':
> +    const: 1
> +
> +  clocks:
> +    items:
> +      - description: XTal input clock
> +
> +  skyworks,out-amplitude-microvolt:
> +    enum: [ 600000, 650000, 700000, 750000, 800000, 850000 ]
> +    description: Output clock signal amplitude
> +
> +  skyworks,out-spread-spectrum:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [ 100000, 99750, 99500 ]
> +    description: Output clock down spread in pcm (1/1000 of percent)
> +
> +patternProperties:
> +  "^DIFF[0-11]$":
> +    type: object
> +    description:
> +      Description of one of the outputs (DIFF0..DIF11).

typo, DIFF11.
Does this regex actually work? I don't think it allows anything other
than DIFF0 and DIFF1, since it evaluates 0-1 as a range and 1 as another
range.

Cheers,
Conor.

pw-bot: changes-requested

> +
> +    properties:
> +      skyworks,slew-rate:
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        enum: [ 1900000, 2400000 ]
> +        description: Output clock slew rate select in V/ns
> +
> +    additionalProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - '#clock-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        clock-generator@6a {
> +            compatible = "skyworks,si52202";
> +            reg = <0x6a>;
> +            #clock-cells = <1>;
> +            clocks = <&ref25m>;
> +        };
> +    };
> +
> +...
> -- 
> 2.51.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]