Re: [PATCH 1/2] dt-bindings: clk: si522xx: Clock driver for Skyworks Si522xx I2C PCIe clock generators

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1181 bytes --]

On Tue, Oct 14, 2025 at 12:56:29PM +0200, Marek Vasut wrote:
> On 10/13/25 10:00 PM, Conor Dooley wrote:
> 
> Hello Conor,
> 
> > > diff --git a/Documentation/devicetree/bindings/clock/skyworks,si522xx.yaml b/Documentation/devicetree/bindings/clock/skyworks,si522xx.yaml
> > > new file mode 100644
> > > index 0000000000000..6ad26543f9d21
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/clock/skyworks,si522xx.yaml
> > 
> > Can you just pick one of the compatibles here?
> 
> I reused the existing pattern from previous binding document.
> 
> Documentation/devicetree/bindings/clock/skyworks,si521xx.yaml
> 
> I can use the 52202 for this binding document if that is preferable ?

yeah, I'd rather that, thanks.

> 
> ...
> 
> > > +patternProperties:
> > > +  "^DIFF[0-11]$":
> > > +    type: object
> > > +    description:
> > > +      Description of one of the outputs (DIFF0..DIF11).
> > 
> > typo, DIFF11.
> > Does this regex actually work? I don't think it allows anything other
> > than DIFF0 and DIFF1, since it evaluates 0-1 as a range and 1 as another
> > range.
> Fixed both, also fixed rs9 bindings and patch posted.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]