* [PATCH] arm64: dts: renesas: rzt2h-n2h-evk: Add VCC supply for EEPROM
@ 2025-10-14 15:33 Prabhakar
2025-10-15 15:35 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Prabhakar @ 2025-10-14 15:33 UTC (permalink / raw)
To: Geert Uytterhoeven, Magnus Damm, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-renesas-soc, devicetree, linux-kernel, Prabhakar, Biju Das,
Fabrizio Castro, Lad Prabhakar
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
The R1EX24016 EEPROM on the RZ/T2H-N2H Evaluation Kit is powered from
the 3.3V rail. Add the regulator phandle for the VCC supply to reflect
this in the device tree and avoid the fallback to the dummy regulator:
at24 0-0050: supply vcc not found, using dummy regulator
Fixes: 0176c9e82e10 ("arm64: dts: renesas: rzt2h-n2h-evk-common: Enable EEPROM on I2C0")
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi b/arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi
index ceecf0c30072..a19b2e289aad 100644
--- a/arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi
@@ -160,6 +160,7 @@ eeprom: eeprom@50 {
compatible = "renesas,r1ex24016", "atmel,24c16";
reg = <0x50>;
pagesize = <16>;
+ vcc-supply = <®_3p3v>;
};
};
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: renesas: rzt2h-n2h-evk: Add VCC supply for EEPROM
2025-10-14 15:33 [PATCH] arm64: dts: renesas: rzt2h-n2h-evk: Add VCC supply for EEPROM Prabhakar
@ 2025-10-15 15:35 ` Geert Uytterhoeven
2025-10-15 19:12 ` Lad, Prabhakar
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2025-10-15 15:35 UTC (permalink / raw)
To: Prabhakar
Cc: Magnus Damm, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-renesas-soc, devicetree, linux-kernel, Biju Das,
Fabrizio Castro, Lad Prabhakar, Bartosz Golaszewski, Linux I2C,
Liam Girdwood, Mark Brown
Hi Prabhakar,
CC at24, regulator
On Tue, 14 Oct 2025 at 17:33, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> The R1EX24016 EEPROM on the RZ/T2H-N2H Evaluation Kit is powered from
> the 3.3V rail. Add the regulator phandle for the VCC supply to reflect
> this in the device tree and avoid the fallback to the dummy regulator:
>
> at24 0-0050: supply vcc not found, using dummy regulator
>
> Fixes: 0176c9e82e10 ("arm64: dts: renesas: rzt2h-n2h-evk-common: Enable EEPROM on I2C0")
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi
> @@ -160,6 +160,7 @@ eeprom: eeprom@50 {
> compatible = "renesas,r1ex24016", "atmel,24c16";
> reg = <0x50>;
> pagesize = <16>;
> + vcc-supply = <®_3p3v>;
> };
> };
"vcc-supply" is not a required property, according to the DT bindings,
and I believe the 3.3V supply can be considered always-on (but see
below to encounter dragons).
I was always under the impression that these "supply not found, using
dummy regulator"-messages are just informational, and can be ignored,
but they are at the KERN_WARNING level.
So should we add real dummy supplies to DTS, or not?
Thanks!
P.S. Actually the 3.3V supply is controlled by an SLG7RN46899, which is
an "RZ/T2H Power Sequencer with IIC". From a quick glance at the
documentation, it is not clear to me what is the purpose of the
I2C interface, and whether it can be used to control the outputs
or not.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: renesas: rzt2h-n2h-evk: Add VCC supply for EEPROM
2025-10-15 15:35 ` Geert Uytterhoeven
@ 2025-10-15 19:12 ` Lad, Prabhakar
0 siblings, 0 replies; 3+ messages in thread
From: Lad, Prabhakar @ 2025-10-15 19:12 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Magnus Damm, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-renesas-soc, devicetree, linux-kernel, Biju Das,
Fabrizio Castro, Lad Prabhakar, Bartosz Golaszewski, Linux I2C,
Liam Girdwood, Mark Brown
Hi Geert,
On Wed, Oct 15, 2025 at 4:36 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> CC at24, regulator
>
> On Tue, 14 Oct 2025 at 17:33, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > The R1EX24016 EEPROM on the RZ/T2H-N2H Evaluation Kit is powered from
> > the 3.3V rail. Add the regulator phandle for the VCC supply to reflect
> > this in the device tree and avoid the fallback to the dummy regulator:
> >
> > at24 0-0050: supply vcc not found, using dummy regulator
> >
> > Fixes: 0176c9e82e10 ("arm64: dts: renesas: rzt2h-n2h-evk-common: Enable EEPROM on I2C0")
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/rzt2h-n2h-evk-common.dtsi
> > @@ -160,6 +160,7 @@ eeprom: eeprom@50 {
> > compatible = "renesas,r1ex24016", "atmel,24c16";
> > reg = <0x50>;
> > pagesize = <16>;
> > + vcc-supply = <®_3p3v>;
> > };
> > };
>
> "vcc-supply" is not a required property, according to the DT bindings,
> and I believe the 3.3V supply can be considered always-on (but see
> below to encounter dragons).
> I was always under the impression that these "supply not found, using
> dummy regulator"-messages are just informational, and can be ignored,
> but they are at the KERN_WARNING level.
> So should we add real dummy supplies to DTS, or not?
>
Agreed, I get your point. Let's drop this patch.
Cheers,
Prabhakar
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-15 19:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-14 15:33 [PATCH] arm64: dts: renesas: rzt2h-n2h-evk: Add VCC supply for EEPROM Prabhakar
2025-10-15 15:35 ` Geert Uytterhoeven
2025-10-15 19:12 ` Lad, Prabhakar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).