devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3] hwmon: (adt7410): Add ADT7422 support
@ 2025-10-15 14:52 Nuno Sá via B4 Relay
  2025-10-15 14:52 ` [PATCH 1/3] dt-bindings: trivial-devices: add ADT7410, ADT7420 and ADT7422 Nuno Sá via B4 Relay
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Nuno Sá via B4 Relay @ 2025-10-15 14:52 UTC (permalink / raw)
  To: devicetree, linux-hwmon
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Guenter Roeck,
	Cosmin Tanislav

The main goal is to add support for the ADT7422 digital temperature
sensor which is similar to the ones already supported by the adt7410
driver.

While on it add the devices to trivial-devices and a proper of_id
table.

---
Nuno Sá (3):
      dt-bindings: trivial-devices: add ADT7410, ADT7420 and ADT7422
      hwmon: (adt7410): Add OF match table
      hwmon: (adt7410): Support adt7422 chip

 Documentation/devicetree/bindings/trivial-devices.yaml |  6 ++++++
 drivers/hwmon/Kconfig                                  |  6 +++---
 drivers/hwmon/adt7410.c                                | 11 +++++++++++
 3 files changed, 20 insertions(+), 3 deletions(-)
---
base-commit: 4b5bf30f28d5f8401f2314dcf28b9d9d5ff092cd
change-id: 20251015-dev-add-adt7422-c84b9faa801a
--

Thanks!
- Nuno Sá



^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/3] dt-bindings: trivial-devices: add ADT7410, ADT7420 and ADT7422
  2025-10-15 14:52 [PATCH 0/3] hwmon: (adt7410): Add ADT7422 support Nuno Sá via B4 Relay
@ 2025-10-15 14:52 ` Nuno Sá via B4 Relay
  2025-10-16 16:20   ` Conor Dooley
  2025-10-16 20:45   ` Guenter Roeck
  2025-10-15 14:52 ` [PATCH 2/3] hwmon: (adt7410): Add OF match table Nuno Sá via B4 Relay
  2025-10-15 14:52 ` [PATCH 3/3] hwmon: (adt7410): Support adt7422 chip Nuno Sá via B4 Relay
  2 siblings, 2 replies; 8+ messages in thread
From: Nuno Sá via B4 Relay @ 2025-10-15 14:52 UTC (permalink / raw)
  To: devicetree, linux-hwmon
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Guenter Roeck

From: Nuno Sá <nuno.sa@analog.com>

Add Analog Devices high accuracy digital temperature sensors to trivial
devices.

Signed-off-by: Nuno Sá <nuno.sa@analog.com>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index deccb119493e..884a071a1f14 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -43,8 +43,14 @@ properties:
           - adi,ad5110
             # Temperature sensor with integrated fan control
           - adi,adm1027
+            # Analog Devices ADT7410 High Accuracy Digital Temperature Sensor
+          - adi,adt7410
             # Analog Devices ADT7411 Temperature Sensor and 8-channel ADC
           - adi,adt7411
+            # Analog Devices ADT7420 High Accuracy Digital Temperature Sensor
+          - adi,adt7420
+            # Analog Devices ADT7422 High Accuracy Digital Temperature Sensor
+          - adi,adt7422
             # Temperature sensor with integrated fan control
           - adi,adt7463
             # Temperature sensor with integrated fan control

-- 
2.51.0



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/3] hwmon: (adt7410): Add OF match table
  2025-10-15 14:52 [PATCH 0/3] hwmon: (adt7410): Add ADT7422 support Nuno Sá via B4 Relay
  2025-10-15 14:52 ` [PATCH 1/3] dt-bindings: trivial-devices: add ADT7410, ADT7420 and ADT7422 Nuno Sá via B4 Relay
@ 2025-10-15 14:52 ` Nuno Sá via B4 Relay
  2025-10-16 20:45   ` Guenter Roeck
  2025-10-15 14:52 ` [PATCH 3/3] hwmon: (adt7410): Support adt7422 chip Nuno Sá via B4 Relay
  2 siblings, 1 reply; 8+ messages in thread
From: Nuno Sá via B4 Relay @ 2025-10-15 14:52 UTC (permalink / raw)
  To: devicetree, linux-hwmon
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Guenter Roeck

From: Nuno Sá <nuno.sa@analog.com>

Add a struct of_device_id match table to the driver.

While at it, make sure to properly include mod_devicetable.h which is
also needed for struct i2c_device_id.

Signed-off-by: Nuno Sá <nuno.sa@analog.com>
---
 drivers/hwmon/adt7410.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/hwmon/adt7410.c b/drivers/hwmon/adt7410.c
index 3bf0e0a0882c..79952866a4db 100644
--- a/drivers/hwmon/adt7410.c
+++ b/drivers/hwmon/adt7410.c
@@ -7,6 +7,7 @@
  */
 
 #include <linux/module.h>
+#include <linux/mod_devicetable.h>
 #include <linux/init.h>
 #include <linux/i2c.h>
 #include <linux/regmap.h>
@@ -94,10 +95,18 @@ static const struct i2c_device_id adt7410_ids[] = {
 };
 MODULE_DEVICE_TABLE(i2c, adt7410_ids);
 
+static const struct of_device_id adt7410_of_match[] = {
+	{ .compatible = "adi,adt7410" },
+	{ .compatible = "adi,adt7420" },
+	{ }
+};
+MODULE_DEVICE_TABLE(of, adt7410_of_match);
+
 static struct i2c_driver adt7410_driver = {
 	.driver = {
 		.name	= "adt7410",
 		.pm	= pm_sleep_ptr(&adt7x10_dev_pm_ops),
+		.of_match_table = adt7410_of_match,
 	},
 	.probe		= adt7410_i2c_probe,
 	.id_table	= adt7410_ids,

-- 
2.51.0



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 3/3] hwmon: (adt7410): Support adt7422 chip
  2025-10-15 14:52 [PATCH 0/3] hwmon: (adt7410): Add ADT7422 support Nuno Sá via B4 Relay
  2025-10-15 14:52 ` [PATCH 1/3] dt-bindings: trivial-devices: add ADT7410, ADT7420 and ADT7422 Nuno Sá via B4 Relay
  2025-10-15 14:52 ` [PATCH 2/3] hwmon: (adt7410): Add OF match table Nuno Sá via B4 Relay
@ 2025-10-15 14:52 ` Nuno Sá via B4 Relay
  2025-10-16 20:46   ` Guenter Roeck
  2 siblings, 1 reply; 8+ messages in thread
From: Nuno Sá via B4 Relay @ 2025-10-15 14:52 UTC (permalink / raw)
  To: devicetree, linux-hwmon
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Guenter Roeck,
	Cosmin Tanislav

From: Nuno Sá <nuno.sa@analog.com>

Add support for the ADT7422 high accuracy digital temperature sensor. It's
identical to the other chips supported in the driver so we just need to
add it to the ID tables.

Co-developed-by: Cosmin Tanislav <demonsingur@gmail.com>
Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
Signed-off-by: Nuno Sá <nuno.sa@analog.com>
---
 drivers/hwmon/Kconfig   | 6 +++---
 drivers/hwmon/adt7410.c | 2 ++
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 2760feb9f83b..aa783be9b73d 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -175,7 +175,7 @@ config SENSORS_ADT7X10
 	select REGMAP
 	help
 	  This module contains common code shared by the ADT7310/ADT7320 and
-	  ADT7410/ADT7420 temperature monitoring chip drivers.
+	  ADT7410/ADT7420/ADT7422 temperature monitoring chip drivers.
 
 	  If built as a module, the module will be called adt7x10.
 
@@ -191,12 +191,12 @@ config SENSORS_ADT7310
 	  will be called adt7310.
 
 config SENSORS_ADT7410
-	tristate "Analog Devices ADT7410/ADT7420"
+	tristate "Analog Devices ADT7410/ADT7420/ADT7422"
 	depends on I2C
 	select SENSORS_ADT7X10
 	help
 	  If you say yes here you get support for the Analog Devices
-	  ADT7410 and ADT7420 temperature monitoring chips.
+	  ADT7410, ADT7420 and ADT7422 temperature monitoring chips.
 
 	  This driver can also be built as a module. If so, the module
 	  will be called adt7410.
diff --git a/drivers/hwmon/adt7410.c b/drivers/hwmon/adt7410.c
index 79952866a4db..73b196a78f3a 100644
--- a/drivers/hwmon/adt7410.c
+++ b/drivers/hwmon/adt7410.c
@@ -91,6 +91,7 @@ static int adt7410_i2c_probe(struct i2c_client *client)
 static const struct i2c_device_id adt7410_ids[] = {
 	{ "adt7410" },
 	{ "adt7420" },
+	{ "adt7422" },
 	{}
 };
 MODULE_DEVICE_TABLE(i2c, adt7410_ids);
@@ -98,6 +99,7 @@ MODULE_DEVICE_TABLE(i2c, adt7410_ids);
 static const struct of_device_id adt7410_of_match[] = {
 	{ .compatible = "adi,adt7410" },
 	{ .compatible = "adi,adt7420" },
+	{ .compatible = "adi,adt7422" },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, adt7410_of_match);

-- 
2.51.0



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/3] dt-bindings: trivial-devices: add ADT7410, ADT7420 and ADT7422
  2025-10-15 14:52 ` [PATCH 1/3] dt-bindings: trivial-devices: add ADT7410, ADT7420 and ADT7422 Nuno Sá via B4 Relay
@ 2025-10-16 16:20   ` Conor Dooley
  2025-10-16 20:45   ` Guenter Roeck
  1 sibling, 0 replies; 8+ messages in thread
From: Conor Dooley @ 2025-10-16 16:20 UTC (permalink / raw)
  To: nuno.sa
  Cc: devicetree, linux-hwmon, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Guenter Roeck

[-- Attachment #1: Type: text/plain, Size: 75 bytes --]

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/3] dt-bindings: trivial-devices: add ADT7410, ADT7420 and ADT7422
  2025-10-15 14:52 ` [PATCH 1/3] dt-bindings: trivial-devices: add ADT7410, ADT7420 and ADT7422 Nuno Sá via B4 Relay
  2025-10-16 16:20   ` Conor Dooley
@ 2025-10-16 20:45   ` Guenter Roeck
  1 sibling, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2025-10-16 20:45 UTC (permalink / raw)
  To: Nuno Sá
  Cc: devicetree, linux-hwmon, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley

On Wed, Oct 15, 2025 at 03:52:19PM +0100, Nuno Sá wrote:
> From: Nuno Sá <nuno.sa@analog.com>
> 
> Add Analog Devices high accuracy digital temperature sensors to trivial
> devices.
> 
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

Applied.

Thanks,
Guenter

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/3] hwmon: (adt7410): Add OF match table
  2025-10-15 14:52 ` [PATCH 2/3] hwmon: (adt7410): Add OF match table Nuno Sá via B4 Relay
@ 2025-10-16 20:45   ` Guenter Roeck
  0 siblings, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2025-10-16 20:45 UTC (permalink / raw)
  To: Nuno Sá
  Cc: devicetree, linux-hwmon, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley

On Wed, Oct 15, 2025 at 03:52:20PM +0100, Nuno Sá wrote:
> From: Nuno Sá <nuno.sa@analog.com>
> 
> Add a struct of_device_id match table to the driver.
> 
> While at it, make sure to properly include mod_devicetable.h which is
> also needed for struct i2c_device_id.
> 
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>

Applied.

Thanks,
Guenter

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 3/3] hwmon: (adt7410): Support adt7422 chip
  2025-10-15 14:52 ` [PATCH 3/3] hwmon: (adt7410): Support adt7422 chip Nuno Sá via B4 Relay
@ 2025-10-16 20:46   ` Guenter Roeck
  0 siblings, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2025-10-16 20:46 UTC (permalink / raw)
  To: Nuno Sá
  Cc: devicetree, linux-hwmon, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Cosmin Tanislav

On Wed, Oct 15, 2025 at 03:52:21PM +0100, Nuno Sá wrote:
> From: Nuno Sá <nuno.sa@analog.com>
> 
> Add support for the ADT7422 high accuracy digital temperature sensor. It's
> identical to the other chips supported in the driver so we just need to
> add it to the ID tables.
> 
> Co-developed-by: Cosmin Tanislav <demonsingur@gmail.com>
> Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>

Applied.

Thanks,
Guenter

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2025-10-16 20:46 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-15 14:52 [PATCH 0/3] hwmon: (adt7410): Add ADT7422 support Nuno Sá via B4 Relay
2025-10-15 14:52 ` [PATCH 1/3] dt-bindings: trivial-devices: add ADT7410, ADT7420 and ADT7422 Nuno Sá via B4 Relay
2025-10-16 16:20   ` Conor Dooley
2025-10-16 20:45   ` Guenter Roeck
2025-10-15 14:52 ` [PATCH 2/3] hwmon: (adt7410): Add OF match table Nuno Sá via B4 Relay
2025-10-16 20:45   ` Guenter Roeck
2025-10-15 14:52 ` [PATCH 3/3] hwmon: (adt7410): Support adt7422 chip Nuno Sá via B4 Relay
2025-10-16 20:46   ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).