* [PATCH v3 1/5] ASoC: codecs: va-macro: Rework version checking
2025-10-15 7:57 [PATCH v3 0/5] Add Audio Support for Kaanapali MTP Boards Prasad Kumpatla via B4 Relay
@ 2025-10-15 7:57 ` Prasad Kumpatla via B4 Relay
2025-10-15 7:57 ` [PATCH v3 2/5] ASoC: dt-bindings: qcom,sm8250: Add kaanapali sound card Prasad Kumpatla via B4 Relay
` (4 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: Prasad Kumpatla via B4 Relay @ 2025-10-15 7:57 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Rao Mandadapu
Cc: linux-sound, linux-arm-msm, linux-kernel, devicetree, Jingyi Wang,
Prasad Kumpatla, Konrad Dybcio
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Open-code some of the registers to make the checks anywhere near human-
readable. Error out if the version is unsupported or if the VA macro
isn't supposed to be present within this LPASS instance (since we can
check for that now).
Note that previously v2.0 and v2.1 assignments were swapped, but v2.1
does not even seem to exist (as opposed to v2.0.1) and there is no
difference in SW handling anyway.
[Prasad Kumpatla: fixed a spelling error and resolved a checkpatch
warning related to return value handling]
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
---
sound/soc/codecs/lpass-va-macro.c | 90 +++++++++++++++++++++++++++------------
1 file changed, 63 insertions(+), 27 deletions(-)
diff --git a/sound/soc/codecs/lpass-va-macro.c b/sound/soc/codecs/lpass-va-macro.c
index 2e1b77973a3e..eb4981255f2b 100644
--- a/sound/soc/codecs/lpass-va-macro.c
+++ b/sound/soc/codecs/lpass-va-macro.c
@@ -1,6 +1,7 @@
// SPDX-License-Identifier: GPL-2.0-only
// Copyright (c) 2018-2020, The Linux Foundation. All rights reserved.
+#include <linux/bitfield.h>
#include <linux/clk.h>
#include <linux/clk-provider.h>
#include <linux/init.h>
@@ -64,8 +65,15 @@
#define CDC_VA_TOP_CSR_I2S_CLK (0x00A8)
#define CDC_VA_TOP_CSR_I2S_RESET (0x00AC)
#define CDC_VA_TOP_CSR_CORE_ID_0 (0x00C0)
+ #define CORE_ID_0_REV_MAJ GENMASK(7, 0)
#define CDC_VA_TOP_CSR_CORE_ID_1 (0x00C4)
+#define CORE_ID_1_HAS_WSAMACRO BIT(3)
+#define CORE_ID_1_HAS_RXMACRO BIT(2)
+#define CORE_ID_1_HAS_TXMACRO BIT(1)
+#define CORE_ID_1_HAS_VAMACRO BIT(0)
#define CDC_VA_TOP_CSR_CORE_ID_2 (0x00C8)
+ #define CORE_ID_2_REV_MIN GENMASK(7, 4)
+ #define CORE_ID_2_REV_STEP GENMASK(3, 0)
#define CDC_VA_TOP_CSR_CORE_ID_3 (0x00CC)
#define CDC_VA_TOP_CSR_SWR_MIC_CTL0 (0x00D0)
#define CDC_VA_TOP_CSR_SWR_MIC_CTL1 (0x00D4)
@@ -1462,39 +1470,63 @@ static int va_macro_validate_dmic_sample_rate(u32 dmic_sample_rate,
return dmic_sample_rate;
}
-static void va_macro_set_lpass_codec_version(struct va_macro *va)
+static int va_macro_set_lpass_codec_version(struct va_macro *va)
{
- int core_id_0 = 0, core_id_1 = 0, core_id_2 = 0;
int version = LPASS_CODEC_VERSION_UNKNOWN;
+ u32 maj, min, step;
+ u32 val;
- regmap_read(va->regmap, CDC_VA_TOP_CSR_CORE_ID_0, &core_id_0);
- regmap_read(va->regmap, CDC_VA_TOP_CSR_CORE_ID_1, &core_id_1);
- regmap_read(va->regmap, CDC_VA_TOP_CSR_CORE_ID_2, &core_id_2);
+ regmap_read(va->regmap, CDC_VA_TOP_CSR_CORE_ID_0, &val);
+ maj = FIELD_GET(CORE_ID_0_REV_MAJ, val);
- if ((core_id_0 == 0x01) && (core_id_1 == 0x0F))
- version = LPASS_CODEC_VERSION_2_0;
- if ((core_id_0 == 0x02) && (core_id_1 == 0x0F) && core_id_2 == 0x01)
+ regmap_read(va->regmap, CDC_VA_TOP_CSR_CORE_ID_1, &val);
+ if (!FIELD_GET(CORE_ID_1_HAS_VAMACRO, val)) {
+ dev_err(va->dev, "This is not a VA macro instance\n");
+ return -ENODEV;
+ }
+
+ regmap_read(va->regmap, CDC_VA_TOP_CSR_CORE_ID_2, &val);
+ min = FIELD_GET(CORE_ID_2_REV_MIN, val);
+ step = FIELD_GET(CORE_ID_2_REV_STEP, val);
+
+ if (maj == 1) {
version = LPASS_CODEC_VERSION_2_0;
- if ((core_id_0 == 0x02) && (core_id_1 == 0x0E))
- version = LPASS_CODEC_VERSION_2_1;
- if ((core_id_0 == 0x02) && (core_id_1 == 0x0F) && (core_id_2 == 0x50 || core_id_2 == 0x51))
- version = LPASS_CODEC_VERSION_2_5;
- if ((core_id_0 == 0x02) && (core_id_1 == 0x0F) && (core_id_2 == 0x60 || core_id_2 == 0x61))
- version = LPASS_CODEC_VERSION_2_6;
- if ((core_id_0 == 0x02) && (core_id_1 == 0x0F) && (core_id_2 == 0x70 || core_id_2 == 0x71))
- version = LPASS_CODEC_VERSION_2_7;
- if ((core_id_0 == 0x02) && (core_id_1 == 0x0F) && (core_id_2 == 0x80 || core_id_2 == 0x81))
- version = LPASS_CODEC_VERSION_2_8;
- if ((core_id_0 == 0x02) && (core_id_1 == 0x0F) && (core_id_2 == 0x90 || core_id_2 == 0x91))
- version = LPASS_CODEC_VERSION_2_9;
-
- if (version == LPASS_CODEC_VERSION_UNKNOWN)
- dev_warn(va->dev, "Unknown Codec version, ID: %02x / %02x / %02x\n",
- core_id_0, core_id_1, core_id_2);
+ } else if (maj == 2) {
+ switch (min) {
+ case 0:
+ version = LPASS_CODEC_VERSION_2_0;
+ break;
+ case 5:
+ version = LPASS_CODEC_VERSION_2_5;
+ break;
+ case 6:
+ version = LPASS_CODEC_VERSION_2_6;
+ break;
+ case 7:
+ version = LPASS_CODEC_VERSION_2_7;
+ break;
+ case 8:
+ version = LPASS_CODEC_VERSION_2_8;
+ break;
+ case 9:
+ version = LPASS_CODEC_VERSION_2_9;
+ break;
+ default:
+ break;
+ }
+ }
+
+ if (version == LPASS_CODEC_VERSION_UNKNOWN) {
+ dev_err(va->dev, "VA Macro v%u.%u.%u is not supported\n",
+ maj, min, step);
+ return -EOPNOTSUPP;
+ }
lpass_macro_set_codec_version(version);
dev_dbg(va->dev, "LPASS Codec Version %s\n", lpass_macro_get_codec_version_string(version));
+
+ return 0;
}
static int va_macro_probe(struct platform_device *pdev)
@@ -1594,10 +1626,14 @@ static int va_macro_probe(struct platform_device *pdev)
* old version of codecs do not have a reliable way to determine the
* version from registers, get them from soc specific data
*/
- if (data->version)
+ if (data->version) {
lpass_macro_set_codec_version(data->version);
- else /* read version from register */
- va_macro_set_lpass_codec_version(va);
+ } else {
+ /* read version from register */
+ ret = va_macro_set_lpass_codec_version(va);
+ if (ret)
+ return ret;
+ }
if (va->has_swr_master) {
/* Set default CLK div to 1 */
--
2.34.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v3 2/5] ASoC: dt-bindings: qcom,sm8250: Add kaanapali sound card
2025-10-15 7:57 [PATCH v3 0/5] Add Audio Support for Kaanapali MTP Boards Prasad Kumpatla via B4 Relay
2025-10-15 7:57 ` [PATCH v3 1/5] ASoC: codecs: va-macro: Rework version checking Prasad Kumpatla via B4 Relay
@ 2025-10-15 7:57 ` Prasad Kumpatla via B4 Relay
2025-10-16 6:58 ` Krzysztof Kozlowski
2025-10-15 7:57 ` [PATCH v3 3/5] ASoC: qcom: sc8280xp: Add support for Kaanapali Prasad Kumpatla via B4 Relay
` (3 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Prasad Kumpatla via B4 Relay @ 2025-10-15 7:57 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Rao Mandadapu
Cc: linux-sound, linux-arm-msm, linux-kernel, devicetree, Jingyi Wang,
Prasad Kumpatla
From: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
Add bindings for Kaanapali sound card, which looks fully
compatible with existing SM8450.
Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
---
Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
index 8ac91625dce5..708bae805403 100644
--- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
@@ -23,6 +23,7 @@ properties:
- const: qcom,sdm845-sndcard
- items:
- enum:
+ - qcom,kaanapali-sndcard
- qcom,sm8550-sndcard
- qcom,sm8650-sndcard
- qcom,sm8750-sndcard
--
2.34.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH v3 2/5] ASoC: dt-bindings: qcom,sm8250: Add kaanapali sound card
2025-10-15 7:57 ` [PATCH v3 2/5] ASoC: dt-bindings: qcom,sm8250: Add kaanapali sound card Prasad Kumpatla via B4 Relay
@ 2025-10-16 6:58 ` Krzysztof Kozlowski
0 siblings, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2025-10-16 6:58 UTC (permalink / raw)
To: prasad.kumpatla, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Rao Mandadapu
Cc: linux-sound, linux-arm-msm, linux-kernel, devicetree, Jingyi Wang
On 15/10/2025 09:57, Prasad Kumpatla via B4 Relay wrote:
> From: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
>
> Add bindings for Kaanapali sound card, which looks fully
> compatible with existing SM8450.
>
> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
> ---
> Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v3 3/5] ASoC: qcom: sc8280xp: Add support for Kaanapali
2025-10-15 7:57 [PATCH v3 0/5] Add Audio Support for Kaanapali MTP Boards Prasad Kumpatla via B4 Relay
2025-10-15 7:57 ` [PATCH v3 1/5] ASoC: codecs: va-macro: Rework version checking Prasad Kumpatla via B4 Relay
2025-10-15 7:57 ` [PATCH v3 2/5] ASoC: dt-bindings: qcom,sm8250: Add kaanapali sound card Prasad Kumpatla via B4 Relay
@ 2025-10-15 7:57 ` Prasad Kumpatla via B4 Relay
2025-10-15 7:57 ` [PATCH v3 4/5] dt-bindings: soundwire: qcom: Add SoundWire v2.2.0 compatible Prasad Kumpatla via B4 Relay
` (2 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: Prasad Kumpatla via B4 Relay @ 2025-10-15 7:57 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Rao Mandadapu
Cc: linux-sound, linux-arm-msm, linux-kernel, devicetree, Jingyi Wang,
Prasad Kumpatla
From: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
Add compatible for sound card on Qualcomm Kaanapali boards.
Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
---
sound/soc/qcom/sc8280xp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c
index 78e327bc2f07..aea8c1daff32 100644
--- a/sound/soc/qcom/sc8280xp.c
+++ b/sound/soc/qcom/sc8280xp.c
@@ -191,6 +191,7 @@ static int sc8280xp_platform_probe(struct platform_device *pdev)
}
static const struct of_device_id snd_sc8280xp_dt_match[] = {
+ {.compatible = "qcom,kaanapali-sndcard", "kaanapali"},
{.compatible = "qcom,qcm6490-idp-sndcard", "qcm6490"},
{.compatible = "qcom,qcs6490-rb3gen2-sndcard", "qcs6490"},
{.compatible = "qcom,qcs8275-sndcard", "qcs8300"},
--
2.34.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v3 4/5] dt-bindings: soundwire: qcom: Add SoundWire v2.2.0 compatible
2025-10-15 7:57 [PATCH v3 0/5] Add Audio Support for Kaanapali MTP Boards Prasad Kumpatla via B4 Relay
` (2 preceding siblings ...)
2025-10-15 7:57 ` [PATCH v3 3/5] ASoC: qcom: sc8280xp: Add support for Kaanapali Prasad Kumpatla via B4 Relay
@ 2025-10-15 7:57 ` Prasad Kumpatla via B4 Relay
2025-10-16 6:58 ` Krzysztof Kozlowski
2025-10-15 7:57 ` [PATCH v3 5/5] ASoC: dt-bindings: qcom: Add Kaanapali LPASS macro codecs Prasad Kumpatla via B4 Relay
2025-10-17 12:12 ` (subset) [PATCH v3 0/5] Add Audio Support for Kaanapali MTP Boards Mark Brown
5 siblings, 1 reply; 13+ messages in thread
From: Prasad Kumpatla via B4 Relay @ 2025-10-15 7:57 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Rao Mandadapu
Cc: linux-sound, linux-arm-msm, linux-kernel, devicetree, Jingyi Wang,
Prasad Kumpatla
From: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
Add qcom,soundwire-v2.2.0 to the list of supported Qualcomm
SoundWire controller versions. This version falls back to
qcom,soundwire-v2.0.0 if not explicitly handled by the driver.
Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
---
Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml b/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml
index 95d947fda6a7..1c4b0bdbb044 100644
--- a/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml
+++ b/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml
@@ -26,6 +26,7 @@ properties:
- items:
- enum:
- qcom,soundwire-v2.1.0
+ - qcom,soundwire-v2.2.0
- const: qcom,soundwire-v2.0.0
reg:
--
2.34.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH v3 4/5] dt-bindings: soundwire: qcom: Add SoundWire v2.2.0 compatible
2025-10-15 7:57 ` [PATCH v3 4/5] dt-bindings: soundwire: qcom: Add SoundWire v2.2.0 compatible Prasad Kumpatla via B4 Relay
@ 2025-10-16 6:58 ` Krzysztof Kozlowski
0 siblings, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2025-10-16 6:58 UTC (permalink / raw)
To: prasad.kumpatla, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Rao Mandadapu
Cc: linux-sound, linux-arm-msm, linux-kernel, devicetree, Jingyi Wang
On 15/10/2025 09:57, Prasad Kumpatla via B4 Relay wrote:
> From: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
>
> Add qcom,soundwire-v2.2.0 to the list of supported Qualcomm
> SoundWire controller versions. This version falls back to
> qcom,soundwire-v2.0.0 if not explicitly handled by the driver.
>
> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v3 5/5] ASoC: dt-bindings: qcom: Add Kaanapali LPASS macro codecs
2025-10-15 7:57 [PATCH v3 0/5] Add Audio Support for Kaanapali MTP Boards Prasad Kumpatla via B4 Relay
` (3 preceding siblings ...)
2025-10-15 7:57 ` [PATCH v3 4/5] dt-bindings: soundwire: qcom: Add SoundWire v2.2.0 compatible Prasad Kumpatla via B4 Relay
@ 2025-10-15 7:57 ` Prasad Kumpatla via B4 Relay
2025-10-16 0:54 ` Dmitry Baryshkov
2025-10-16 6:59 ` Krzysztof Kozlowski
2025-10-17 12:12 ` (subset) [PATCH v3 0/5] Add Audio Support for Kaanapali MTP Boards Mark Brown
5 siblings, 2 replies; 13+ messages in thread
From: Prasad Kumpatla via B4 Relay @ 2025-10-15 7:57 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Rao Mandadapu
Cc: linux-sound, linux-arm-msm, linux-kernel, devicetree, Jingyi Wang,
Prasad Kumpatla
From: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
Add bindings for Qualcomm Kaanapali (LPASS) RX, TX, VA and WSA
macro codecs, which is likely compatible with earlier SM8550.
Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
---
Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml | 1 +
Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml | 1 +
Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml | 1 +
Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml | 1 +
4 files changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
index 92f95eb74b19..b869469a5848 100644
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
@@ -20,6 +20,7 @@ properties:
- qcom,sc8280xp-lpass-rx-macro
- items:
- enum:
+ - qcom,kaanapali-lpass-rx-macro
- qcom,sm8650-lpass-rx-macro
- qcom,sm8750-lpass-rx-macro
- qcom,x1e80100-lpass-rx-macro
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml
index 914798a89878..e5e65e226a02 100644
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml
@@ -21,6 +21,7 @@ properties:
- qcom,sc8280xp-lpass-tx-macro
- items:
- enum:
+ - qcom,kaanapali-lpass-tx-macro
- qcom,sm8650-lpass-tx-macro
- qcom,sm8750-lpass-tx-macro
- qcom,x1e80100-lpass-tx-macro
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
index 1c0d78af3c05..5b450f227b70 100644
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
@@ -21,6 +21,7 @@ properties:
- items:
- enum:
- qcom,glymur-lpass-va-macro
+ - qcom,kaanapali-lpass-va-macro
- qcom,sm8650-lpass-va-macro
- qcom,sm8750-lpass-va-macro
- qcom,x1e80100-lpass-va-macro
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
index b6f5ba5d1320..d5f22b5cf021 100644
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
@@ -21,6 +21,7 @@ properties:
- items:
- enum:
- qcom,glymur-lpass-wsa-macro
+ - qcom,kaanapali-lpass-wsa-macro
- qcom,sm8650-lpass-wsa-macro
- qcom,sm8750-lpass-wsa-macro
- qcom,x1e80100-lpass-wsa-macro
--
2.34.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH v3 5/5] ASoC: dt-bindings: qcom: Add Kaanapali LPASS macro codecs
2025-10-15 7:57 ` [PATCH v3 5/5] ASoC: dt-bindings: qcom: Add Kaanapali LPASS macro codecs Prasad Kumpatla via B4 Relay
@ 2025-10-16 0:54 ` Dmitry Baryshkov
2025-10-16 6:59 ` Krzysztof Kozlowski
2025-10-16 6:59 ` Krzysztof Kozlowski
1 sibling, 1 reply; 13+ messages in thread
From: Dmitry Baryshkov @ 2025-10-16 0:54 UTC (permalink / raw)
To: prasad.kumpatla
Cc: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Rao Mandadapu, linux-sound, linux-arm-msm, linux-kernel,
devicetree, Jingyi Wang
On Wed, Oct 15, 2025 at 01:27:19PM +0530, Prasad Kumpatla via B4 Relay wrote:
> From: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
>
> Add bindings for Qualcomm Kaanapali (LPASS) RX, TX, VA and WSA
> macro codecs, which is likely compatible with earlier SM8550.
>
> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
What does this serie of SoBs mean?
> ---
> Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml | 1 +
> Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml | 1 +
> Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml | 1 +
> Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml | 1 +
> 4 files changed, 4 insertions(+)
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3 5/5] ASoC: dt-bindings: qcom: Add Kaanapali LPASS macro codecs
2025-10-16 0:54 ` Dmitry Baryshkov
@ 2025-10-16 6:59 ` Krzysztof Kozlowski
2025-10-17 13:17 ` Dmitry Baryshkov
0 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2025-10-16 6:59 UTC (permalink / raw)
To: Dmitry Baryshkov, prasad.kumpatla
Cc: Srinivas Kandagatla, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Rao Mandadapu, linux-sound, linux-arm-msm, linux-kernel,
devicetree, Jingyi Wang
On 16/10/2025 02:54, Dmitry Baryshkov wrote:
> On Wed, Oct 15, 2025 at 01:27:19PM +0530, Prasad Kumpatla via B4 Relay wrote:
>> From: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
>>
>> Add bindings for Qualcomm Kaanapali (LPASS) RX, TX, VA and WSA
>> macro codecs, which is likely compatible with earlier SM8550.
>>
>> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
>> Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
>
> What does this serie of SoBs mean?
To me looks fine (see v1 and v2). Prasad wrote the patch, Jingyi changed
it and sent. Then Prasad took that changed patch and changed more.
Perfectly fine.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3 5/5] ASoC: dt-bindings: qcom: Add Kaanapali LPASS macro codecs
2025-10-16 6:59 ` Krzysztof Kozlowski
@ 2025-10-17 13:17 ` Dmitry Baryshkov
0 siblings, 0 replies; 13+ messages in thread
From: Dmitry Baryshkov @ 2025-10-17 13:17 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: prasad.kumpatla, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Rao Mandadapu, linux-sound, linux-arm-msm,
linux-kernel, devicetree, Jingyi Wang
On Thu, Oct 16, 2025 at 08:59:29AM +0200, Krzysztof Kozlowski wrote:
> On 16/10/2025 02:54, Dmitry Baryshkov wrote:
> > On Wed, Oct 15, 2025 at 01:27:19PM +0530, Prasad Kumpatla via B4 Relay wrote:
> >> From: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
> >>
> >> Add bindings for Qualcomm Kaanapali (LPASS) RX, TX, VA and WSA
> >> macro codecs, which is likely compatible with earlier SM8550.
> >>
> >> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> >> Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
> >
> > What does this serie of SoBs mean?
>
> To me looks fine (see v1 and v2). Prasad wrote the patch, Jingyi changed
> it and sent. Then Prasad took that changed patch and changed more.
> Perfectly fine.
ok
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v3 5/5] ASoC: dt-bindings: qcom: Add Kaanapali LPASS macro codecs
2025-10-15 7:57 ` [PATCH v3 5/5] ASoC: dt-bindings: qcom: Add Kaanapali LPASS macro codecs Prasad Kumpatla via B4 Relay
2025-10-16 0:54 ` Dmitry Baryshkov
@ 2025-10-16 6:59 ` Krzysztof Kozlowski
1 sibling, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2025-10-16 6:59 UTC (permalink / raw)
To: prasad.kumpatla, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Rao Mandadapu
Cc: linux-sound, linux-arm-msm, linux-kernel, devicetree, Jingyi Wang
On 15/10/2025 09:57, Prasad Kumpatla via B4 Relay wrote:
> From: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
>
> Add bindings for Qualcomm Kaanapali (LPASS) RX, TX, VA and WSA
> macro codecs, which is likely compatible with earlier SM8550.
>
> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: (subset) [PATCH v3 0/5] Add Audio Support for Kaanapali MTP Boards
2025-10-15 7:57 [PATCH v3 0/5] Add Audio Support for Kaanapali MTP Boards Prasad Kumpatla via B4 Relay
` (4 preceding siblings ...)
2025-10-15 7:57 ` [PATCH v3 5/5] ASoC: dt-bindings: qcom: Add Kaanapali LPASS macro codecs Prasad Kumpatla via B4 Relay
@ 2025-10-17 12:12 ` Mark Brown
5 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2025-10-17 12:12 UTC (permalink / raw)
To: Srinivas Kandagatla, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Rao Mandadapu,
Prasad Kumpatla
Cc: linux-sound, linux-arm-msm, linux-kernel, devicetree, Jingyi Wang,
Konrad Dybcio
On Wed, 15 Oct 2025 13:27:14 +0530, Prasad Kumpatla wrote:
> Add audio support for Kaanapali MTP boards. Introduces supporting
> dependencies required to enable audio functionality on MTP platforms.
> These changes have been validated on Kaanapali MTP hardware.
>
> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/5] ASoC: codecs: va-macro: Rework version checking
commit: 281c97376cfcfc8cef4f5ed5dd961a1b39f5a25e
[2/5] ASoC: dt-bindings: qcom,sm8250: Add kaanapali sound card
commit: 367ca0688e4218e51c3d4dfdf3ef5657a62cf88d
[3/5] ASoC: qcom: sc8280xp: Add support for Kaanapali
commit: 4673dbe9837e3eb2fecdd12f0953006c31636aac
[5/5] ASoC: dt-bindings: qcom: Add Kaanapali LPASS macro codecs
commit: 15afe57a874eaf104bfbb61ec598fa31627f7b19
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 13+ messages in thread