devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Herve Codina <herve.codina@bootlin.com>
To: Andrew Lunn <andrew@lunn.ch>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Andi Shyti <andi.shyti@kernel.org>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Peter Rosin <peda@axentia.se>, Arnd Bergmann <arnd@arndb.de>,
	Herve Codina <herve.codina@bootlin.com>,
	Saravana Kannan <saravanak@google.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	Richard Fitzgerald <rf@opensource.cirrus.com>,
	David Rhodes <david.rhodes@cirrus.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Mark Brown <broonie@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Daniel Scally <djrscally@gmail.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Len Brown <lenb@kernel.org>, Davidlohr Bueso <dave@stgolabs.net>,
	Jonathan Cameron <jonathan.cameron@huawei.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Alison Schofield <alison.schofield@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Ira Weiny <ira.weiny@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Wolfram Sang <wsa@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-clk@vger.kernel.org, linux-i2c@vger.kernel.org,
	linux-pci@vger.kernel.org, linux-sound@vger.kernel.org,
	patches@opensource.cirrus.com, linux-gpio@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-spi@vger.kernel.org,
	linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org,
	Allan Nielsen <allan.nielsen@microchip.com>,
	Horatiu Vultur <horatiu.vultur@microchip.com>,
	Steen Hegelund <steen.hegelund@microchip.com>,
	Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: [PATCH v4 14/29] PCI: of: Set fwnode device of newly created PCI device nodes
Date: Wed, 15 Oct 2025 09:14:01 +0200	[thread overview]
Message-ID: <20251015071420.1173068-15-herve.codina@bootlin.com> (raw)
In-Reply-To: <20251015071420.1173068-1-herve.codina@bootlin.com>

Device-tree node can be created when CONFIG_PCI_DYNAMIC_OF_NODES. Those
node are created and filled based on PCI core information but the
fwnode device field is not set.

When later an overlay is applied, this confuses fw_devlink. Indeed,
without any device attached to the node, fw_devlink considers that this
node will never become a device. When this node is pointed as a
supplier, devlink looks at its ancestors in order to find a node with a
device that could be used as the supplier.

In the PCI use case, this leads to links that wrongly use the PCI root
bridge device as the supplier instead of the expected PCI device.

Setting the fwnode device to the device of the PCI device allows devlink
to use this device as a supplier and so, correct links are created.

Signed-off-by: Herve Codina <herve.codina@bootlin.com>
---
 drivers/pci/of.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/pci/of.c b/drivers/pci/of.c
index 95baa29d4c2d..bbbab115d47f 100644
--- a/drivers/pci/of.c
+++ b/drivers/pci/of.c
@@ -709,6 +709,13 @@ void of_pci_make_dev_node(struct pci_dev *pdev)
 	if (ret)
 		goto out_free_node;
 
+	/*
+	 * Set the fwnode device in order to have fw_devlink creating links
+	 * pointing to this PCI device instead of walking up to the PCI host
+	 * bridge.
+	 */
+	fw_devlink_set_device(&np->fwnode, &pdev->dev);
+
 	ret = of_changeset_apply(cset);
 	if (ret)
 		goto out_free_node;
-- 
2.51.0


  parent reply	other threads:[~2025-10-15  7:19 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-15  7:13 [PATCH v4 00/29] lan966x pci device: Add support for SFPs Herve Codina
2025-10-15  7:13 ` [PATCH v4 01/29] Revert "treewide: Fix probing of devices in DT overlays" Herve Codina
2025-10-15  7:13 ` [PATCH v4 02/29] driver core: Rename get_dev_from_fwnode() wrapper to get_device_from_fwnode() Herve Codina
2025-10-21 10:36   ` Ulf Hansson
2025-10-15  7:13 ` [PATCH v4 03/29] of: dynamic: Fix overlayed devices not probing because of fw_devlink Herve Codina
2025-10-15  7:13 ` [PATCH v4 04/29] driver core: Avoid warning when removing a device while its supplier is unbinding Herve Codina
2025-10-15  7:13 ` [PATCH v4 05/29] dt-bindings: bus: Add simple-platform-bus Herve Codina
2025-10-30 14:14   ` Rob Herring
2025-10-31 15:20     ` Herve Codina
2025-10-31  8:52   ` Geert Uytterhoeven
2025-10-31 14:29     ` Herve Codina
2025-10-15  7:13 ` [PATCH v4 06/29] bus: Introduce simple-platorm-bus Herve Codina
2025-10-21 14:07   ` Andy Shevchenko
2025-10-15  7:13 ` [PATCH v4 07/29] misc: lan966x_pci: Use simple-platform-bus Herve Codina
2025-10-15  7:13 ` [PATCH v4 08/29] driver core: fw_devlink: Introduce fw_devlink_set_device() Herve Codina
2025-10-21 10:36   ` Ulf Hansson
2025-10-21 14:08   ` Andy Shevchenko
2025-10-15  7:13 ` [PATCH v4 09/29] drivers: core: Use fw_devlink_set_device() Herve Codina
2025-10-21 10:36   ` Ulf Hansson
2025-10-15  7:13 ` [PATCH v4 10/29] pinctrl: cs42l43: " Herve Codina
2025-10-15  7:13 ` [PATCH v4 11/29] cxl/test: Use device_set_node() Herve Codina
2025-10-15  7:13 ` [PATCH v4 12/29] cxl/test: Use fw_devlink_set_device() Herve Codina
2025-10-15  7:14 ` [PATCH v4 13/29] PCI: of: " Herve Codina
2025-10-15  7:14 ` Herve Codina [this message]
2025-10-15  7:14 ` [PATCH v4 15/29] PCI: of: Remove fwnode_dev_initialized() call for a PCI root bridge node Herve Codina
2025-10-15  7:14 ` [PATCH v4 16/29] i2c: core: Introduce i2c_get_adapter_physdev() Herve Codina
2025-10-15  7:14 ` [PATCH v4 17/29] i2c: mux: Set adapter physical device Herve Codina
2025-10-30 13:35   ` Andi Shyti
2025-10-15  7:14 ` [PATCH v4 18/29] i2c: mux: Create missing devlink between mux and " Herve Codina
2025-10-30 15:23   ` Andi Shyti
2025-10-30 17:45     ` Andy Shevchenko
2025-10-15  7:14 ` [PATCH v4 19/29] of: property: Allow fw_devlink device-tree on x86 Herve Codina
2025-10-30 14:46   ` Rob Herring
2025-10-15  7:14 ` [PATCH v4 20/29] clk: lan966x: Add MCHP_LAN966X_PCI dependency Herve Codina
2025-10-15  7:14 ` [PATCH v4 21/29] i2c: busses: at91: " Herve Codina
2025-10-15  7:14 ` [PATCH v4 22/29] misc: lan966x_pci: Fix dtso nodes ordering Herve Codina
2025-10-15  7:14 ` [PATCH v4 23/29] misc: lan966x_pci: Split dtso in dtsi/dtso Herve Codina
2025-10-15  7:14 ` [PATCH v4 24/29] misc: lan966x_pci: Rename lan966x_pci.dtso to lan966x_evb_lan9662_nic.dtso Herve Codina
2025-10-15  7:14 ` [PATCH v4 25/29] PCI: Add Microchip LAN9662 PCI Device ID Herve Codina
2025-10-15  7:14 ` [PATCH v4 26/29] misc: lan966x_pci: Introduce board specific data Herve Codina
2025-10-15  7:14 ` [PATCH v4 27/29] misc: lan966x_pci: Add dtsi/dtso nodes in order to support SFPs Herve Codina
2025-10-15  7:14 ` [PATCH v4 28/29] misc: lan966x_pci: Sort the drivers list in Kconfig help Herve Codina
2025-10-15  7:14 ` [PATCH v4 29/29] misc: lan966x_pci: Add drivers needed to support SFPs " Herve Codina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251015071420.1173068-15-herve.codina@bootlin.com \
    --to=herve.codina@bootlin.com \
    --cc=alison.schofield@intel.com \
    --cc=allan.nielsen@microchip.com \
    --cc=andi.shyti@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=conor+dt@kernel.org \
    --cc=dakr@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=david.rhodes@cirrus.com \
    --cc=devicetree@vger.kernel.org \
    --cc=djrscally@gmail.com \
    --cc=festevam@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=horatiu.vultur@microchip.com \
    --cc=imx@lists.linux.dev \
    --cc=ira.weiny@intel.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=lenb@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=mturquette@baylibre.com \
    --cc=patches@opensource.cirrus.com \
    --cc=peda@axentia.se \
    --cc=rafael@kernel.org \
    --cc=rf@opensource.cirrus.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sakari.ailus@linux.intel.com \
    --cc=saravanak@google.com \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=steen.hegelund@microchip.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=ulf.hansson@linaro.org \
    --cc=vishal.l.verma@intel.com \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).