From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4AE82FFDE4; Wed, 15 Oct 2025 06:21:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760509287; cv=none; b=JF9HBzTCnwnaNSQFQt7CnC9pa92uyfDfqqCGRRRIvtpWhgO8hVN8XNw+yNZPtiN0MI1POTLXkP1lydWObdQ8HKyYlodkObBWddiw7+B3S6QQd6w4KEAlMBsozZ97HQC+YUIUgdyJBcERAoN6jgZ0rgEPhsKhfLhmvRistayU2UM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760509287; c=relaxed/simple; bh=DicfJkkTsiij02qIVcRFiHOl97sEIvQS0/C6n7EV7gQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IUnycfbf6pamI/ttAHo9LEhB0JO9KD3FDYbILyaZj658evq5V3CY7D15s510AtbR4ZsN9JRTX4HmSXg1eeTF8RwM238HCeBUgZEJsiBs+ZhFlJrD8/rK+12B3oTtorLkNvGE4CobIxgUpNjH9vWwBNG+7SBo/9XLvNwrZ9hDk0M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=rePeuf/p; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="rePeuf/p" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id E0CF7C09FA6; Wed, 15 Oct 2025 06:20:59 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id E634B606F9; Wed, 15 Oct 2025 06:21:18 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 59C5E102F22AA; Wed, 15 Oct 2025 08:21:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1760509277; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=fJomQq7OE3Maiesqwu9sZQP6LCVhewRSpZqk8JBWs78=; b=rePeuf/p5urYuOHJ7Zc4gd2xvA5MR+RBRetK2TQGnYv3G82ImEFQQA1N5ktsEIh14SeIAx 9bH4ohXrP0yiFVsi1Qu/mYchA8TM5xuzpWGlDOGT3254tDREKHcnCfElp6LIG2GhcdidM/ 8TN5kaMTuf3zdluXLUBnzuAYmqEHEMkUQ20/z7ZgBv8/qHHoTfW9IwradnDyX8jG5pS3m1 6FKTWFrbIlhVRROiQg6Y54Tc4YLJrMGHCN0V6wLTskGZgeAWH504REFi/k43+yOMVWkaSt wgerD0FWa8rOO2YZWyDQtXlqOxoMSpy++EaoxBNiR/sg9QRdOFQsPXA5/83H5A== Date: Wed, 15 Oct 2025 08:21:03 +0200 From: Herve Codina To: Linus Walleij , Wolfram Sang Cc: Thomas Gleixner , Hoan Tran , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Saravana Kannan , Serge Semin , Phil Edworthy , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Pascal Eberhard , Miquel Raynal , Thomas Petazzoni Subject: Re: [PATCH v4 7/8] soc: renesas: Add support for Renesas RZ/N1 GPIO Interrupt Multiplexer Message-ID: <20251015082103.7907e019@bootlin.com> In-Reply-To: References: <20250922152640.154092-1-herve.codina@bootlin.com> <20250922152640.154092-8-herve.codina@bootlin.com> <20251001174205.71a08017@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Hi Linus, Wolfram, On Tue, 14 Oct 2025 22:13:50 +0200 Linus Walleij wrote: > On Tue, Oct 14, 2025 at 4:30 PM Wolfram Sang > wrote: > > > Because the HW design kind of suggests it, I'd think. The GPIO > > controller is a standard Synopsis one ("snps,dw-apb-gpio") without any > > extras. The GPIOMUX (which is extra) is according to the docs part of > > the system controller with a dedicated set of registers. Luckily, > > self-contained and not mangled with other functionality. > > Aha I see. If this is so tightly coupled with the Synopsis > designware GPIO then it should be mentioned in the commit > I guess. Also: > > config RZN1_IRQMUX > bool "Renesas RZ/N1 GPIO IRQ multiplexer support" if COMPILE_TEST > > + depends on GPIO_DWAPB || COMPILE_TEST > > ? > > I understand that it is convenient to make this a separate driver. > > I'm not sure it is the right thing to do, but it's no a hill I want to > die on so if everyone else thinks I'm wrong, I can just shut up > about it, it's not like this driver is a big obstacle or anything. > > Yours, > Linus Walleij I don't think the mux should depends on GPIO_DWAPB (the gpio controller). Also, several gpio controller instances are connected to the mux. The 96 GPIOs connected to the mux come from 3 GPIO controller instances (32 gpios per instance). I don't think it makes sense to have the mux handled by the gpio driver itself. It could have make sense if 3 muxes were available, one per gpio controller but this is not the case. As Wolfram said, the mux is an hardware component really outside of the GPIO controller IPs. Best regards, Hervé