devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Albert Yang <yangzh0906@thundersoft.com>
To: robh@kernel.org
Cc: adrian.hunter@intel.com, arnd@arndb.de, bst-upstream@bstai.top,
	catalin.marinas@arm.com, conor+dt@kernel.org,
	devicetree@vger.kernel.org, gordon.ge@bst.ai, krzk+dt@kernel.org,
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
	ulf.hansson@linaro.org, will@kernel.org,
	yangzh0906@thundersoft.com
Subject: Re: [PATCH 4/9] dt-bindings: mmc: add binding for BST DWCMSHC SDHCI controller
Date: Wed, 15 Oct 2025 17:31:02 +0800	[thread overview]
Message-ID: <20251015093102.1554881-1-yangzh0906@thundersoft.com> (raw)
In-Reply-To: <175862238966.2427901.366123788055800395.robh@kernel.org>

Hi Rob,

Thank you for running the dt_binding_check on this patch!

On Tue, Sep 23, 2025 at 05:13:09AM -0500, Rob Herring (Arm) wrote:
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/mmc/bst,dwcmshc-sdhci.example.dtb: /example-0/bus/mmc@22200000: failed to match any schema with compatible: ['bst,c1200-dwcmshc-sdhci']

This error occurred because in v4, while I updated the dts compatible property 
definition to "bst,c1200-sdhci" (as requested in review), I failed to update 
the compatible string in the example node accordingly. The example was still 
using the old "bst,c1200-dwcmshc-sdhci", causing the schema validation to fail.

I have now corrected the example's compatible string from:
    compatible = "bst,c1200-dwcmshc-sdhci";
to:
    compatible = "bst,c1200-sdhci";

Following your suggestion, I've upgraded dtschema:
    pip3 install dtschema --upgrade

and verified the fix with:
    make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/bst,c1200-sdhci.yaml

The binding now passes all validation checks. This fix will be included in v5.

Best regards,
Albert Yang

  reply	other threads:[~2025-10-15  9:46 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-23  6:10 [PATCH 0/9] arm64: introduce Black Sesame Technologies C1200 SoC and CDCU1.0 board Albert Yang
2025-09-23  6:10 ` [PATCH 1/9] dt-bindings: vendor-prefixes: Add Black Sesame Technologies Co., Ltd Albert Yang
2025-09-23  6:10 ` [PATCH 2/9] dt-bindings: arm: add Black Sesame Technologies (bst) SoC Albert Yang
2025-09-23  6:10 ` [PATCH 3/9] arm64: Kconfig: add ARCH_BST for Black Sesame Technologies SoCs Albert Yang
2025-09-23  6:10 ` [PATCH 4/9] dt-bindings: mmc: add binding for BST DWCMSHC SDHCI controller Albert Yang
2025-09-23 10:13   ` Rob Herring (Arm)
2025-10-15  9:31     ` Albert Yang [this message]
2025-09-23 13:56   ` Rob Herring
2025-09-26  3:06     ` [PATCH v4 4/9] dt-bindings: mmc: Add Black Sesame Technologies DWCMSHC SDHCI Albert Yang
2025-10-15  9:09     ` [PATCH 4/9] dt-bindings: mmc: add binding for BST DWCMSHC SDHCI controller Albert Yang
2025-09-23  6:10 ` [PATCH 5/9] mmc: sdhci: add Black Sesame Technologies BST C1200 controller driver Albert Yang
2025-09-29 13:25   ` Adrian Hunter
2025-09-23  6:10 ` [PATCH 6/9] mmc: sdhci: allow drivers to pre-allocate bounce buffer Albert Yang
2025-09-29 13:26   ` Adrian Hunter
2025-09-23  6:10 ` [PATCH 7/9] arm64: dts: bst: add support for Black Sesame Technologies C1200 CDCU1.0 board Albert Yang
2025-09-23  6:10 ` [PATCH 8/9] arm64: defconfig: enable BST platform and SDHCI controller support Albert Yang
2025-09-23  6:10 ` [PATCH 9/9] MAINTAINERS: add Black Sesame Technologies (BST) ARM SoC support Albert Yang
2025-09-29 13:29   ` Adrian Hunter
2025-10-15  7:30     ` Albert Yang
2025-09-25  7:06 ` [PATCH 0/9] arm64: introduce Black Sesame Technologies C1200 SoC and CDCU1.0 board Arnd Bergmann
2025-09-25  9:03   ` Albert Yang
2025-09-25 12:11     ` Albert Yang
2025-09-25 13:34       ` Ulf Hansson
2025-09-25 13:38         ` Arnd Bergmann
2025-09-26  1:48           ` Albert Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251015093102.1554881-1-yangzh0906@thundersoft.com \
    --to=yangzh0906@thundersoft.com \
    --cc=adrian.hunter@intel.com \
    --cc=arnd@arndb.de \
    --cc=bst-upstream@bstai.top \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gordon.ge@bst.ai \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).