devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] arm64: dts: qcom: talos-evk: Add ADV7535 DSI-to-HDMI bridge
@ 2025-10-15 12:28 Sudarshan Shetty
  2025-10-15 13:04 ` Dmitry Baryshkov
  2025-10-17 13:20 ` Krzysztof Kozlowski
  0 siblings, 2 replies; 7+ messages in thread
From: Sudarshan Shetty @ 2025-10-15 12:28 UTC (permalink / raw)
  To: andersson
  Cc: konradybcio, robh, krzk+dt, conor+dt, linux-arm-msm, devicetree,
	linux-kernel, tessolveupstream

Hook up the ADV7535 DSI-to-HDMI bridge on the QCS615 Talos EVK board.
This provides HDMI output through the external DSI-to-HDMI converter.

Signed-off-by: Sudarshan Shetty <tessolveupstream@gmail.com>
---
 arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 21 ++++++
 arch/arm64/boot/dts/qcom/talos-evk.dts      | 76 +++++++++++++++++++++
 2 files changed, 97 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi b/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
index 55ec8034103d..b58cae02c9cb 100644
--- a/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
+++ b/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
@@ -244,6 +244,27 @@ eeprom@5f {
 	};
 };
 
+&mdss {
+	status = "okay";
+};
+
+&mdss_dsi0 {
+	vdda-supply = <&vreg_l11a>;
+
+	status = "okay";
+};
+
+&mdss_dsi0_out {
+	remote-endpoint = <&adv7535_in>;
+	data-lanes = <0 1 2 3>;
+};
+
+&mdss_dsi0_phy {
+	vdds-supply = <&vreg_l5a>;
+
+	status = "okay";
+};
+
 &pcie {
 	perst-gpios = <&tlmm 101 GPIO_ACTIVE_LOW>;
 	wake-gpios = <&tlmm 100 GPIO_ACTIVE_HIGH>;
diff --git a/arch/arm64/boot/dts/qcom/talos-evk.dts b/arch/arm64/boot/dts/qcom/talos-evk.dts
index 25057f4f6a91..f7e8be3667d1 100644
--- a/arch/arm64/boot/dts/qcom/talos-evk.dts
+++ b/arch/arm64/boot/dts/qcom/talos-evk.dts
@@ -14,6 +14,82 @@ / {
 	aliases {
 		mmc1 = &sdhc_2;
 	};
+
+	hdmi-out {
+		compatible = "hdmi-connector";
+		type = "d";
+
+		port {
+			hdmi_con_out: endpoint {
+				remote-endpoint = <&adv7535_out>;
+			};
+		};
+	};
+
+	vreg_v1p2_out: regulator-v1p2-out {
+		compatible = "regulator-fixed";
+		regulator-name = "vreg-v1p2-out";
+		regulator-min-microvolt = <1200000>;
+		regulator-max-microvolt = <1200000>;
+		regulator-boot-on;
+		regulator-always-on;
+	};
+
+	vreg_v1p8_out: regulator-v1p8-out {
+		compatible = "regulator-fixed";
+		regulator-name = "vreg-v1p8-out";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		regulator-boot-on;
+		regulator-always-on;
+	};
+
+	vreg_v3p3_out: regulator-v3p3-out {
+		compatible = "regulator-fixed";
+		regulator-name = "vreg-v3p3-out";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-boot-on;
+		regulator-always-on;
+	};
+};
+
+&i2c1 {
+	clock-frequency = <400000>;
+
+	status = "okay";
+
+	adv7535: adv7535@3d {
+		compatible = "adi,adv7535";
+		reg = <0x3d>;
+		avdd-supply = <&vreg_v1p8_out>;
+		dvdd-supply = <&vreg_v1p8_out>;
+		pvdd-supply = <&vreg_v1p8_out>;
+		a2vdd-supply = <&vreg_v1p8_out>;
+		v3p3-supply = <&vreg_v3p3_out>;
+		v1p2-supply = <&vreg_v1p2_out>;
+		interrupts-extended = <&tlmm 26 IRQ_TYPE_LEVEL_LOW>;
+		adi,dsi-lanes = <4>;
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+				adv7535_in: endpoint {
+					remote-endpoint = <&mdss_dsi0_out>;
+				};
+			};
+
+			port@1 {
+				reg = <1>;
+				adv7535_out: endpoint {
+					remote-endpoint = <&hdmi_con_out>;
+				};
+			};
+		};
+	};
 };
 
 &pon_pwrkey {
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v1] arm64: dts: qcom: talos-evk: Add ADV7535 DSI-to-HDMI bridge
  2025-10-15 12:28 [PATCH v1] arm64: dts: qcom: talos-evk: Add ADV7535 DSI-to-HDMI bridge Sudarshan Shetty
@ 2025-10-15 13:04 ` Dmitry Baryshkov
  2025-10-16  8:54   ` Tessolve Upstream
  2025-10-17 13:20 ` Krzysztof Kozlowski
  1 sibling, 1 reply; 7+ messages in thread
From: Dmitry Baryshkov @ 2025-10-15 13:04 UTC (permalink / raw)
  To: Sudarshan Shetty
  Cc: andersson, konradybcio, robh, krzk+dt, conor+dt, linux-arm-msm,
	devicetree, linux-kernel

On Wed, Oct 15, 2025 at 05:58:08PM +0530, Sudarshan Shetty wrote:
> Hook up the ADV7535 DSI-to-HDMI bridge on the QCS615 Talos EVK board.
> This provides HDMI output through the external DSI-to-HDMI converter.
> 
> Signed-off-by: Sudarshan Shetty <tessolveupstream@gmail.com>
> ---
>  arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 21 ++++++
>  arch/arm64/boot/dts/qcom/talos-evk.dts      | 76 +++++++++++++++++++++
>  2 files changed, 97 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi b/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
> index 55ec8034103d..b58cae02c9cb 100644
> --- a/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
> +++ b/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
> @@ -244,6 +244,27 @@ eeprom@5f {
>  	};
>  };
>  
> +&mdss {
> +	status = "okay";
> +};
> +
> +&mdss_dsi0 {
> +	vdda-supply = <&vreg_l11a>;
> +
> +	status = "okay";
> +};
> +
> +&mdss_dsi0_out {
> +	remote-endpoint = <&adv7535_in>;
> +	data-lanes = <0 1 2 3>;
> +};
> +
> +&mdss_dsi0_phy {
> +	vdds-supply = <&vreg_l5a>;
> +
> +	status = "okay";
> +};
> +
>  &pcie {
>  	perst-gpios = <&tlmm 101 GPIO_ACTIVE_LOW>;
>  	wake-gpios = <&tlmm 100 GPIO_ACTIVE_HIGH>;
> diff --git a/arch/arm64/boot/dts/qcom/talos-evk.dts b/arch/arm64/boot/dts/qcom/talos-evk.dts
> index 25057f4f6a91..f7e8be3667d1 100644
> --- a/arch/arm64/boot/dts/qcom/talos-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/talos-evk.dts
> @@ -14,6 +14,82 @@ / {
>  	aliases {
>  		mmc1 = &sdhc_2;
>  	};
> +
> +	hdmi-out {
> +		compatible = "hdmi-connector";
> +		type = "d";
> +
> +		port {
> +			hdmi_con_out: endpoint {
> +				remote-endpoint = <&adv7535_out>;
> +			};
> +		};
> +	};
> +
> +	vreg_v1p2_out: regulator-v1p2-out {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vreg-v1p2-out";
> +		regulator-min-microvolt = <1200000>;
> +		regulator-max-microvolt = <1200000>;
> +		regulator-boot-on;
> +		regulator-always-on;
> +	};
> +
> +	vreg_v1p8_out: regulator-v1p8-out {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vreg-v1p8-out";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +		regulator-boot-on;
> +		regulator-always-on;
> +	};
> +
> +	vreg_v3p3_out: regulator-v3p3-out {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vreg-v3p3-out";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		regulator-boot-on;
> +		regulator-always-on;
> +	};

Please describe the power grid. Are these regulators being fed by
nothing and generating energy from the thin air?

> +};
> +
> +&i2c1 {
> +	clock-frequency = <400000>;
> +
> +	status = "okay";
> +
> +	adv7535: adv7535@3d {
> +		compatible = "adi,adv7535";
> +		reg = <0x3d>;
> +		avdd-supply = <&vreg_v1p8_out>;
> +		dvdd-supply = <&vreg_v1p8_out>;
> +		pvdd-supply = <&vreg_v1p8_out>;
> +		a2vdd-supply = <&vreg_v1p8_out>;
> +		v3p3-supply = <&vreg_v3p3_out>;
> +		v1p2-supply = <&vreg_v1p2_out>;

I think this is not correct. Please consult your schematics isntead of
adding dummy regulators.


-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v1] arm64: dts: qcom: talos-evk: Add ADV7535 DSI-to-HDMI bridge
  2025-10-15 13:04 ` Dmitry Baryshkov
@ 2025-10-16  8:54   ` Tessolve Upstream
  2025-10-17 12:52     ` Dmitry Baryshkov
  0 siblings, 1 reply; 7+ messages in thread
From: Tessolve Upstream @ 2025-10-16  8:54 UTC (permalink / raw)
  To: Dmitry Baryshkov
  Cc: andersson, konradybcio, robh, krzk+dt, conor+dt, linux-arm-msm,
	devicetree, linux-kernel



On 15/10/25 18:34, Dmitry Baryshkov wrote:
> On Wed, Oct 15, 2025 at 05:58:08PM +0530, Sudarshan Shetty wrote:
>> Hook up the ADV7535 DSI-to-HDMI bridge on the QCS615 Talos EVK board.
>> This provides HDMI output through the external DSI-to-HDMI converter.
>>
>> Signed-off-by: Sudarshan Shetty <tessolveupstream@gmail.com>
>> ---
>>  arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 21 ++++++
>>  arch/arm64/boot/dts/qcom/talos-evk.dts      | 76 +++++++++++++++++++++
>>  2 files changed, 97 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi b/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
>> index 55ec8034103d..b58cae02c9cb 100644
>> --- a/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
>> @@ -244,6 +244,27 @@ eeprom@5f {
>>  	};
>>  };
>>  
>> +&mdss {
>> +	status = "okay";
>> +};
>> +
>> +&mdss_dsi0 {
>> +	vdda-supply = <&vreg_l11a>;
>> +
>> +	status = "okay";
>> +};
>> +
>> +&mdss_dsi0_out {
>> +	remote-endpoint = <&adv7535_in>;
>> +	data-lanes = <0 1 2 3>;
>> +};
>> +
>> +&mdss_dsi0_phy {
>> +	vdds-supply = <&vreg_l5a>;
>> +
>> +	status = "okay";
>> +};
>> +
>>  &pcie {
>>  	perst-gpios = <&tlmm 101 GPIO_ACTIVE_LOW>;
>>  	wake-gpios = <&tlmm 100 GPIO_ACTIVE_HIGH>;
>> diff --git a/arch/arm64/boot/dts/qcom/talos-evk.dts b/arch/arm64/boot/dts/qcom/talos-evk.dts
>> index 25057f4f6a91..f7e8be3667d1 100644
>> --- a/arch/arm64/boot/dts/qcom/talos-evk.dts
>> +++ b/arch/arm64/boot/dts/qcom/talos-evk.dts
>> @@ -14,6 +14,82 @@ / {
>>  	aliases {
>>  		mmc1 = &sdhc_2;
>>  	};
>> +
>> +	hdmi-out {
>> +		compatible = "hdmi-connector";
>> +		type = "d";
>> +
>> +		port {
>> +			hdmi_con_out: endpoint {
>> +				remote-endpoint = <&adv7535_out>;
>> +			};
>> +		};
>> +	};
>> +
>> +	vreg_v1p2_out: regulator-v1p2-out {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "vreg-v1p2-out";
>> +		regulator-min-microvolt = <1200000>;
>> +		regulator-max-microvolt = <1200000>;
>> +		regulator-boot-on;
>> +		regulator-always-on;
>> +	};
>> +
>> +	vreg_v1p8_out: regulator-v1p8-out {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "vreg-v1p8-out";
>> +		regulator-min-microvolt = <1800000>;
>> +		regulator-max-microvolt = <1800000>;
>> +		regulator-boot-on;
>> +		regulator-always-on;
>> +	};
>> +
>> +	vreg_v3p3_out: regulator-v3p3-out {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "vreg-v3p3-out";
>> +		regulator-min-microvolt = <3300000>;
>> +		regulator-max-microvolt = <3300000>;
>> +		regulator-boot-on;
>> +		regulator-always-on;
>> +	};
> 
> Please describe the power grid. Are these regulators being fed by
> nothing and generating energy from the thin air?

Thanks for the feedback.
You are right — in the previous patch, the regulators appeared
to have no source, which was incorrect.

To clarify the hardware design:
The 3.3 V and 1.8 V supplies to the HDMI controller are not coming 
from the PMIC. They are generated on the carrier board as follows:

20 V (USBC_VBUS_IN) → 5 V rail (V5P0_OUT)
→ 3.3 V buck regulator (RAA211250) and 1.8 V LDO (TPS7A9101).

The 5 V rail (V5P0_OUT) acts as the input supply for both regulators.
Both regulators are always on.

example:
v5p0_out: regulator-v5p0-out {
    compatible = "regulator-fixed";
    regulator-name = "v5p0_out";
    regulator-min-microvolt = <5000000>;
    regulator-max-microvolt = <5000000>;
    regulator-always-on;
    regulator-boot-on;
};

v3p3_out: regulator-v3p3-out {
    compatible = "regulator-fixed";
    regulator-name = "v3p3_out";
    regulator-min-microvolt = <3300000>;
    regulator-max-microvolt = <3300000>;
    vin-supply = <&v5p0_out>;
    regulator-always-on;
    regulator-boot-on;
};

v1p8_out: regulator-v1p8-out {
    compatible = "regulator-fixed";
    regulator-name = "v1p8_out";
    regulator-min-microvolt = <1800000>;
    regulator-max-microvolt = <1800000>;
    vin-supply = <&v5p0_out>;
    regulator-always-on;
    regulator-boot-on;
};

These reflect the actual power grid of the board.
The 20 V input is not modeled since it’s a raw external
supply and not managed by Linux.

Please let me know if this structure looks acceptable,
Thanks again for the review and guidance!
> 
>> +};
>> +
>> +&i2c1 {
>> +	clock-frequency = <400000>;
>> +
>> +	status = "okay";
>> +
>> +	adv7535: adv7535@3d {
>> +		compatible = "adi,adv7535";
>> +		reg = <0x3d>;
>> +		avdd-supply = <&vreg_v1p8_out>;
>> +		dvdd-supply = <&vreg_v1p8_out>;
>> +		pvdd-supply = <&vreg_v1p8_out>;
>> +		a2vdd-supply = <&vreg_v1p8_out>;
>> +		v3p3-supply = <&vreg_v3p3_out>;
>> +		v1p2-supply = <&vreg_v1p2_out>;
> 
> I think this is not correct. Please consult your schematics isntead of
> adding dummy regulators.

Will take care in v2 patch.
> 
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v1] arm64: dts: qcom: talos-evk: Add ADV7535 DSI-to-HDMI bridge
  2025-10-16  8:54   ` Tessolve Upstream
@ 2025-10-17 12:52     ` Dmitry Baryshkov
  2025-10-21  7:01       ` Tessolve Upstream
  0 siblings, 1 reply; 7+ messages in thread
From: Dmitry Baryshkov @ 2025-10-17 12:52 UTC (permalink / raw)
  To: Tessolve Upstream
  Cc: andersson, konradybcio, robh, krzk+dt, conor+dt, linux-arm-msm,
	devicetree, linux-kernel

On Thu, Oct 16, 2025 at 02:24:40PM +0530, Tessolve Upstream wrote:
> 
> 
> On 15/10/25 18:34, Dmitry Baryshkov wrote:
> > On Wed, Oct 15, 2025 at 05:58:08PM +0530, Sudarshan Shetty wrote:
> >> Hook up the ADV7535 DSI-to-HDMI bridge on the QCS615 Talos EVK board.
> >> This provides HDMI output through the external DSI-to-HDMI converter.
> >>
> >> Signed-off-by: Sudarshan Shetty <tessolveupstream@gmail.com>
> >> ---
> >>  arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 21 ++++++
> >>  arch/arm64/boot/dts/qcom/talos-evk.dts      | 76 +++++++++++++++++++++
> >>  2 files changed, 97 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi b/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
> >> index 55ec8034103d..b58cae02c9cb 100644
> >> --- a/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
> >> +++ b/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
> >> @@ -244,6 +244,27 @@ eeprom@5f {
> >>  	};
> >>  };
> >>  
> >> +&mdss {
> >> +	status = "okay";
> >> +};
> >> +
> >> +&mdss_dsi0 {
> >> +	vdda-supply = <&vreg_l11a>;
> >> +
> >> +	status = "okay";
> >> +};
> >> +
> >> +&mdss_dsi0_out {
> >> +	remote-endpoint = <&adv7535_in>;
> >> +	data-lanes = <0 1 2 3>;
> >> +};
> >> +
> >> +&mdss_dsi0_phy {
> >> +	vdds-supply = <&vreg_l5a>;
> >> +
> >> +	status = "okay";
> >> +};
> >> +
> >>  &pcie {
> >>  	perst-gpios = <&tlmm 101 GPIO_ACTIVE_LOW>;
> >>  	wake-gpios = <&tlmm 100 GPIO_ACTIVE_HIGH>;
> >> diff --git a/arch/arm64/boot/dts/qcom/talos-evk.dts b/arch/arm64/boot/dts/qcom/talos-evk.dts
> >> index 25057f4f6a91..f7e8be3667d1 100644
> >> --- a/arch/arm64/boot/dts/qcom/talos-evk.dts
> >> +++ b/arch/arm64/boot/dts/qcom/talos-evk.dts
> >> @@ -14,6 +14,82 @@ / {
> >>  	aliases {
> >>  		mmc1 = &sdhc_2;
> >>  	};
> >> +
> >> +	hdmi-out {
> >> +		compatible = "hdmi-connector";
> >> +		type = "d";
> >> +
> >> +		port {
> >> +			hdmi_con_out: endpoint {
> >> +				remote-endpoint = <&adv7535_out>;
> >> +			};
> >> +		};
> >> +	};
> >> +
> >> +	vreg_v1p2_out: regulator-v1p2-out {
> >> +		compatible = "regulator-fixed";
> >> +		regulator-name = "vreg-v1p2-out";
> >> +		regulator-min-microvolt = <1200000>;
> >> +		regulator-max-microvolt = <1200000>;
> >> +		regulator-boot-on;
> >> +		regulator-always-on;
> >> +	};
> >> +
> >> +	vreg_v1p8_out: regulator-v1p8-out {
> >> +		compatible = "regulator-fixed";
> >> +		regulator-name = "vreg-v1p8-out";
> >> +		regulator-min-microvolt = <1800000>;
> >> +		regulator-max-microvolt = <1800000>;
> >> +		regulator-boot-on;
> >> +		regulator-always-on;
> >> +	};
> >> +
> >> +	vreg_v3p3_out: regulator-v3p3-out {
> >> +		compatible = "regulator-fixed";
> >> +		regulator-name = "vreg-v3p3-out";
> >> +		regulator-min-microvolt = <3300000>;
> >> +		regulator-max-microvolt = <3300000>;
> >> +		regulator-boot-on;
> >> +		regulator-always-on;
> >> +	};
> > 
> > Please describe the power grid. Are these regulators being fed by
> > nothing and generating energy from the thin air?
> 
> Thanks for the feedback.
> You are right — in the previous patch, the regulators appeared
> to have no source, which was incorrect.
> 
> To clarify the hardware design:
> The 3.3 V and 1.8 V supplies to the HDMI controller are not coming 
> from the PMIC. They are generated on the carrier board as follows:
> 
> 20 V (USBC_VBUS_IN) → 5 V rail (V5P0_OUT)
> → 3.3 V buck regulator (RAA211250) and 1.8 V LDO (TPS7A9101).
> 
> The 5 V rail (V5P0_OUT) acts as the input supply for both regulators.
> Both regulators are always on.
> 
> example:
> v5p0_out: regulator-v5p0-out {
>     compatible = "regulator-fixed";
>     regulator-name = "v5p0_out";
>     regulator-min-microvolt = <5000000>;
>     regulator-max-microvolt = <5000000>;
>     regulator-always-on;
>     regulator-boot-on;
> };
> 
> v3p3_out: regulator-v3p3-out {
>     compatible = "regulator-fixed";
>     regulator-name = "v3p3_out";
>     regulator-min-microvolt = <3300000>;
>     regulator-max-microvolt = <3300000>;
>     vin-supply = <&v5p0_out>;
>     regulator-always-on;
>     regulator-boot-on;
> };
> 
> v1p8_out: regulator-v1p8-out {
>     compatible = "regulator-fixed";
>     regulator-name = "v1p8_out";
>     regulator-min-microvolt = <1800000>;
>     regulator-max-microvolt = <1800000>;
>     vin-supply = <&v5p0_out>;
>     regulator-always-on;
>     regulator-boot-on;
> };
> 
> These reflect the actual power grid of the board.
> The 20 V input is not modeled since it’s a raw external
> supply and not managed by Linux.
> 
> Please let me know if this structure looks acceptable,
> Thanks again for the review and guidance!

I think this is perfectly fine, especially if you add the "powered by
system 20V rail" comment to the 5V regulator.

> > 
> >> +};
> >> +
> >> +&i2c1 {
> >> +	clock-frequency = <400000>;
> >> +
> >> +	status = "okay";
> >> +
> >> +	adv7535: adv7535@3d {
> >> +		compatible = "adi,adv7535";
> >> +		reg = <0x3d>;
> >> +		avdd-supply = <&vreg_v1p8_out>;
> >> +		dvdd-supply = <&vreg_v1p8_out>;
> >> +		pvdd-supply = <&vreg_v1p8_out>;
> >> +		a2vdd-supply = <&vreg_v1p8_out>;
> >> +		v3p3-supply = <&vreg_v3p3_out>;
> >> +		v1p2-supply = <&vreg_v1p2_out>;
> > 
> > I think this is not correct. Please consult your schematics isntead of
> > adding dummy regulators.
> 
> Will take care in v2 patch.
> > 
> > 
> 

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v1] arm64: dts: qcom: talos-evk: Add ADV7535 DSI-to-HDMI bridge
  2025-10-15 12:28 [PATCH v1] arm64: dts: qcom: talos-evk: Add ADV7535 DSI-to-HDMI bridge Sudarshan Shetty
  2025-10-15 13:04 ` Dmitry Baryshkov
@ 2025-10-17 13:20 ` Krzysztof Kozlowski
  2025-10-21  7:03   ` Tessolve Upstream
  1 sibling, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2025-10-17 13:20 UTC (permalink / raw)
  To: Sudarshan Shetty, andersson
  Cc: konradybcio, robh, krzk+dt, conor+dt, linux-arm-msm, devicetree,
	linux-kernel

On 15/10/2025 14:28, Sudarshan Shetty wrote:
> Hook up the ADV7535 DSI-to-HDMI bridge on the QCS615 Talos EVK board.
> This provides HDMI output through the external DSI-to-HDMI converter.
> 
> Signed-off-by: Sudarshan Shetty <tessolveupstream@gmail.com>
> ---
>  arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 21 ++++++
>  arch/arm64/boot/dts/qcom/talos-evk.dts      | 76 +++++++++++++++++++++
>  2 files changed, 97 insertions(+)

There is no such file.

You need to squash it into original posting.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v1] arm64: dts: qcom: talos-evk: Add ADV7535 DSI-to-HDMI bridge
  2025-10-17 12:52     ` Dmitry Baryshkov
@ 2025-10-21  7:01       ` Tessolve Upstream
  0 siblings, 0 replies; 7+ messages in thread
From: Tessolve Upstream @ 2025-10-21  7:01 UTC (permalink / raw)
  To: Dmitry Baryshkov
  Cc: andersson, konradybcio, robh, krzk+dt, conor+dt, linux-arm-msm,
	devicetree, linux-kernel



On 17/10/25 18:22, Dmitry Baryshkov wrote:
> On Thu, Oct 16, 2025 at 02:24:40PM +0530, Tessolve Upstream wrote:
>>
>>
>> On 15/10/25 18:34, Dmitry Baryshkov wrote:
>>> On Wed, Oct 15, 2025 at 05:58:08PM +0530, Sudarshan Shetty wrote:
>>>> Hook up the ADV7535 DSI-to-HDMI bridge on the QCS615 Talos EVK board.
>>>> This provides HDMI output through the external DSI-to-HDMI converter.
>>>>
>>>> Signed-off-by: Sudarshan Shetty <tessolveupstream@gmail.com>
>>>> ---
>>>>  arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 21 ++++++
>>>>  arch/arm64/boot/dts/qcom/talos-evk.dts      | 76 +++++++++++++++++++++
>>>>  2 files changed, 97 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi b/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
>>>> index 55ec8034103d..b58cae02c9cb 100644
>>>> --- a/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
>>>> @@ -244,6 +244,27 @@ eeprom@5f {
>>>>  	};
>>>>  };
>>>>  
>>>> +&mdss {
>>>> +	status = "okay";
>>>> +};
>>>> +
>>>> +&mdss_dsi0 {
>>>> +	vdda-supply = <&vreg_l11a>;
>>>> +
>>>> +	status = "okay";
>>>> +};
>>>> +
>>>> +&mdss_dsi0_out {
>>>> +	remote-endpoint = <&adv7535_in>;
>>>> +	data-lanes = <0 1 2 3>;
>>>> +};
>>>> +
>>>> +&mdss_dsi0_phy {
>>>> +	vdds-supply = <&vreg_l5a>;
>>>> +
>>>> +	status = "okay";
>>>> +};
>>>> +
>>>>  &pcie {
>>>>  	perst-gpios = <&tlmm 101 GPIO_ACTIVE_LOW>;
>>>>  	wake-gpios = <&tlmm 100 GPIO_ACTIVE_HIGH>;
>>>> diff --git a/arch/arm64/boot/dts/qcom/talos-evk.dts b/arch/arm64/boot/dts/qcom/talos-evk.dts
>>>> index 25057f4f6a91..f7e8be3667d1 100644
>>>> --- a/arch/arm64/boot/dts/qcom/talos-evk.dts
>>>> +++ b/arch/arm64/boot/dts/qcom/talos-evk.dts
>>>> @@ -14,6 +14,82 @@ / {
>>>>  	aliases {
>>>>  		mmc1 = &sdhc_2;
>>>>  	};
>>>> +
>>>> +	hdmi-out {
>>>> +		compatible = "hdmi-connector";
>>>> +		type = "d";
>>>> +
>>>> +		port {
>>>> +			hdmi_con_out: endpoint {
>>>> +				remote-endpoint = <&adv7535_out>;
>>>> +			};
>>>> +		};
>>>> +	};
>>>> +
>>>> +	vreg_v1p2_out: regulator-v1p2-out {
>>>> +		compatible = "regulator-fixed";
>>>> +		regulator-name = "vreg-v1p2-out";
>>>> +		regulator-min-microvolt = <1200000>;
>>>> +		regulator-max-microvolt = <1200000>;
>>>> +		regulator-boot-on;
>>>> +		regulator-always-on;
>>>> +	};
>>>> +
>>>> +	vreg_v1p8_out: regulator-v1p8-out {
>>>> +		compatible = "regulator-fixed";
>>>> +		regulator-name = "vreg-v1p8-out";
>>>> +		regulator-min-microvolt = <1800000>;
>>>> +		regulator-max-microvolt = <1800000>;
>>>> +		regulator-boot-on;
>>>> +		regulator-always-on;
>>>> +	};
>>>> +
>>>> +	vreg_v3p3_out: regulator-v3p3-out {
>>>> +		compatible = "regulator-fixed";
>>>> +		regulator-name = "vreg-v3p3-out";
>>>> +		regulator-min-microvolt = <3300000>;
>>>> +		regulator-max-microvolt = <3300000>;
>>>> +		regulator-boot-on;
>>>> +		regulator-always-on;
>>>> +	};
>>>
>>> Please describe the power grid. Are these regulators being fed by
>>> nothing and generating energy from the thin air?
>>
>> Thanks for the feedback.
>> You are right — in the previous patch, the regulators appeared
>> to have no source, which was incorrect.
>>
>> To clarify the hardware design:
>> The 3.3 V and 1.8 V supplies to the HDMI controller are not coming 
>> from the PMIC. They are generated on the carrier board as follows:
>>
>> 20 V (USBC_VBUS_IN) → 5 V rail (V5P0_OUT)
>> → 3.3 V buck regulator (RAA211250) and 1.8 V LDO (TPS7A9101).
>>
>> The 5 V rail (V5P0_OUT) acts as the input supply for both regulators.
>> Both regulators are always on.
>>
>> example:
>> v5p0_out: regulator-v5p0-out {
>>     compatible = "regulator-fixed";
>>     regulator-name = "v5p0_out";
>>     regulator-min-microvolt = <5000000>;
>>     regulator-max-microvolt = <5000000>;
>>     regulator-always-on;
>>     regulator-boot-on;
>> };
>>
>> v3p3_out: regulator-v3p3-out {
>>     compatible = "regulator-fixed";
>>     regulator-name = "v3p3_out";
>>     regulator-min-microvolt = <3300000>;
>>     regulator-max-microvolt = <3300000>;
>>     vin-supply = <&v5p0_out>;
>>     regulator-always-on;
>>     regulator-boot-on;
>> };
>>
>> v1p8_out: regulator-v1p8-out {
>>     compatible = "regulator-fixed";
>>     regulator-name = "v1p8_out";
>>     regulator-min-microvolt = <1800000>;
>>     regulator-max-microvolt = <1800000>;
>>     vin-supply = <&v5p0_out>;
>>     regulator-always-on;
>>     regulator-boot-on;
>> };
>>
>> These reflect the actual power grid of the board.
>> The 20 V input is not modeled since it’s a raw external
>> supply and not managed by Linux.
>>
>> Please let me know if this structure looks acceptable,
>> Thanks again for the review and guidance!
> 
> I think this is perfectly fine, especially if you add the "powered by
> system 20V rail" comment to the 5V regulator.

Thanks!
Will update in v2 patch.
> 
>>>
>>>> +};
>>>> +
>>>> +&i2c1 {
>>>> +	clock-frequency = <400000>;
>>>> +
>>>> +	status = "okay";
>>>> +
>>>> +	adv7535: adv7535@3d {
>>>> +		compatible = "adi,adv7535";
>>>> +		reg = <0x3d>;
>>>> +		avdd-supply = <&vreg_v1p8_out>;
>>>> +		dvdd-supply = <&vreg_v1p8_out>;
>>>> +		pvdd-supply = <&vreg_v1p8_out>;
>>>> +		a2vdd-supply = <&vreg_v1p8_out>;
>>>> +		v3p3-supply = <&vreg_v3p3_out>;
>>>> +		v1p2-supply = <&vreg_v1p2_out>;
>>>
>>> I think this is not correct. Please consult your schematics isntead of
>>> adding dummy regulators.
>>
>> Will take care in v2 patch.
>>>
>>>
>>
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v1] arm64: dts: qcom: talos-evk: Add ADV7535 DSI-to-HDMI bridge
  2025-10-17 13:20 ` Krzysztof Kozlowski
@ 2025-10-21  7:03   ` Tessolve Upstream
  0 siblings, 0 replies; 7+ messages in thread
From: Tessolve Upstream @ 2025-10-21  7:03 UTC (permalink / raw)
  To: Krzysztof Kozlowski, andersson
  Cc: konradybcio, robh, krzk+dt, conor+dt, linux-arm-msm, devicetree,
	linux-kernel



On 17/10/25 18:50, Krzysztof Kozlowski wrote:
> On 15/10/2025 14:28, Sudarshan Shetty wrote:
>> Hook up the ADV7535 DSI-to-HDMI bridge on the QCS615 Talos EVK board.
>> This provides HDMI output through the external DSI-to-HDMI converter.
>>
>> Signed-off-by: Sudarshan Shetty <tessolveupstream@gmail.com>
>> ---
>>  arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 21 ++++++
>>  arch/arm64/boot/dts/qcom/talos-evk.dts      | 76 +++++++++++++++++++++
>>  2 files changed, 97 insertions(+)
> 
> There is no such file.
> 
> You need to squash it into original posting.

Thanks for the review and guidance!
Understood! I will squash it into original post.
> 
> Best regards,
> Krzysztof


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2025-10-21  7:03 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-15 12:28 [PATCH v1] arm64: dts: qcom: talos-evk: Add ADV7535 DSI-to-HDMI bridge Sudarshan Shetty
2025-10-15 13:04 ` Dmitry Baryshkov
2025-10-16  8:54   ` Tessolve Upstream
2025-10-17 12:52     ` Dmitry Baryshkov
2025-10-21  7:01       ` Tessolve Upstream
2025-10-17 13:20 ` Krzysztof Kozlowski
2025-10-21  7:03   ` Tessolve Upstream

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).