From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 907EC3451B0; Thu, 16 Oct 2025 15:33:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760628786; cv=none; b=YEqiVWeDvidrtvGB2Q4ooku1stXE6Vw2jBpK9/QeHbhOiB5k4gxGLchqwuq4pLmu42zVNR9qH3BEoIk1v/4Fcb9ZLf4pcTQDpMyTB0Z3YQ+f04VA+kTbXNno1lBcaz70+Ate4q9lBNhwrBdNuVs5Q5APvL5JHedcSTjsZPWfsSk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760628786; c=relaxed/simple; bh=9w4ldvS/v8mZpOqFATR9RwRH4Sxmge8BG7AOwopND6I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IDsEuf6JMv9ZVetk9xpAnlZB/aUR2OnBBxS2fuBc0Wh6ihVntCfIz5EtkB/hPGoOXDhSr30AMk7G7NMmAAMm3MDEWJnjLu+mBbyiLM9NaBPRT6bni1552qEqyyBYS4x7IATStw1LkA6xmZsOJ3TUxb4yH5QG5tc9Lj+AlF6Q2i8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p9RZ2NKD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p9RZ2NKD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3CF41C2BC86; Thu, 16 Oct 2025 15:33:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760628786; bh=9w4ldvS/v8mZpOqFATR9RwRH4Sxmge8BG7AOwopND6I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p9RZ2NKDfomcr6Rsn1H0XWisSH8fUmiWTbcVtNBnEpNN9VRa42AGUzhrb1rClvZP7 NQDvxrdL0EJXxGaS+4O2UcaApQ7G/YrFg+BVFBKeDjakZFOx6V4ghTSNXKNTRVCISn hmH2W60TBUQTg0U0Hpw18I7HMr07wUWh4eHjCxJbvt9Ve8qt9l0erJqe6fheoOI01e VlqXyEbQDqkvmlgh3XWCwOT6d/UPo/MkHBc0nyvQjGaUJaILFvwNJ/E8zJeuOKEu73 i0d9M5pmsTcaVIasZr5FvXEfErNHzH8zfp3CAHjOJLgaMPaAzuxfH9XxG07GabFZbP PJ/POwOHJNwYw== Date: Thu, 16 Oct 2025 16:33:00 +0100 From: Conor Dooley To: Langyan Ye Cc: neil.armstrong@linaro.org, jessica.zhang@oss.qualcomm.com, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, dianders@chromium.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] dt-bindings: display: panel: Add Tianma TL121BVMS07-00 panel Message-ID: <20251016-coke-viability-3caac4bc9d9d@spud> References: <20251016095043.1694736-1-yelangyan@huaqin.corp-partner.google.com> <20251016095043.1694736-2-yelangyan@huaqin.corp-partner.google.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="A13/o+hd7ASE21iW" Content-Disposition: inline In-Reply-To: <20251016095043.1694736-2-yelangyan@huaqin.corp-partner.google.com> --A13/o+hd7ASE21iW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 16, 2025 at 05:50:42PM +0800, Langyan Ye wrote: > Add device tree bindings for the Tianma TL121BVMS07-00 12.1-inch > MIPI-DSI TFT LCD panel. The panel is based on the Ilitek IL79900A > controller. >=20 > Signed-off-by: Langyan Ye > --- > .../display/panel/ilitek,il79900a.yaml | 66 +++++++++++++++++++ > 1 file changed, 66 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/ilite= k,il79900a.yaml >=20 > diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,il799= 00a.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,il79900a.= yaml > new file mode 100644 > index 000000000000..4e3c5afd4584 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/ilitek,il79900a.yaml > @@ -0,0 +1,66 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/ilitek,il79900a.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Ilitek IL79900a based MIPI-DSI panels > + > +maintainers: > + - Langyan Ye > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + items: > + - enum: > + - tianma,il79900a Per the commit message, this is for a "Tianma TL121BVMS07-00 12.1-inch MIPI-DSI TFT LCD panel". The compatible you've chosen looks like a copy-paste mistake. Please change it to match the name of the device. > + - const: ilitek,il79900a > + > + reg: true Missing constraints here, right? Unlike backlight, panel-common.yaml doesn't define this property. pw-bot: changes-requested > + > + enable-gpios: > + maxItems: 1 > + description: GPIO specifier for the enable pin > + > + avdd-supply: > + description: Positive analog voltage supply (AVDD) > + > + avee-supply: > + description: Negative analog voltage supply (AVEE) > + > + pp1800-supply: > + description: 1.8V logic voltage supply > + > + backlight: true > + > +required: > + - compatible > + - reg > + - enable-gpios > + - avdd-supply > + - avee-supply > + - pp1800-supply > + > +additionalProperties: false > + > +examples: > + - | > + dsi { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + panel@0 { > + compatible =3D "tianma,il79900a", "ilitek,il79900a"; > + reg =3D <0>; > + enable-gpios =3D <&pio 25 0>; > + avdd-supply =3D <®_avdd>; > + avee-supply =3D <®_avee>; > + pp1800-supply =3D <®_pp1800>; > + backlight =3D <&backlight>; > + }; > + }; > + > +... > --=20 > 2.34.1 >=20 --A13/o+hd7ASE21iW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaPEQLAAKCRB4tDGHoIJi 0lSjAQCkisR+5hpzHQjyvKPCFV2oOqswv94hlbDoUWI+Sh/32wD9FcRnRoWMLQeH LsAcmdzr/o6VvU7XZu0fYiogYktyjAQ= =fU/P -----END PGP SIGNATURE----- --A13/o+hd7ASE21iW--