From: "André Draszik" <andre.draszik@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Marek Szyprowski <m.szyprowski@samsung.com>
Cc: "Peter Griffin" <peter.griffin@linaro.org>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Will McVicker" <willmcvicker@google.com>,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
"André Draszik" <andre.draszik@linaro.org>
Subject: [PATCH v3 03/10] dt-bindings: soc: samsung: gs101-pmu: allow power domains as children
Date: Thu, 16 Oct 2025 16:58:36 +0100 [thread overview]
Message-ID: <20251016-gs101-pd-v3-3-7b30797396e7@linaro.org> (raw)
In-Reply-To: <20251016-gs101-pd-v3-0-7b30797396e7@linaro.org>
The power domains are a property of / implemented in the PMU. As such,
they should be modelled as child nodes of the PMU.
Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
Note: Ideally, the newly added properties (ranges, etc.) should only be
'required' if "^power-domain@[0-9a-f]+$" exists as a patternProperty,
as they're needed only in that case. As-is, this patch now causes
warnings for existing DTs as they don't specify the new properties (and
they shouldn't need to). Only if DTs are updated to include
power-domains, such an update should also add the new properties.
I've not been able to come up with the correct schema syntax to achieve
that. dependencies, dependentRequired, and dependentSchemas don't seem
to support patterns. Similarly,
- if:
required:
- ...
then:
required:
- ...
doesn't allow patterns in the 'if' block (or I didn't get the syntax
right).
Rob said in
https://lore.kernel.org/all/20251010141357.GA219719-robh@kernel.org/
that this is a known limitation in json-schema.
---
.../bindings/soc/google/google,gs101-pmu.yaml | 40 ++++++++++++++++++++++
1 file changed, 40 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml b/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml
index f7119e7a39a3fe0a0a23d1faa251d356f83ba501..a24390f6d2a54afe1aa84935e03f719a62f4fc8e 100644
--- a/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml
+++ b/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml
@@ -26,6 +26,14 @@ properties:
reg:
maxItems: 1
+ '#address-cells':
+ const: 1
+
+ '#size-cells':
+ const: 1
+
+ ranges: true
+
reboot-mode:
$ref: /schemas/power/reset/syscon-reboot-mode.yaml
type: object
@@ -49,9 +57,23 @@ properties:
description:
Phandle to PMU interrupt generation interface.
+patternProperties:
+ "^power-domain@[0-9a-f]+$":
+ type: object
+ description: Child node describing one power domain within the PMU
+
+ additionalProperties: true
+
+ properties:
+ compatible:
+ const: google,gs101-pd
+
required:
- compatible
- reg
+ - '#address-cells'
+ - '#size-cells'
+ - ranges
- google,pmu-intr-gen-syscon
additionalProperties: false
@@ -61,6 +83,24 @@ examples:
system-controller@17460000 {
compatible = "google,gs101-pmu", "syscon";
reg = <0x17460000 0x10000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
google,pmu-intr-gen-syscon = <&pmu_intr_gen>;
+
+ pd_g3d: power-domain@1e00 {
+ compatible = "google,gs101-pd";
+ reg = <0x1e00 0x80>;
+ #power-domain-cells = <0>;
+ label = "g3d";
+ };
+
+ power-domain@2000 {
+ compatible = "google,gs101-pd";
+ reg = <0x2000 0x80>;
+ #power-domain-cells = <0>;
+ power-domains = <&pd_g3d>;
+ label = "embedded_g3d";
+ };
};
--
2.51.0.788.g6d19910ace-goog
next prev parent reply other threads:[~2025-10-16 15:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20251016155848eucas1p193debe70e38b1694bfb250d748f4aa14@eucas1p1.samsung.com>
2025-10-16 15:58 ` [PATCH v3 00/10] pmdomain: samsung: add supoort for Google GS101 André Draszik
2025-10-16 15:58 ` [PATCH v3 01/10] dt-bindings: power: samsung: add google,gs101-pd André Draszik
2025-10-22 6:31 ` Krzysztof Kozlowski
2025-10-16 15:58 ` [PATCH v3 02/10] dt-bindings: soc: samsung: exynos-pmu: move gs101-pmu into separate binding André Draszik
2025-10-22 6:34 ` Krzysztof Kozlowski
2025-10-22 6:36 ` Krzysztof Kozlowski
2025-10-16 15:58 ` André Draszik [this message]
2025-10-21 12:59 ` [PATCH v3 03/10] dt-bindings: soc: samsung: gs101-pmu: allow power domains as children Ulf Hansson
2025-10-21 16:18 ` Krzysztof Kozlowski
2025-10-22 10:03 ` Ulf Hansson
2025-10-22 6:39 ` Krzysztof Kozlowski
2025-10-16 15:58 ` [PATCH v3 04/10] pmdomain: samsung: plug potential memleak during probe André Draszik
2025-10-21 13:54 ` Ulf Hansson
2025-10-16 15:58 ` [PATCH v3 05/10] pmdomain: samsung: convert to using regmap André Draszik
2025-10-16 15:58 ` [PATCH v3 06/10] pmdomain: samsung: convert to regmap_read_poll_timeout() André Draszik
2025-10-21 20:38 ` Marek Szyprowski
2025-10-22 13:45 ` Marek Szyprowski
2025-10-16 15:58 ` [PATCH v3 07/10] pmdomain: samsung: don't hardcode offset for registers to 0 and 4 André Draszik
2025-10-16 15:58 ` [PATCH v3 08/10] pmdomain: samsung: selectively handle enforced sync_state André Draszik
2025-10-22 11:06 ` Ulf Hansson
2025-10-22 18:39 ` Marek Szyprowski
2025-10-23 10:02 ` Ulf Hansson
2025-10-23 12:17 ` Marek Szyprowski
2025-10-23 13:46 ` Ulf Hansson
2025-10-16 15:58 ` [PATCH v3 09/10] pmdomain: samsung: add support for google,gs101-pd André Draszik
2025-10-16 15:58 ` [PATCH v3 10/10] pmdomain: samsung: use dev_err() instead of pr_err() André Draszik
2025-10-17 6:43 ` [PATCH v3 00/10] pmdomain: samsung: add supoort for Google GS101 Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251016-gs101-pd-v3-3-7b30797396e7@linaro.org \
--to=andre.draszik@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=ulf.hansson@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).