From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E79B3570CE for ; Thu, 16 Oct 2025 15:58:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760630334; cv=none; b=msdCmrmr83F/7F71CrEvfzNWJmxZOwZq2+72hlXTXCYa7YVlBjQbTAJJr1EG9ER4iKc2oOscWy2h7k9NxaDVaUdqXDvXJNELoBQof3UU+2Xm4XZASNl70M7cmP4+GO5XlNJS4baflJwqprN9z8RpHnIvXn7oAVcAvafHaV2iTNM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760630334; c=relaxed/simple; bh=Fd87VBZVE3t1XdL1M5TOtbrUL4Nhx964dcSf7oJuDP4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=m5mr6pocDEfUToxKqZM6AVWzsNmWDwNeePD25BjHx/aitJ7Ce5pl+bPDsmtiFi1A5PSuZzGDcO9eet7Faew9srFc19XmpxKUO7+SFEBwGDTNx3COkRvuqS6Nai8T5xiKeftuOX0eJkzlph1o2GPzkF1+9KzXA1zeiCy+9v7Qla0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=E9jtNcTL; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="E9jtNcTL" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-63994113841so1603178a12.3 for ; Thu, 16 Oct 2025 08:58:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760630330; x=1761235130; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9AiSVlBoay/rNWhpOjfQNUl48vUimN757HYzsRqcO8g=; b=E9jtNcTL5i6nXZlZBpthxHD82L00je5KuS30VK1q5zhnIgOaWAy3McYEu/E30AFurv cEr2NneCko5gz7hQavD9ZAzwvxThQoD9VeEVZCmBgsW7HH1W+cuevnUlzV1s0hCbCBQ7 M+vNPgPPwwyLfHUCI4unNyCRvtmqbDygQKtlgf+Yf/gumu8OfzhIOY9eRdjmAl2ceTho OqwcbSTrF8whvvgGs5wEHFMEpbA1C0Q/0yDLS4Pdz6COyQLkOxzpaK48sxlnZITjE9ak C8y5ftN9EQeG7hW/7WFHMTc6NajFDwvJdQeLR1t+DrCd/77dAT36WdxL0DYsbWjbcY/u 0DeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760630330; x=1761235130; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9AiSVlBoay/rNWhpOjfQNUl48vUimN757HYzsRqcO8g=; b=vrbQXhB+evZSFgQDM9tOFXlqFNZyzXmUdp7q2bYaMLSNDW2//DjdekEh95hdoCcF2Z f5WOfLI8R5rvmVqIL7dJRz6ua4uSv/bO5W0D6Mey08N2PXFHOWzlUGH1P+w3Osn8/eED ruMGxmPqtkH8qpM2BdxE+e1iIfLv0EECvntfUZh4FKYou9ZNjphFJ0XJkQwfcPCWcoCk ZqiTgmQpUMPPl8v5Q53IVGCIyyMVhyWP8XzxA1hKnoKM/JgeNJ/FeYjwt+m4cSruH7NW CyiPj6jJV1huPzwTm+wSiTgKUV+LN8L0EQt91LZwsswpFMVE7uZpo76lQImb8vkfjYKz stdA== X-Forwarded-Encrypted: i=1; AJvYcCUQbbJ6vKyRzlPVE4Tui4LPCRO7n0/lZxPgRz4NO4VGU/TS3kJ2viJiPlAh5MIOCxwc+OwDOZ9i+QJW@vger.kernel.org X-Gm-Message-State: AOJu0YwmxDf+b0lrSvR0LgOtwx+fkKsFjHxswkJqv8dzHT1sKPz/WC8c b8c8O+F/r/m0OtIbiI7yMX+TsLYsF3658cgi1HQ/ketYndSaqRz0M7Gxr4oEC6a7P2U= X-Gm-Gg: ASbGncsA1YVYP2FdZapnq4brTq5/xRDiSRha84FIREjgGUm0/ecUT/SuT9YJQD0/ahR VsVvKxSiR05MXWOZXWRUbe7Yd1JjCmFRGdMoSvV6JiBLy9odwXGjHXe+buDr64eCDUrA/JK2qu0 WpPTYK3lif5MABC9J/c31WPVAf4KVQN/GztTFLI+eYWW9suyxmU8Gc53D+2g2GFTiuosnRnSjxj /kDwt4z8GuNWsHXvK+ZQlIrJUyqv1TyxTM07G35GpaTC5eYoDaFVLX1CgYZupqZKaVd/Z3fdv77 8NT6esSpk5DCN5J6jn6pyk3lTBlHNTv8C1HEHVYdfWwUTSHjrbctNW8Ani+11Wv6YVtaxX0M6GL BsQDGLqq4qQQlSXayQKmgNDxMdUAkmlkHiIs05vqdmzEO//79pG89QgWwZ8RbTZ9zAMkOITSONb Q/u6dkajRQMzAdZQGBP7KO+xcvkTEEh6wNLIb4eR/61Im63BHyq3P59+Lsfzlr X-Google-Smtp-Source: AGHT+IGPO+2Zewf0zB4l3rydvFCKk2iYa8qO/BfCMfzqYngcvlnWd8aJbjMUPzhsP0bqvo/AOWVLUg== X-Received: by 2002:a17:907:728d:b0:b3f:f6d:1daa with SMTP id a640c23a62f3a-b647443cf06mr45875966b.37.1760630330042; Thu, 16 Oct 2025 08:58:50 -0700 (PDT) Received: from puffmais2.c.googlers.com (254.48.34.34.bc.googleusercontent.com. [34.34.48.254]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b5ccccb4811sm549021666b.56.2025.10.16.08.58.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Oct 2025 08:58:49 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Thu, 16 Oct 2025 16:58:40 +0100 Subject: [PATCH v3 07/10] pmdomain: samsung: don't hardcode offset for registers to 0 and 4 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20251016-gs101-pd-v3-7-7b30797396e7@linaro.org> References: <20251016-gs101-pd-v3-0-7b30797396e7@linaro.org> In-Reply-To: <20251016-gs101-pd-v3-0-7b30797396e7@linaro.org> To: Krzysztof Kozlowski , Alim Akhtar , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Ulf Hansson , Marek Szyprowski Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 On platforms such as Google gs101, direct mmio register access to the PMU registers doesn't necessarily work and access must happen via a (syscon) regmap created by the PMU driver instead. When such a regmap is used it will cover the complete PMU memory region rather than individual power domains. This means the register offsets for the configuration and status registers will have to take the power domain offsets into account, rather than unconditionally hardcoding 0 and 4 respectively. Update the code to allow that. Signed-off-by: André Draszik --- drivers/pmdomain/samsung/exynos-pm-domains.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/pmdomain/samsung/exynos-pm-domains.c b/drivers/pmdomain/samsung/exynos-pm-domains.c index 431548ad9a7e40c0a77ac6672081b600c90ddd4e..638d286b57f716140b2401092415644a6805870e 100644 --- a/drivers/pmdomain/samsung/exynos-pm-domains.c +++ b/drivers/pmdomain/samsung/exynos-pm-domains.c @@ -29,6 +29,8 @@ struct exynos_pm_domain { struct regmap *regmap; struct generic_pm_domain pd; u32 local_pwr_cfg; + u32 configuration_reg; + u32 status_reg; }; static int exynos_pd_power(struct generic_pm_domain *domain, bool power_on) @@ -41,11 +43,11 @@ static int exynos_pd_power(struct generic_pm_domain *domain, bool power_on) pd = container_of(domain, struct exynos_pm_domain, pd); pwr = power_on ? pd->local_pwr_cfg : 0; - err = regmap_write(pd->regmap, 0, pwr); + err = regmap_write(pd->regmap, pd->configuration_reg, pwr); if (err) return err; - err = regmap_read_poll_timeout(pd->regmap, 0x4, val, + err = regmap_read_poll_timeout(pd->regmap, pd->status_reg, val, (val & pd->local_pwr_cfg) == pwr, 100, 1 * USEC_PER_MSEC); if (err) @@ -146,8 +148,10 @@ static int exynos_pd_probe(struct platform_device *pdev) pd->pd.power_off = exynos_pd_power_off; pd->pd.power_on = exynos_pd_power_on; pd->local_pwr_cfg = pm_domain_cfg->local_pwr_cfg; + pd->configuration_reg += 0; + pd->status_reg += 4; - ret = regmap_read(pd->regmap, 0x4, &val); + ret = regmap_read(pd->regmap, pd->status_reg, &val); if (ret) return dev_err_probe(dev, ret, "failed to read status"); -- 2.51.0.788.g6d19910ace-goog