From: Laurentiu Mihalcea <laurentiumihalcea111@gmail.com>
To: Abel Vesa <abelvesa@kernel.org>, Peng Fan <peng.fan@nxp.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Daniel Baluta <daniel.baluta@nxp.com>,
Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: [PATCH v2 4/8] reset: imx8mp-audiomix: Drop unneeded macros
Date: Fri, 17 Oct 2025 04:20:21 -0700 [thread overview]
Message-ID: <20251017112025.11997-5-laurentiumihalcea111@gmail.com> (raw)
In-Reply-To: <20251017112025.11997-1-laurentiumihalcea111@gmail.com>
From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
The macros defining the mask values for the EARC, EARC PHY resets,
and the DSP RUN_STALL signal can be dropped as they are not and will
not be used anywhere else except to set the value of the "mask" field
from "struct imx8mp_reset_map". In this particular case, based on the
name of the "mask" field, you can already deduce what these values are
for, which is why defining macros for them doesn't offer any new
information, nor does it help with the code readability.
Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
---
drivers/reset/reset-imx8mp-audiomix.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/reset/reset-imx8mp-audiomix.c b/drivers/reset/reset-imx8mp-audiomix.c
index eceb37ff5dc5..e9643365a62c 100644
--- a/drivers/reset/reset-imx8mp-audiomix.c
+++ b/drivers/reset/reset-imx8mp-audiomix.c
@@ -14,11 +14,7 @@
#include <linux/reset-controller.h>
#define IMX8MP_AUDIOMIX_EARC_RESET_OFFSET 0x200
-#define IMX8MP_AUDIOMIX_EARC_RESET_MASK BIT(0)
-#define IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK BIT(1)
-
#define IMX8MP_AUDIOMIX_DSP_RUNSTALL_OFFSET 0x108
-#define IMX8MP_AUDIOMIX_DSP_RUNSTALL_MASK BIT(5)
struct imx8mp_reset_map {
unsigned int offset;
@@ -29,17 +25,17 @@ struct imx8mp_reset_map {
static const struct imx8mp_reset_map reset_map[] = {
[IMX8MP_AUDIOMIX_EARC_RESET] = {
.offset = IMX8MP_AUDIOMIX_EARC_RESET_OFFSET,
- .mask = IMX8MP_AUDIOMIX_EARC_RESET_MASK,
+ .mask = BIT(0),
.active_low = true,
},
[IMX8MP_AUDIOMIX_EARC_PHY_RESET] = {
.offset = IMX8MP_AUDIOMIX_EARC_RESET_OFFSET,
- .mask = IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK,
+ .mask = BIT(1),
.active_low = true,
},
[IMX8MP_AUDIOMIX_DSP_RUNSTALL] = {
.offset = IMX8MP_AUDIOMIX_DSP_RUNSTALL_OFFSET,
- .mask = IMX8MP_AUDIOMIX_DSP_RUNSTALL_MASK,
+ .mask = BIT(5),
.active_low = false,
},
};
--
2.43.0
next prev parent reply other threads:[~2025-10-17 11:21 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 11:20 [PATCH v2 0/8] Add support for i.MX8ULP's SIM LPAV Laurentiu Mihalcea
2025-10-17 11:20 ` [PATCH v2 1/8] reset: imx8mp-audiomix: Fix bad mask values Laurentiu Mihalcea
2025-10-17 14:28 ` Frank Li
2025-10-20 10:57 ` Laurentiu Mihalcea
2025-10-24 3:36 ` Shengjiu Wang
2025-10-27 9:54 ` Daniel Baluta
2025-10-17 11:20 ` [PATCH v2 2/8] dt-bindings: clock: document 8ULP's SIM LPAV Laurentiu Mihalcea
2025-10-17 14:33 ` Frank Li
2025-10-19 10:04 ` Krzysztof Kozlowski
2025-10-17 14:59 ` Frank Li
2025-10-19 10:05 ` Krzysztof Kozlowski
2025-10-20 15:22 ` Frank Li
2025-10-20 15:50 ` Krzysztof Kozlowski
2025-10-22 12:47 ` Laurentiu Mihalcea
2025-10-19 10:03 ` Krzysztof Kozlowski
2025-10-22 14:08 ` Peng Fan
2025-10-22 16:16 ` Frank Li
2025-10-27 15:17 ` Laurentiu Mihalcea
2025-10-27 9:55 ` Daniel Baluta
2025-10-17 11:20 ` [PATCH v2 3/8] clk: imx: add driver for imx8ulp's sim lpav Laurentiu Mihalcea
2025-10-17 14:41 ` Frank Li
2025-10-20 11:40 ` Laurentiu Mihalcea
2025-10-18 4:15 ` kernel test robot
2025-10-18 11:33 ` kernel test robot
2025-10-18 15:55 ` kernel test robot
2025-10-22 14:03 ` Peng Fan
2025-10-23 7:59 ` Peng Fan
2025-10-27 9:50 ` Laurentiu Mihalcea
2025-10-17 11:20 ` Laurentiu Mihalcea [this message]
2025-10-17 14:44 ` [PATCH v2 4/8] reset: imx8mp-audiomix: Drop unneeded macros Frank Li
2025-10-27 10:02 ` Daniel Baluta
2025-10-17 11:20 ` [PATCH v2 5/8] reset: imx8mp-audiomix: Switch to using regmap API Laurentiu Mihalcea
2025-10-17 14:49 ` Frank Li
2025-10-22 11:35 ` Laurentiu Mihalcea
2025-10-17 11:20 ` [PATCH v2 6/8] reset: imx8mp-audiomix: Extend the driver usage Laurentiu Mihalcea
2025-10-17 14:56 ` Frank Li
2025-10-20 11:59 ` Laurentiu Mihalcea
2025-10-20 15:08 ` Frank Li
2025-10-20 14:06 ` Laurentiu Mihalcea
2025-10-20 14:52 ` Frank Li
2025-10-20 14:18 ` Daniel Baluta
2025-10-17 11:20 ` [PATCH v2 7/8] reset: imx8mp-audiomix: Support i.MX8ULP SIM LPAV Laurentiu Mihalcea
2025-10-17 14:57 ` Frank Li
2025-10-20 14:29 ` Laurentiu Mihalcea
2025-10-20 14:50 ` Frank Li
2025-10-21 13:16 ` Laurentiu Mihalcea
2025-10-21 15:06 ` Frank Li
2025-10-17 11:20 ` [PATCH v2 8/8] arm64: dts: imx8ulp: add sim lpav node Laurentiu Mihalcea
2025-10-27 10:07 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251017112025.11997-5-laurentiumihalcea111@gmail.com \
--to=laurentiumihalcea111@gmail.com \
--cc=abelvesa@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).