Re: [PATCH v4 2/2] usb: dwc3: Add Google Tensor SoC DWC3 glue driver

Greg Kroah-Hartman
2025-11-01T06:10:34Z

On Fri, Oct 31, 2025 at 05:49:28PM -0700, Roy Luo wrote:
> > > + dr_role != DWC3_GCTL_PRTCAP_HOST) {
> > > + dev_warn(google->dev, "spurious pme irq %d, hibernation %d, dr_role %u\n",
> > > + irq, google->is_hibernation, dr_role);
> >
> > Should we limit this print and do we need this to be dev_warn? It may be
> > noisy wouldn't it.
>
> Ack, will make it WARN_ONCE in the next version.

So you really want to panic your system if this happens (remember, the
HUGE majority of Linux systems run with panic-on-warn enabled)?

Please do not, handle the issue, dump a message to the log if you really
need to, and move on, don't crash.

thanks,

greg k-h