public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Ariana Lazar <ariana.lazar@microchip.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Guenter Roeck" <linux@roeck-us.net>,
	linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 0/2] Adding support for Microchip PAC1711
Date: Sun, 19 Oct 2025 11:31:46 +0100	[thread overview]
Message-ID: <20251019113146.74c3f236@jic23-huawei> (raw)
In-Reply-To: <20251015-pac1711-v1-0-976949e36367@microchip.com>

On Wed, 15 Oct 2025 13:12:14 +0300
Ariana Lazar <ariana.lazar@microchip.com> wrote:

> The PAC1711 product is a single-channel power monitor with accumulator.
> The device uses 12-bit resolution for voltage and current measurements and
> 24 bits power calculations. The accumulator register (56-bit) could
> accumulate power (energy), current (Coulomb counter) or voltage.
> 
> PAC1711 measures up to 42V Full-Scale Range.

Hi Ariana,

For devices like this where the datasheet explicitly calls out usecases in
power monitoring e.g. for "Portable and Embedded Computing" (amongst other
things) there is always a question to answer wrt to whether the correct
place to support them in Linux is in hwmon or IIO. Note that, whilst this
has long been an informal policy I've become more strict on this after some
concerns were raised in the last cycle - the presence of similar devices
in IIO isn't necessarily a sign that was the right choice, but it is worth
looking at the history of those divers as it may provide more insight into
why they are in IIO.

To address that we ask that:
1) Drivers for this sort of potentially borderline device are +CC to hwmon
   list and maintainers
2) A justification for IIO making more sense is included. That can be
   based on what cannot be supported in hwmon (high speed capture being
   a typical item - that doesn't seem to apply here as it's only 200 sample/sec)

Anyhow, I've +CC relevant folk so if you can reply with that info here then
that would be great.

Thanks,

Jonathan

> 
> Signed-off-by: Ariana Lazar <ariana.lazar@microchip.com>
> ---
> Ariana Lazar (2):
>       dt-bindings: iio: adc: adding support for PAC1711
>       iio: adc: adding support for PAC1711
> 
>  .../ABI/testing/sysfs-bus-iio-adc-pac1711          |   57 +
>  .../bindings/iio/adc/microchip,pac1711.yaml        |  195 +++
>  MAINTAINERS                                        |    8 +
>  drivers/iio/adc/Kconfig                            |   10 +
>  drivers/iio/adc/Makefile                           |    1 +
>  drivers/iio/adc/pac1711.c                          | 1448 ++++++++++++++++++++
>  6 files changed, 1719 insertions(+)
> ---
> base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> change-id: 20250901-pac1711-d3bacda400fd
> 
> Best regards,


  parent reply	other threads:[~2025-10-19 10:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-15 10:12 [PATCH 0/2] Adding support for Microchip PAC1711 Ariana Lazar
2025-10-15 10:12 ` [PATCH 1/2] dt-bindings: iio: adc: adding support for PAC1711 Ariana Lazar
2025-10-16 16:19   ` Conor Dooley
2025-10-19  9:04   ` Jonathan Cameron
2025-11-25 17:25     ` Ariana.Lazar
2025-10-15 10:12 ` [PATCH 2/2] " Ariana Lazar
2025-10-16  5:31   ` kernel test robot
2025-10-19 10:28   ` Jonathan Cameron
2025-11-19 15:31     ` Ariana.Lazar
2025-11-19 15:58       ` Andy Shevchenko
2025-10-23  7:31   ` Dan Carpenter
2025-10-19 10:31 ` Jonathan Cameron [this message]
2025-10-19 15:02   ` [PATCH 0/2] Adding support for Microchip PAC1711 Guenter Roeck
2025-10-23 12:36     ` Ariana.Lazar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251019113146.74c3f236@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=ariana.lazar@microchip.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox