[PATCH 0/3] mfd/watchdog: dt-bindings: Reference watchdog schema in rohm,bd96801-pmic

[PATCH 0/3] mfd/watchdog: dt-bindings: Reference watchdog schema in rohm,bd96801-pmic

[Krzysztof Kozlowski]

Dependency
==========
The last MFD patch depends on the previous watchdog.

rohm,bd96801-pmic.yaml binding should reference watchdog.yaml which
leads to few more patches.

Best regards,
Krzysztof

---
Krzysztof Kozlowski (3):
      dt-bindings: watchdog: Restrict timeout-sec to one number
      dt-bindings: watchdog: Allow node names named 'pmic'
      dt-bindings: mfd: rohm,bd96801-pmic: Correct timeout-sec length and reference watchdog schema

 Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml | 8 +++++---
 Documentation/devicetree/bindings/watchdog/watchdog.yaml     | 3 ++-
 2 files changed, 7 insertions(+), 4 deletions(-)
---
base-commit: 52ba76324a9d7c39830c850999210a36ef023cde
change-id: 20251020-dt-bindings-watchdog-timeout-384a54249098

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

[PATCH 1/3] dt-bindings: watchdog: Restrict timeout-sec to one number

[Krzysztof Kozlowski]

Linux kernel expects only one number for the watchdog timeout and the
type is an array (defined in property-units.yaml in DT schema), so
restrict the property.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/watchdog/watchdog.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/watchdog/watchdog.yaml b/Documentation/devicetree/bindings/watchdog/watchdog.yaml
index f0a584af1223..be0327f587eb 100644
--- a/Documentation/devicetree/bindings/watchdog/watchdog.yaml
+++ b/Documentation/devicetree/bindings/watchdog/watchdog.yaml
@@ -24,6 +24,7 @@ properties:
     pattern: "^(timer|watchdog)(@.*|-([0-9]|[1-9][0-9]+))?$"
 
   timeout-sec:
+    maxItems: 1
     description:
       Contains the watchdog timeout in seconds.
 

-- 
2.48.1

[PATCH 2/3] dt-bindings: watchdog: Allow node names named 'pmic'

[Krzysztof Kozlowski]

Watchdog is often part of more complex devices like Power Management ICs
(PMIC), e.g. on rohm,bd96801, and the schema can be referenced by a
binding describing parent (main) node.  Allow another typical name for
such PMIC devices: pmic.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/watchdog/watchdog.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/watchdog/watchdog.yaml b/Documentation/devicetree/bindings/watchdog/watchdog.yaml
index be0327f587eb..77ac23516d6d 100644
--- a/Documentation/devicetree/bindings/watchdog/watchdog.yaml
+++ b/Documentation/devicetree/bindings/watchdog/watchdog.yaml
@@ -21,7 +21,7 @@ select:
 
 properties:
   $nodename:
-    pattern: "^(timer|watchdog)(@.*|-([0-9]|[1-9][0-9]+))?$"
+    pattern: "^(pmic|timer|watchdog)(@.*|-([0-9]|[1-9][0-9]+))?$"
 
   timeout-sec:
     maxItems: 1

-- 
2.48.1

[PATCH 3/3] dt-bindings: mfd: rohm,bd96801-pmic: Correct timeout-sec length and reference watchdog schema

[Krzysztof Kozlowski]

The parent node of ROHM BD96801 PMIC is also holding properties for the
watchdog, thus it should reference watchdog.yaml schema.  OTOH, the
timeout-sec property is used only as one number.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

This depends on previous watchdog patch.  I propose to take entire set
via watchdog tree, with Lee's acks.
---
 Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml
index 0e06570483ae..adb491bcc8dc 100644
--- a/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml
@@ -57,8 +57,7 @@ properties:
       - prstb
       - intb-only
 
-  timeout-sec:
-    maxItems: 2
+  timeout-sec: true
 
   regulators:
     $ref: /schemas/regulator/rohm,bd96801-regulator.yaml
@@ -72,7 +71,10 @@ required:
   - interrupt-names
   - regulators
 
-additionalProperties: false
+allOf:
+  - $ref: /schemas/watchdog/watchdog.yaml
+
+unevaluatedProperties: false
 
 examples:
   - |

-- 
2.48.1

Re: [PATCH 1/3] dt-bindings: watchdog: Restrict timeout-sec to one number

[Guenter Roeck]

On 10/20/25 09:52, Krzysztof Kozlowski wrote:
> Linux kernel expects only one number for the watchdog timeout and the
> type is an array (defined in property-units.yaml in DT schema), so
> restrict the property.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   Documentation/devicetree/bindings/watchdog/watchdog.yaml | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/watchdog.yaml b/Documentation/devicetree/bindings/watchdog/watchdog.yaml
> index f0a584af1223..be0327f587eb 100644
> --- a/Documentation/devicetree/bindings/watchdog/watchdog.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/watchdog.yaml
> @@ -24,6 +24,7 @@ properties:
>       pattern: "^(timer|watchdog)(@.*|-([0-9]|[1-9][0-9]+))?$"
>   
>     timeout-sec:
> +    maxItems: 1
>       description:
>         Contains the watchdog timeout in seconds.
>   
> 

Re: [PATCH 2/3] dt-bindings: watchdog: Allow node names named 'pmic'

[Guenter Roeck]

On 10/20/25 09:52, Krzysztof Kozlowski wrote:
> Watchdog is often part of more complex devices like Power Management ICs
> (PMIC), e.g. on rohm,bd96801, and the schema can be referenced by a
> binding describing parent (main) node.  Allow another typical name for
> such PMIC devices: pmic.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   Documentation/devicetree/bindings/watchdog/watchdog.yaml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/watchdog.yaml b/Documentation/devicetree/bindings/watchdog/watchdog.yaml
> index be0327f587eb..77ac23516d6d 100644
> --- a/Documentation/devicetree/bindings/watchdog/watchdog.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/watchdog.yaml
> @@ -21,7 +21,7 @@ select:
>   
>   properties:
>     $nodename:
> -    pattern: "^(timer|watchdog)(@.*|-([0-9]|[1-9][0-9]+))?$"
> +    pattern: "^(pmic|timer|watchdog)(@.*|-([0-9]|[1-9][0-9]+))?$"
>   
>     timeout-sec:
>       maxItems: 1
> 

Re: [PATCH 3/3] dt-bindings: mfd: rohm,bd96801-pmic: Correct timeout-sec length and reference watchdog schema

[Guenter Roeck]

On 10/20/25 09:52, Krzysztof Kozlowski wrote:
> The parent node of ROHM BD96801 PMIC is also holding properties for the
> watchdog, thus it should reference watchdog.yaml schema.  OTOH, the
> timeout-sec property is used only as one number.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> 
> ---
> 
> This depends on previous watchdog patch.  I propose to take entire set
> via watchdog tree, with Lee's acks.
> ---
>   Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml
> index 0e06570483ae..adb491bcc8dc 100644
> --- a/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml
> @@ -57,8 +57,7 @@ properties:
>         - prstb
>         - intb-only
>   
> -  timeout-sec:
> -    maxItems: 2
> +  timeout-sec: true
>   
>     regulators:
>       $ref: /schemas/regulator/rohm,bd96801-regulator.yaml
> @@ -72,7 +71,10 @@ required:
>     - interrupt-names
>     - regulators
>   
> -additionalProperties: false
> +allOf:
> +  - $ref: /schemas/watchdog/watchdog.yaml
> +
> +unevaluatedProperties: false
>   
>   examples:
>     - |
> 

Re: [PATCH 3/3] dt-bindings: mfd: rohm,bd96801-pmic: Correct timeout-sec length and reference watchdog schema

[Matti Vaittinen]

Thanks Krzysztof!

On 20/10/2025 19:52, Krzysztof Kozlowski wrote:
> The parent node of ROHM BD96801 PMIC is also holding properties for the
> watchdog, thus it should reference watchdog.yaml schema.  OTOH, the
> timeout-sec property is used only as one number.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Matti Vaittinen <mazziesaccount@gmail.com>

Re: [PATCH 1/3] dt-bindings: watchdog: Restrict timeout-sec to one number

[Rob Herring (Arm)]

On Mon, 20 Oct 2025 18:52:20 +0200, Krzysztof Kozlowski wrote:
> Linux kernel expects only one number for the watchdog timeout and the
> type is an array (defined in property-units.yaml in DT schema), so
> restrict the property.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/watchdog/watchdog.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH 2/3] dt-bindings: watchdog: Allow node names named 'pmic'

[Rob Herring (Arm)]

On Mon, 20 Oct 2025 18:52:21 +0200, Krzysztof Kozlowski wrote:
> Watchdog is often part of more complex devices like Power Management ICs
> (PMIC), e.g. on rohm,bd96801, and the schema can be referenced by a
> binding describing parent (main) node.  Allow another typical name for
> such PMIC devices: pmic.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/watchdog/watchdog.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH 3/3] dt-bindings: mfd: rohm,bd96801-pmic: Correct timeout-sec length and reference watchdog schema

[Rob Herring (Arm)]

On Mon, 20 Oct 2025 18:52:22 +0200, Krzysztof Kozlowski wrote:
> The parent node of ROHM BD96801 PMIC is also holding properties for the
> watchdog, thus it should reference watchdog.yaml schema.  OTOH, the
> timeout-sec property is used only as one number.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> This depends on previous watchdog patch.  I propose to take entire set
> via watchdog tree, with Lee's acks.
> ---
>  Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>