From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5B1235504B; Thu, 23 Oct 2025 19:55:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761249323; cv=pass; b=DtydcYygcyg9avX1Xn/fRSyLgmLVvk6wYDMTdWE4xZKHkryXHn12PVWR7EcOAPIWEmqYxH+JElqdolvcTlFNQpCSOLzAf0q77TVpS0yezjkdwu/jddXkFH1+krSJlXOQs/NNv2DSlzhUQ1+Zx99MYnTNEsFIrHaN6gEUXOtjVq4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761249323; c=relaxed/simple; bh=34/USOgpWq2sTxuxisGQSPYfcEzkuKCBSEPKTDKzePE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZeqS2RcWAbl+EyV4HeYua0Su8mIndY1eSZSEDLNOf5M8dT3jEedHkYezQRlM5PzuC0GvnOZjorUCsw0gXgRYnWb2F/plWmyv8xGlgUz9wAY/FxbfZVQ2yIjCsRPAdhzdivTTMKrC9bfJruHmUdm9XN5QI0z5yyUxcX/2RI07Q7o= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=FcMoOpAW; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="FcMoOpAW" ARC-Seal: i=1; a=rsa-sha256; t=1761249102; cv=none; d=zohomail.com; s=zohoarc; b=UCx4NZ14cwKMBXH6Al22riO2hfLQML5qkDq9x839iL8Tgq5u/Mm8s0ayG5jscxpx/y6FVPRffucm2w7g0YljA9ZbaJkRtSBu94pRq1y5ibMPfo4lsA6Y7LTmSPdWPmBky6IBRMVccLCfcGkvQCaHBRj2jV2jDUyothaz1+W4M+I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761249102; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=o589LR6+X8FWTmM/cB7UMVmp06chy9uKAy4nz1x3QK4=; b=JgFhN+AE/go2+nbE70kzw2ffIxJdw6xmTWPyp/EG78W47w79epovUc7rVxVNCuc5EPM8EaouiW5xxAtobOQZpjEnPXMF/73ZTly3cIysRLAQUa3dvDCa4sr6tSOkTlJU7qww7xpMrH3vrxGyp6/+DFDB0agO7Jnn6/eEV/wRxjg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1761249102; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=o589LR6+X8FWTmM/cB7UMVmp06chy9uKAy4nz1x3QK4=; b=FcMoOpAW83BHo/qaC6gDzKy1Z4N2i+iz7SPBcODKhwEJ03f2ekFoJzCvz/JtaAqg fB26bjfPpmxIa6kl+uhDNxxfV0K/2VSLzKqBEIdrhdWO0sYjQ9jMTzKn6vIR7GqvdpF kNJXUjvAgsrYLiAOy62irD+gDtZy2JT2Gl5V4zjo= Received: by mx.zohomail.com with SMTPS id 1761249100086437.55374163067677; Thu, 23 Oct 2025 12:51:40 -0700 (PDT) From: Nicolas Frattaroli Date: Thu, 23 Oct 2025 21:49:32 +0200 Subject: [PATCH v3 14/24] scsi: ufs: mediatek: Remove mediatek,ufs-broken-rtc property Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251023-mt8196-ufs-v3-14-0f04b4a795ff@collabora.com> References: <20251023-mt8196-ufs-v3-0-0f04b4a795ff@collabora.com> In-Reply-To: <20251023-mt8196-ufs-v3-0-0f04b4a795ff@collabora.com> To: Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Chunfeng Yun , Vinod Koul , Kishon Vijay Abraham I , Peter Wang , Stanley Jhu , "James E.J. Bottomley" , "Martin K. Petersen" , Philipp Zabel , Liam Girdwood , Mark Brown Cc: Louis-Alexis Eyraud , kernel@collabora.com, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, Nicolas Frattaroli X-Mailer: b4 0.14.3 This flag property was never described in the binding, and its capability wrapper seems pointless. If one of the MediaTek SoCs needs the ufshcd quirk applied, then this can be done per-compatible, without needing to give the device tree author the option to forget to set it. Remove it and the associated capability flag wrapping code. Signed-off-by: Nicolas Frattaroli --- drivers/ufs/host/ufs-mediatek.c | 5 ----- drivers/ufs/host/ufs-mediatek.h | 2 -- 2 files changed, 7 deletions(-) diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c index 427e6bc3a476..44676ba4c392 100644 --- a/drivers/ufs/host/ufs-mediatek.c +++ b/drivers/ufs/host/ufs-mediatek.c @@ -655,9 +655,6 @@ static void ufs_mtk_init_host_caps(struct ufs_hba *hba) if (of_property_read_bool(np, "mediatek,ufs-rtff-mtcmos")) host->caps |= UFS_MTK_CAP_RTFF_MTCMOS; - if (of_property_read_bool(np, "mediatek,ufs-broken-rtc")) - host->caps |= UFS_MTK_CAP_MCQ_BROKEN_RTC; - dev_info(hba->dev, "caps: 0x%x", host->caps); } @@ -1172,8 +1169,6 @@ static int ufs_mtk_init(struct ufs_hba *hba) hba->quirks |= UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL; hba->quirks |= UFSHCD_QUIRK_MCQ_BROKEN_INTR; - if (host->caps & UFS_MTK_CAP_MCQ_BROKEN_RTC) - hba->quirks |= UFSHCD_QUIRK_MCQ_BROKEN_RTC; hba->vps->wb_flush_threshold = UFS_WB_BUF_REMAIN_PERCENT(80); diff --git a/drivers/ufs/host/ufs-mediatek.h b/drivers/ufs/host/ufs-mediatek.h index 4e6a34f4ac39..9c377745f7a0 100644 --- a/drivers/ufs/host/ufs-mediatek.h +++ b/drivers/ufs/host/ufs-mediatek.h @@ -138,8 +138,6 @@ enum ufs_mtk_host_caps { UFS_MTK_CAP_DISABLE_MCQ = 1 << 8, /* Control MTCMOS with RTFF */ UFS_MTK_CAP_RTFF_MTCMOS = 1 << 9, - - UFS_MTK_CAP_MCQ_BROKEN_RTC = 1 << 10, }; struct ufs_mtk_crypt_cfg { -- 2.51.1.dirty