From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Dinh Nguyen <dinguyen@kernel.org>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Matthew Gerlach <matthew.gerlach@altera.com>
Cc: kernel@pengutronix.de, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Teoh Ji Sheng <ji.sheng.teoh@intel.com>
Subject: [PATCH v5 02/10] net: stmmac: Use interrupt mode INTM=1 for per channel irq
Date: Fri, 24 Oct 2025 13:49:54 +0200 [thread overview]
Message-ID: <20251024-v6-12-topic-socfpga-agilex5-v5-2-4c4a51159eeb@pengutronix.de> (raw)
In-Reply-To: <20251024-v6-12-topic-socfpga-agilex5-v5-0-4c4a51159eeb@pengutronix.de>
From: Teoh Ji Sheng <ji.sheng.teoh@intel.com>
commit 6ccf12ae111e ("net: stmmac: use interrupt mode INTM=1
for multi-MSI") is introduced for platform that uses MSI.
Similar approach is taken to enable per channel interrupt
that uses shared peripheral interrupt (SPI), so only per channel
TX and RX intr (TI/RI) are handled by TX/RX ISR without calling
common interrupt ISR.
TX/RX NORMAL interrupts check is now decoupled, since NIS bit
is not asserted for any TI/RI events when INTM=1.
Signed-off-by: Teoh Ji Sheng <ji.sheng.teoh@intel.com>
Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h | 3 +++
drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c | 10 +++++++++-
.../net/ethernet/stmicro/stmmac/stmmac_platform.c | 20 ++++++++++++++++++++
include/linux/stmmac.h | 2 ++
4 files changed, 34 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h
index 0d408ee17f337..64b533207e4a6 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h
+++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h
@@ -326,6 +326,9 @@
/* DMA Registers */
#define XGMAC_DMA_MODE 0x00003000
#define XGMAC_SWR BIT(0)
+#define DMA_MODE_INTM_MASK GENMASK(13, 12)
+#define DMA_MODE_INTM_SHIFT 12
+#define DMA_MODE_INTM_MODE1 0x1
#define XGMAC_DMA_SYSBUS_MODE 0x00003004
#define XGMAC_WR_OSR_LMT GENMASK(29, 24)
#define XGMAC_WR_OSR_LMT_SHIFT 24
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
index 4d6bb995d8d84..1e9ee1f10f0ef 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
@@ -31,6 +31,13 @@ static void dwxgmac2_dma_init(void __iomem *ioaddr,
value |= XGMAC_EAME;
writel(value, ioaddr + XGMAC_DMA_SYSBUS_MODE);
+
+ if (dma_cfg->multi_irq_en) {
+ value = readl(ioaddr + XGMAC_DMA_MODE);
+ value &= ~DMA_MODE_INTM_MASK;
+ value |= (DMA_MODE_INTM_MODE1 << DMA_MODE_INTM_SHIFT);
+ writel(value, ioaddr + XGMAC_DMA_MODE);
+ }
}
static void dwxgmac2_dma_init_chan(struct stmmac_priv *priv,
@@ -359,13 +366,14 @@ static int dwxgmac2_dma_interrupt(struct stmmac_priv *priv,
}
}
- /* TX/RX NORMAL interrupts */
+ /* RX NORMAL interrupts */
if (likely(intr_status & XGMAC_RI)) {
u64_stats_update_begin(&stats->syncp);
u64_stats_inc(&stats->rx_normal_irq_n[chan]);
u64_stats_update_end(&stats->syncp);
ret |= handle_rx;
}
+ /* TX NORMAL interrupts */
if (likely(intr_status & (XGMAC_TI | XGMAC_TBU))) {
u64_stats_update_begin(&stats->syncp);
u64_stats_inc(&stats->tx_normal_irq_n[chan]);
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index 27bcaae07a7f2..cfa82b8e04b94 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -607,6 +607,8 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac)
dma_cfg->fixed_burst = of_property_read_bool(np, "snps,fixed-burst");
dma_cfg->mixed_burst = of_property_read_bool(np, "snps,mixed-burst");
+ dma_cfg->multi_irq_en = of_property_read_bool(np, "snps,multi-irq-en");
+
plat->force_thresh_dma_mode = of_property_read_bool(np, "snps,force_thresh_dma_mode");
if (plat->force_thresh_dma_mode && plat->force_sf_dma_mode) {
plat->force_sf_dma_mode = 0;
@@ -737,6 +739,8 @@ EXPORT_SYMBOL_GPL(stmmac_pltfr_find_clk);
int stmmac_get_platform_resources(struct platform_device *pdev,
struct stmmac_resources *stmmac_res)
{
+ char irq_name[11];
+ int i;
memset(stmmac_res, 0, sizeof(*stmmac_res));
/* Get IRQ information early to have an ability to ask for deferred
@@ -746,6 +750,22 @@ int stmmac_get_platform_resources(struct platform_device *pdev,
if (stmmac_res->irq < 0)
return stmmac_res->irq;
+ /* For RX Channel */
+ for (i = 0; i < MTL_MAX_RX_QUEUES; i++) {
+ sprintf(irq_name, "%s%d", "macirq_rx", i);
+ stmmac_res->rx_irq[i] = platform_get_irq_byname(pdev, irq_name);
+ if (stmmac_res->rx_irq[i] < 0)
+ break;
+ }
+
+ /* For TX Channel */
+ for (i = 0; i < MTL_MAX_TX_QUEUES; i++) {
+ sprintf(irq_name, "%s%d", "macirq_tx", i);
+ stmmac_res->tx_irq[i] = platform_get_irq_byname(pdev, irq_name);
+ if (stmmac_res->tx_irq[i] < 0)
+ break;
+ }
+
/* On some platforms e.g. SPEAr the wake up irq differs from the mac irq
* The external wake up irq can be passed through the platform code
* named as "eth_wake_irq"
diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h
index fa1318bac06c4..a8b15b4e3c370 100644
--- a/include/linux/stmmac.h
+++ b/include/linux/stmmac.h
@@ -102,6 +102,7 @@ struct stmmac_dma_cfg {
bool aal;
bool eame;
bool multi_msi_en;
+ bool multi_irq_en;
bool dche;
bool atds;
};
@@ -290,6 +291,7 @@ struct plat_stmmacenet_data {
u8 vlan_fail_q;
struct pci_dev *pdev;
int int_snapshot_num;
+ bool multi_irq_en;
int msi_mac_vec;
int msi_wol_vec;
int msi_lpi_vec;
--
2.51.0
next prev parent reply other threads:[~2025-10-24 11:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 11:49 [PATCH v5 00/10] arm64: dts: socfpga: agilex5: enable network and add new board Steffen Trumtrar
2025-10-24 11:49 ` [PATCH v5 01/10] net: stmmac: dwmac-socfpga: don't set has_gmac Steffen Trumtrar
2025-10-24 12:11 ` Maxime Chevallier
2025-10-24 12:30 ` Steffen Trumtrar
2025-10-29 8:11 ` G Thomas, Rohan
2025-10-25 18:55 ` Russell King (Oracle)
2025-10-24 11:49 ` Steffen Trumtrar [this message]
2025-10-24 12:21 ` [PATCH v5 02/10] net: stmmac: Use interrupt mode INTM=1 for per channel irq Maxime Chevallier
2025-10-24 17:00 ` Simon Horman
2025-10-25 19:01 ` Russell King (Oracle)
2025-10-24 11:49 ` [PATCH v5 03/10] arm64: dts: socfpga: agilex5: Add SMMU node Steffen Trumtrar
2025-10-24 11:49 ` [PATCH v5 04/10] arm64: dts: socfpga: agilex5: smmu enablement Steffen Trumtrar
2025-10-24 12:05 ` Dinh Nguyen
2025-10-24 16:57 ` Simon Horman
2025-10-24 11:49 ` [PATCH v5 05/10] dt-bindings: net: altr,socfpga-stmmac: add generic dwxgmac compatible Steffen Trumtrar
2025-10-26 8:53 ` Krzysztof Kozlowski
2025-10-24 11:49 ` [PATCH v5 06/10] arm64: dts: socfpga: agilex5: add " Steffen Trumtrar
2025-10-24 12:00 ` Dinh Nguyen
2025-10-24 12:20 ` Steffen Trumtrar
2025-10-24 11:49 ` [PATCH v5 07/10] dt-bindings: net: altr,socfpga-stmmac: allow dma-coherent property Steffen Trumtrar
2025-10-26 8:50 ` Krzysztof Kozlowski
2025-10-24 11:50 ` [PATCH v5 08/10] arm64: dts: socfpga: agilex5: dma coherent enablement for XGMACs Steffen Trumtrar
2025-10-24 11:50 ` [PATCH v5 09/10] dt-bindings: intel: add agilex5-based Arrow AXE5-Eagle Steffen Trumtrar
2025-10-24 11:50 ` [PATCH v5 10/10] arm64: dts: socfpga: agilex5: initial support for " Steffen Trumtrar
2025-10-25 0:07 ` [PATCH v5 00/10] arm64: dts: socfpga: agilex5: enable network and add new board Jakub Kicinski
2025-10-25 18:52 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251024-v6-12-topic-socfpga-agilex5-v5-2-4c4a51159eeb@pengutronix.de \
--to=s.trumtrar@pengutronix.de \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=edumazet@google.com \
--cc=ji.sheng.teoh@intel.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=matthew.gerlach@altera.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).