From: Jonathan Cameron <jonathan.cameron@huawei.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/3] iio: dac: ad5456: Add missing DT compatibles
Date: Fri, 24 Oct 2025 19:41:15 +0100 [thread overview]
Message-ID: <20251024194115.000054bd@huawei.com> (raw)
In-Reply-To: <aPupTHhbvvMq4c7I@smile.fi.intel.com>
On Fri, 24 Oct 2025 19:29:00 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Thu, Oct 23, 2025 at 02:01:38PM +0300, Nuno Sá wrote:
> > Add missing of_device_id compatibles for the i2c and spi drivers.
>
> How does it work at all? Is there an ugly ifdeferry?
Exactly that.
> No module should have two
> module_*_driver() and other stuff.
>
Indeed, hence not using that infrastructure.
I wouldn't mind more significant refactors...
J
next prev parent reply other threads:[~2025-10-24 18:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 11:01 [PATCH v2 0/3] iio: dac: ad5446: Add AD5542 to the spi id table Nuno Sá
2025-10-23 11:01 ` [PATCH v2 1/3] dt-bindings: iio: dac: Document AD5446 and similar devices Nuno Sá
2025-10-23 17:08 ` Jonathan Cameron
2025-10-27 14:48 ` Nuno Sá
2025-10-27 15:01 ` Jonathan Cameron
2025-10-30 11:30 ` Nuno Sá
2025-11-02 12:13 ` Jonathan Cameron
2025-10-23 18:24 ` Conor Dooley
2025-10-24 10:12 ` Jonathan Cameron
2025-10-24 11:04 ` Conor Dooley
2025-10-27 14:49 ` Nuno Sá
2025-10-23 11:01 ` [PATCH v2 2/3] iio: dac: ad5456: Add missing DT compatibles Nuno Sá
2025-10-23 17:13 ` Jonathan Cameron
2025-10-27 14:55 ` Nuno Sá
2025-10-24 16:29 ` Andy Shevchenko
2025-10-24 18:41 ` Jonathan Cameron [this message]
2025-10-23 11:01 ` [PATCH v2 3/3] iio: dac: ad5446: Add AD5542 to the spi id table Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251024194115.000054bd@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).