From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EAF31BC5C; Sun, 26 Oct 2025 22:25:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761517552; cv=none; b=nNpW1iwR8YHHGEY+yXwyXcB4rRhdWoYF5qzTPshlbUALkOiNvY0P5ggfaWBEjZD1iurz0wtxMFH9+I60Tk7sm/X3Vogc2r0Z+MceYEaIldhzzjDNP13sC8d9giJsWZ/ObjQ7+ey9wAs0UhSFP+agXD8RR4u3pWlUsBp3aGw8LbU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761517552; c=relaxed/simple; bh=YcfVCtLK/W1LvoMvGvygXNzNh0vRWUm1hNpESZXkvZk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=o4Weh8bEK+ArCVePNrTCzL3x0d9zg8Gc5HnEZUBOLpJvFL84k1+1qIm2APAFVynPPKzA9MpVBCb/+7sGqnZihVZwxuHVjWP/sDZiGrPFC1NCqbjbl/IpwQ/Vou4xbcofKzllyswYVoWN7Bpckm7JDL5FZEfTTfOnX2Sm81yJHgI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=X55sznBA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="X55sznBA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49624C4CEE7; Sun, 26 Oct 2025 22:25:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761517552; bh=YcfVCtLK/W1LvoMvGvygXNzNh0vRWUm1hNpESZXkvZk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X55sznBAWggJ/HDGIZ6dcBSXLmlm8wZtp4v11We2/RanthjNuuSqrLXxB3D6+dJjG KWLdA/u217zShuCi99Na37WPbV+mGEk3vLOm7l2lwkobjD01Ue0VTeVaSkehFWCkFY VIsVUB+J5nn8qynVBOGW4T94+24+ocYVV67OfpVpp8MZvBE9yBuq90LCEBwr8dCLPS 54mHUndnVBWYO4DsnbhAUNwGBuMydDoQLLoD/wxo//W+p4+51f+YoNswBdb0VumVAz faYPxFUmixtcIAAjpcJMrs7xJr5oYeDft/J4naku8wTQTYHiSwYYy3gBXnRTXFElR6 3f/UL93sKp2tQ== Date: Sun, 26 Oct 2025 22:25:44 +0000 From: Conor Dooley To: Nicolas Frattaroli Cc: Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Chunfeng Yun , Vinod Koul , Kishon Vijay Abraham I , Peter Wang , Stanley Jhu , "James E.J. Bottomley" , "Martin K. Petersen" , Philipp Zabel , Liam Girdwood , Mark Brown , Louis-Alexis Eyraud , kernel@collabora.com, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org Subject: Re: [PATCH v3 03/24] dt-bindings: ufs: mediatek,ufs: Add mt8196 variant Message-ID: <20251026-these-wise-9b5e63c78907@spud> References: <20251023-mt8196-ufs-v3-0-0f04b4a795ff@collabora.com> <20251023-mt8196-ufs-v3-3-0f04b4a795ff@collabora.com> <20251024-thrash-amid-d5af186c4319@spud> <5617400.31r3eYUQgx@workhorse> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LhPY1uIXOXYzwQC0" Content-Disposition: inline In-Reply-To: <5617400.31r3eYUQgx@workhorse> --LhPY1uIXOXYzwQC0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 24, 2025 at 07:51:11PM +0200, Nicolas Frattaroli wrote: > On Friday, 24 October 2025 19:13:36 Central European Summer Time Conor Do= oley wrote: > > On Thu, Oct 23, 2025 at 09:49:21PM +0200, Nicolas Frattaroli wrote: > >=20 > > > }; > > > + - | > > > + #include > > > + #include > > > + > > > + ufshci@16810000 { > > > + compatible =3D "mediatek,mt8196-ufshci"; > > > + reg =3D <0x16810000 0x2a00>; > > > + interrupts =3D ; > > > + > > > + clocks =3D <&ufs_ao_clk 6>, > > > + <&ufs_ao_clk 7>, > > > + <&clk26m>, > > > + <&ufs_ao_clk 3>, > > > + <&clk26m>, > > > + <&ufs_ao_clk 4>, > > > + <&ufs_ao_clk 0>, > > > + <&topckgen 7>, > > > + <&topckgen 41>, > > > + <&topckgen 105>, > > > + <&topckgen 83>, > > > + <&ufs_ao_clk 1>, > > > + <&ufs_ao_clk 2>, > > > + <&topckgen 42>, > > > + <&topckgen 84>, > > > + <&topckgen 102>; > >=20 > > This is absolutely a nitpick thing, but if you end up resubmitting, can > > you pick a consistent format between the two examples your series adds > > for the clocks/clock names? >=20 > No problem, will do. IIRC I kept them as a list like this so I could > easily reorder things, but now that I'm fairly sure this order is the > correct one, it's probably best to make this more compact. >=20 > Also sorry for the numbers as clock IDs, but MediaTek clock headers > have conflicting symbols and the dt schema example extractor dumps > all examples into one dts file. :( Numbers is fine, dw about that. > Since this has bugged me in the past, and many schemas may rely on > the concat behaviour now: would a patch in the distant future that > prefixes all MediaTek clock binding headers with the SoC name be > acceptable if it keeps the old names intact as aliases to them with > a #ifndef guard? Honestly, I don't think it's that big of a deal to use the numbers, they're only examples after all (even if for soc-peripherals they're almost always exactly what is used in reality). What you do with aliases is really up to the mediatek platform maintainers, but I think if it were my platform I would just not bother. > I should also think about some way we can avoid similar bindings > symbol naming mishaps in the future. >=20 > Thank you for pointing me in the right direction with regards to > the binding! >=20 > Kind regards, > Nicolas Frattaroli >=20 > > Reviewed-by: Conor Dooley > > pw-bot: not-applicable --LhPY1uIXOXYzwQC0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaP6f6AAKCRB4tDGHoIJi 0lVoAQDVEcmFlZDGe0sLSSI/vhJc1fCDdip8vWj9q3rZ4BUI+gEAyI4wOcjukunf BlHSEe6kYAuozj/qCFBWrR+C47CjOwk= =xrOe -----END PGP SIGNATURE----- --LhPY1uIXOXYzwQC0--