From: Krzysztof Kozlowski <krzk@kernel.org>
To: Joan-Na-adi <joan.na.devcode@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Joan Na <joan.na@analog.com>
Subject: Re: [PATCH v5 1/2] regulator: dt-bindings: Add MAX77675 regulator binding
Date: Wed, 29 Oct 2025 06:52:48 +0100 [thread overview]
Message-ID: <20251029-festive-solemn-mouse-c7a3cd@kuoka> (raw)
In-Reply-To: <20251029023253.150257-2-joan.na@analog.com>
On Wed, Oct 29, 2025 at 11:32:52AM +0900, Joan-Na-adi wrote:
> From: Joan Na <joan.na@analog.com>
>
> Add device tree binding YAML schema for the Maxim MAX77675 PMIC regulator.
> This defines the node properties and supported regulator names for use
> in device tree sources.
My comments form v3 were still not applied. I pointed out this at v4.
You still did not reply to comments. Did not implement them, either.
<form letter>
This is a friendly reminder during the review process.
It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.
Thank you.
</form letter>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-29 5:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 2:32 [PATCH v5 0/2] Add support for MAX77675 device Joan-Na-adi
2025-10-29 2:32 ` [PATCH v5 1/2] regulator: dt-bindings: Add MAX77675 regulator binding Joan-Na-adi
2025-10-29 5:52 ` Krzysztof Kozlowski [this message]
2025-10-31 11:24 ` Joan Na
2025-10-29 2:32 ` [PATCH v5 2/2] regulator: max77675: Add MAX77675 regulator driver Joan-Na-adi
2025-10-29 9:55 ` Nuno Sá
2025-11-03 2:45 ` Joan Na
2025-11-03 11:04 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251029-festive-solemn-mouse-c7a3cd@kuoka \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joan.na.devcode@gmail.com \
--cc=joan.na@analog.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox