From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
Cc: "Rob Herring (Arm)" <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
trilok.soni@oss.qualcomm.com,
Bjorn Andersson <andersson@kernel.org>,
yijie.yang@oss.qualcomm.com, linux-kernel@vger.kernel.org,
Manivannan Sadhasivam <mani@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Sibi Sankar <sibi.sankar@oss.qualcomm.com>,
aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v2 3/7] dt-bindings: remoteproc: qcom,pas: Document pas for SoCCP on Kaanapali and Glymur platforms
Date: Thu, 30 Oct 2025 07:24:52 +0100 [thread overview]
Message-ID: <20251030-innocent-wildebeest-of-persistence-f79aa7@kuoka> (raw)
In-Reply-To: <554b2053-db21-46fa-b5b0-3d548c1e182d@oss.qualcomm.com>
On Thu, Oct 30, 2025 at 10:10:55AM +0800, Jingyi Wang wrote:
>
>
> On 10/29/2025 7:28 PM, Rob Herring (Arm) wrote:
> >
> > On Wed, 29 Oct 2025 01:05:41 -0700, Jingyi Wang wrote:
> >> Document the component used to boot SoCCP on Kaanapali SoC and add
> >> compatible for Glymur SoCCP which could fallback to Kaanapali. Extend
> >> the "qcom,smem-states" and "qcom,smem-state-names" properties and
> >> add conditions for the "interrupts" and "interrupt-names" properties
> >> in the pas-common.
> >>
> >> Co-developed-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
> >> Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
> >> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> >> ---
> >> .../remoteproc/qcom,kaanapali-soccp-pas.yaml | 134 +++++++++++++++++++++
> >> .../bindings/remoteproc/qcom,pas-common.yaml | 83 +++++++++----
> >> 2 files changed, 194 insertions(+), 23 deletions(-)
> >>
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > Lexical error: Documentation/devicetree/bindings/remoteproc/qcom,kaanapali-soccp-pas.example.dts:67.46-62 Unexpected 'IPCC_MPROC_SOCCP'
> > Lexical error: Documentation/devicetree/bindings/remoteproc/qcom,kaanapali-soccp-pas.example.dts:70.33-49 Unexpected 'IPCC_MPROC_SOCCP'
> > FATAL ERROR: Syntax error parsing input tree
> > make[2]: *** [scripts/Makefile.dtbs:132: Documentation/devicetree/bindings/remoteproc/qcom,kaanapali-soccp-pas.example.dtb] Error 1
> > make[2]: *** Waiting for unfinished jobs....
> > make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1547: dt_binding_check] Error 2
> > make: *** [Makefile:248: __sub-make] Error 2
> >
> > doc reference errors (make refcheckdocs):
> >
> > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251029-knp-remoteproc-v2-3-6c81993b52ea@oss.qualcomm.com
> >
> > The base for the series is generally the latest rc1. A different dependency
> > should be noted in *this* patch.
> >
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > date:
> >
> > pip3 install dtschema --upgrade
> >
> > Please check and re-submit after running the above command yourself. Note
> > that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> > your schema. However, it must be unset to test all examples with your schema.
> >
>
> Will add dependency in next version for the include files in example.
Which would make it impossible to merge. Please read internal guideline
because this problem happened multiple times and was already explained
that many times, so for sure it is documented internally.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-30 6:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 8:05 [PATCH v2 0/7] Add initial remoteproc support for Kaanapali and Glymur SoCs Jingyi Wang
2025-10-29 8:05 ` [PATCH v2 1/7] dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali ADSP Jingyi Wang
2025-10-29 8:05 ` [PATCH v2 2/7] dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali CDSP Jingyi Wang
2025-10-29 8:05 ` [PATCH v2 3/7] dt-bindings: remoteproc: qcom,pas: Document pas for SoCCP on Kaanapali and Glymur platforms Jingyi Wang
2025-10-29 11:28 ` Rob Herring (Arm)
2025-10-30 2:10 ` Jingyi Wang
2025-10-30 6:24 ` Krzysztof Kozlowski [this message]
2025-10-29 13:22 ` Rob Herring
2025-10-30 7:44 ` Jingyi Wang
2025-10-30 6:27 ` Krzysztof Kozlowski
2025-10-30 7:50 ` Jingyi Wang
2025-10-29 8:05 ` [PATCH v2 4/7] remoteproc: qcom: pas: Add late attach support for subsystems Jingyi Wang
2025-10-29 10:03 ` Stephan Gerhold
2025-10-31 9:03 ` Aiqun(Maria) Yu
2025-10-29 10:09 ` Aiqun(Maria) Yu
2025-11-01 9:53 ` kernel test robot
2025-11-01 17:49 ` kernel test robot
2025-11-01 18:34 ` Bjorn Andersson
2025-10-29 8:05 ` [PATCH v2 5/7] remoteproc: qcom_q6v5_pas: Add SoCCP node on Kaanapali Jingyi Wang
2025-10-29 8:05 ` [PATCH v2 6/7] dt-bindings: remoteproc: qcom,sm8550-pas: Document Glymur ADSP Jingyi Wang
2025-10-29 11:28 ` Rob Herring (Arm)
2025-10-29 13:23 ` Rob Herring
2025-10-29 13:28 ` Rob Herring
2025-10-29 8:05 ` [PATCH v2 7/7] dt-bindings: remoteproc: qcom,sm8550-pas: Document Glymur CDSP Jingyi Wang
2025-10-29 11:28 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251030-innocent-wildebeest-of-persistence-f79aa7@kuoka \
--to=krzk@kernel.org \
--cc=aiqun.yu@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jingyi.wang@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=robh@kernel.org \
--cc=sibi.sankar@oss.qualcomm.com \
--cc=tingwei.zhang@oss.qualcomm.com \
--cc=trilok.soni@oss.qualcomm.com \
--cc=yijie.yang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).