Re: [PATCH v6 09/11] arm64: dts: mediatek: Add MT6319 PMIC Support

Conor Dooley
2025-10-30T19:34:53Z

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]

On Thu, Oct 30, 2025 at 09:44:41PM +0800, Jack Hsu wrote:
> Add support for MediaTek MT6319 PMIC IC
>
> Signed-off-by: Jack Hsu <jh.hsu@mediatek.com>
> ---
> arch/arm64/boot/dts/mediatek/mt6319.dtsi | 66 ++++++++++++++++++++++++
> 1 file changed, 66 insertions(+)
> create mode 100644 arch/arm64/boot/dts/mediatek/mt6319.dtsi
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt6319.dtsi b/arch/arm64/boot/dts/mediatek/mt6319.dtsi
> new file mode 100644
> index 000000000000..8b2386547508
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt6319.dtsi
> @@ -0,0 +1,66 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright (c) 2025 MediaTek Inc.
> + */
> +#include <dt-bindings/spmi/spmi.h>
> +
> +&spmi {
> + mt6319_7: mt6319@7 {

Shouldn't this be something like "pmic@" or "regulator@"? mt6319 is not
a type of device. The binding example uses pmic.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]