Re: [PATCH v6 00/11] Add mt8189 dts evaluation board and Makefile

Conor Dooley
2025-11-05T18:48:40Z

[-- Attachment #1: Type: text/plain, Size: 1935 bytes --]

On Wed, Nov 05, 2025 at 07:06:50AM +0000, Jh Hsu (許希孜) wrote:
> On Thu, 2025-10-30 at 19:49 +0000, Conor Dooley wrote:
> > On Thu, Oct 30, 2025 at 09:44:32PM +0800, Jack Hsu wrote:
> > > In this patch series,
> > > we add Mediatek MT8189 evaluation board dts, dtsi and Makefile,
> > > and also related dt-binding documents.
> > > Jack Hsu (11):
> > >   dt-bindings: arm: Add compatible for MediaTek MT8189
> > >   dt-bindings: iio: adc: Support MediaTek MT8189 evb board auxadc
> > >   dt-bindings: nvmem: Support MediaTek MT8189 evb board efuse
> > >   dt-bindings: pwm: Support MediaTek MT8189 evb board disp-pwm
> > >   dt-bindings: serial: Support MediaTek MT8189 evb board uart
> > >   dt-bindings: timer: Support MediaTek MT8189 evb board timer
> > >   dt-bindings: usb: Support MediaTek MT8189 evb board xhci
> > >   dt-bindings: watchdog: Support MediaTek MT8189 evb board wdt
> >
> > Please drop mention of the evb from all of these commit messages. The
> > compatible has nothing to do with the evb board, it's going to be
> > common
> > across all boards using an mt8189.
> >
> > >   arm64: dts: mediatek: Add MT6319 PMIC Support
> > >   arm64: dts: mediatek: add properties for MT6359
> >
> > Wait a minute, what are these two patches even doing in this series
> > in
> > the first place, when it is otherwise about the mt8189?
>
> mt8189 evb board include mt63xx.dtsi,
> and the dtsi files maybe for other boards in the future,
> ie. mt8189/81xx custom/OEM/ODM boards.
> Should i separate those two patches as a new patch series ?

They seemed unrelated to your series and poor quality to the point that
they looked like an accidental inclusions, given there's no mention of
them in the cover letter. Since they do appear to be related, sure keep
them. That said, the "add properties for MT6359" patch is in need of
major rework, so you'll have to rework it.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]