From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Peter Griffin" <peter.griffin@linaro.org>,
"André Draszik" <andre.draszik@linaro.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
semen.protsenko@linaro.org, willmcvicker@google.com,
kernel-team@android.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Tudor Ambarus <tudor.ambarus@linaro.org>
Subject: [PATCH 02/11] soc: samsung: exynos-chipid: use a local dev variable
Date: Fri, 31 Oct 2025 12:56:01 +0000 [thread overview]
Message-ID: <20251031-gs101-chipid-v1-2-d78d1076b210@linaro.org> (raw)
In-Reply-To: <20251031-gs101-chipid-v1-0-d78d1076b210@linaro.org>
Use a local variable for struct device to avoid dereferencing.
Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
---
drivers/soc/samsung/exynos-chipid.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c
index 0f9f83a006795df08dae556ef37c2b78bd599ef5..d3b4b5508e0c808ee9f7b0039073ef57915d60fc 100644
--- a/drivers/soc/samsung/exynos-chipid.c
+++ b/drivers/soc/samsung/exynos-chipid.c
@@ -109,16 +109,17 @@ static int exynos_chipid_probe(struct platform_device *pdev)
const struct exynos_chipid_variant *drv_data;
struct exynos_chipid_info soc_info;
struct soc_device_attribute *soc_dev_attr;
+ struct device *dev = &pdev->dev;
struct soc_device *soc_dev;
struct device_node *root;
struct regmap *regmap;
int ret;
- drv_data = of_device_get_match_data(&pdev->dev);
+ drv_data = of_device_get_match_data(dev);
if (!drv_data)
return -EINVAL;
- regmap = device_node_to_regmap(pdev->dev.of_node);
+ regmap = device_node_to_regmap(dev->of_node);
if (IS_ERR(regmap))
return PTR_ERR(regmap);
@@ -126,8 +127,7 @@ static int exynos_chipid_probe(struct platform_device *pdev)
if (ret < 0)
return ret;
- soc_dev_attr = devm_kzalloc(&pdev->dev, sizeof(*soc_dev_attr),
- GFP_KERNEL);
+ soc_dev_attr = devm_kzalloc(dev, sizeof(*soc_dev_attr), GFP_KERNEL);
if (!soc_dev_attr)
return -ENOMEM;
@@ -137,8 +137,8 @@ static int exynos_chipid_probe(struct platform_device *pdev)
of_property_read_string(root, "model", &soc_dev_attr->machine);
of_node_put(root);
- soc_dev_attr->revision = devm_kasprintf(&pdev->dev, GFP_KERNEL,
- "%x", soc_info.revision);
+ soc_dev_attr->revision = devm_kasprintf(dev, GFP_KERNEL, "%x",
+ soc_info.revision);
if (!soc_dev_attr->revision)
return -ENOMEM;
soc_dev_attr->soc_id = product_id_to_soc_id(soc_info.product_id);
@@ -152,13 +152,13 @@ static int exynos_chipid_probe(struct platform_device *pdev)
if (IS_ERR(soc_dev))
return PTR_ERR(soc_dev);
- ret = exynos_asv_init(&pdev->dev, regmap);
+ ret = exynos_asv_init(dev, regmap);
if (ret)
goto err;
platform_set_drvdata(pdev, soc_dev);
- dev_info(&pdev->dev, "Exynos: CPU[%s] PRO_ID[0x%x] REV[0x%x] Detected\n",
+ dev_info(dev, "Exynos: CPU[%s] PRO_ID[0x%x] REV[0x%x] Detected\n",
soc_dev_attr->soc_id, soc_info.product_id, soc_info.revision);
return 0;
--
2.51.1.930.gacf6e81ea2-goog
next prev parent reply other threads:[~2025-10-31 12:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 12:55 [PATCH 00/11] soc: samsung: exynos-chipid: add gs101 support Tudor Ambarus
2025-10-31 12:56 ` [PATCH 01/11] dt-bindings: hwinfo: samsung,exynos-chipid: add google,gs101 compatible Tudor Ambarus
2025-11-03 9:58 ` Krzysztof Kozlowski
2025-10-31 12:56 ` Tudor Ambarus [this message]
2025-11-03 10:02 ` (subset) [PATCH 02/11] soc: samsung: exynos-chipid: use a local dev variable Krzysztof Kozlowski
2025-10-31 12:56 ` [PATCH 03/11] soc: samsung: exynos-chipid: use heap allocated driver data Tudor Ambarus
2025-11-03 10:03 ` Krzysztof Kozlowski
2025-10-31 12:56 ` [PATCH 04/11] soc: samsung: exynos-chipid: refer to match->data as data Tudor Ambarus
2025-11-03 10:05 ` Krzysztof Kozlowski
2025-10-31 12:56 ` [PATCH 05/11] soc: samsung: exynos-chipid: introduce match_data->get_chipid_info() Tudor Ambarus
2025-11-03 10:15 ` Krzysztof Kozlowski
2025-10-31 12:56 ` [PATCH 06/11] soc: samsung: exynos-chipid: make asv_init opt-in Tudor Ambarus
2025-10-31 12:56 ` [PATCH 07/11] soc: samsung: exynos-chipid: add support for google,gs101-chipid Tudor Ambarus
2025-10-31 12:56 ` [PATCH 08/11] soc: samsung: exynos-chipid: prepend exynos_ to a method's name Tudor Ambarus
2025-10-31 12:56 ` [PATCH 09/11] soc: samsung: exynos-chipid: downgrade dev_info to dev_dbg for soc info Tudor Ambarus
2025-10-31 12:56 ` [PATCH 10/11] arm64: dts: exynos: gs101: add the chipid node Tudor Ambarus
2025-11-03 10:18 ` Krzysztof Kozlowski
2025-11-03 10:50 ` Tudor Ambarus
2025-11-03 11:01 ` Krzysztof Kozlowski
2025-11-03 11:26 ` Tudor Ambarus
2025-11-04 7:14 ` Krzysztof Kozlowski
2025-11-10 9:28 ` Tudor Ambarus
2025-10-31 12:56 ` [PATCH 11/11] arm64: defconfig: enable Samsung Exynos chipid driver Tudor Ambarus
2025-11-03 10:14 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251031-gs101-chipid-v1-2-d78d1076b210@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).