devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1 0/3] arm64: dts: imx8x-colibri: add additional functionality
@ 2025-10-31 12:49 max.oss.09
  2025-10-31 12:49 ` [PATCH v1 1/3] arm64: dts: colibri-imx8x: Add backlight max.oss.09
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: max.oss.09 @ 2025-10-31 12:49 UTC (permalink / raw)
  To: Max Krummenacher
  Cc: Conor Dooley, Fabio Estevam, Krzysztof Kozlowski,
	Pengutronix Kernel Team, Rob Herring, Sascha Hauer, Shawn Guo,
	devicetree, imx, linux-arm-kernel, linux-kernel

From: Max Krummenacher <max.krummenacher@toradex.com>

Provide a pwm-backlight.
Provide the 32kHz Wi-Fi clock used during low-power operation.
Configure CMA from the device tree.


Max Krummenacher (1):
  arm64: dts: colibri-imx8x: Add wi-fi 32kHz clock

Philippe Schenker (2):
  arm64: dts: colibri-imx8x: Add backlight
  arm64: dts: colibri-imx8x: Add cma memory

 .../boot/dts/freescale/imx8x-colibri.dtsi     | 29 ++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)

-- 
2.42.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v1 1/3] arm64: dts: colibri-imx8x: Add backlight
  2025-10-31 12:49 [PATCH v1 0/3] arm64: dts: imx8x-colibri: add additional functionality max.oss.09
@ 2025-10-31 12:49 ` max.oss.09
  2025-10-31 12:49 ` [PATCH v1 2/3] arm64: dts: colibri-imx8x: Add wi-fi 32kHz clock max.oss.09
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 7+ messages in thread
From: max.oss.09 @ 2025-10-31 12:49 UTC (permalink / raw)
  To: Max Krummenacher
  Cc: Philippe Schenker, Conor Dooley, Fabio Estevam,
	Krzysztof Kozlowski, Pengutronix Kernel Team, Rob Herring,
	Sascha Hauer, Shawn Guo, devicetree, imx, linux-arm-kernel,
	linux-kernel

From: Philippe Schenker <philippe.schenker@toradex.com>

Add a backlight node to colibri-imx8x. The node can be enabled from
an overlay once display output is implemented.

Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
---

 arch/arm64/boot/dts/freescale/imx8x-colibri.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8x-colibri.dtsi b/arch/arm64/boot/dts/freescale/imx8x-colibri.dtsi
index 8e9e841cc828..318fe4db1b64 100644
--- a/arch/arm64/boot/dts/freescale/imx8x-colibri.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8x-colibri.dtsi
@@ -3,7 +3,21 @@
  * Copyright 2019 Toradex
  */
 
+#include "dt-bindings/pwm/pwm.h"
+
 / {
+	backlight: backlight {
+		compatible = "pwm-backlight";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_gpio_bl_on>;
+		brightness-levels = <0 45 63 88 119 158 203 255>;
+		default-brightness-level = <4>;
+		enable-gpios = <&lsio_gpio3 12 GPIO_ACTIVE_HIGH>; /* Colibri BL_ON */
+		power-supply = <&reg_module_3v3>;
+		pwms = <&adma_pwm 0 6666667 PWM_POLARITY_INVERTED>;
+		status = "disabled";
+	};
+
 	chosen {
 		stdout-path = &lpuart3;
 	};
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH v1 2/3] arm64: dts: colibri-imx8x: Add wi-fi 32kHz clock
  2025-10-31 12:49 [PATCH v1 0/3] arm64: dts: imx8x-colibri: add additional functionality max.oss.09
  2025-10-31 12:49 ` [PATCH v1 1/3] arm64: dts: colibri-imx8x: Add backlight max.oss.09
@ 2025-10-31 12:49 ` max.oss.09
  2025-10-31 18:27   ` Frank Li
  2025-10-31 12:49 ` [PATCH v1 3/3] arm64: dts: colibri-imx8x: Add cma memory max.oss.09
  2025-12-30 10:25 ` [PATCH v1 0/3] arm64: dts: imx8x-colibri: add additional functionality Francesco Dolcini
  3 siblings, 1 reply; 7+ messages in thread
From: max.oss.09 @ 2025-10-31 12:49 UTC (permalink / raw)
  To: Max Krummenacher
  Cc: Conor Dooley, Fabio Estevam, Krzysztof Kozlowski,
	Pengutronix Kernel Team, Rob Herring, Sascha Hauer, Shawn Guo,
	devicetree, imx, linux-arm-kernel, linux-kernel

From: Max Krummenacher <max.krummenacher@toradex.com>

The Wi-Fi module requires a 32kHz clock to support Wi-Fi/BT low power
operation.
Setting the pinmuxing option on the connected pin to 32kHz is all
needed to generated the signal.

Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
---

 arch/arm64/boot/dts/freescale/imx8x-colibri.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8x-colibri.dtsi b/arch/arm64/boot/dts/freescale/imx8x-colibri.dtsi
index 318fe4db1b64..32bca4c6f37e 100644
--- a/arch/arm64/boot/dts/freescale/imx8x-colibri.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8x-colibri.dtsi
@@ -490,7 +490,7 @@ &mu1_m0 {
 /* On-module PCIe for Wi-Fi */
 &pcieb {
 	pinctrl-names = "default";
-	pinctrl-0 = <&pinctrl_pcieb>;
+	pinctrl-0 = <&pinctrl_pcieb>, <&pinctrl_wifi>;
 	phys = <&hsio_phy 0 PHY_TYPE_PCIE 0>;
 	phy-names = "pcie-phy";
 	reset-gpios = <&lsio_gpio4 0 GPIO_ACTIVE_LOW>;
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH v1 3/3] arm64: dts: colibri-imx8x: Add cma memory
  2025-10-31 12:49 [PATCH v1 0/3] arm64: dts: imx8x-colibri: add additional functionality max.oss.09
  2025-10-31 12:49 ` [PATCH v1 1/3] arm64: dts: colibri-imx8x: Add backlight max.oss.09
  2025-10-31 12:49 ` [PATCH v1 2/3] arm64: dts: colibri-imx8x: Add wi-fi 32kHz clock max.oss.09
@ 2025-10-31 12:49 ` max.oss.09
  2025-12-30 10:25 ` [PATCH v1 0/3] arm64: dts: imx8x-colibri: add additional functionality Francesco Dolcini
  3 siblings, 0 replies; 7+ messages in thread
From: max.oss.09 @ 2025-10-31 12:49 UTC (permalink / raw)
  To: Max Krummenacher
  Cc: Philippe Schenker, Conor Dooley, Fabio Estevam,
	Krzysztof Kozlowski, Pengutronix Kernel Team, Rob Herring,
	Sascha Hauer, Shawn Guo, devicetree, imx, linux-arm-kernel,
	linux-kernel

From: Philippe Schenker <philippe.schenker@toradex.com>

Add CMA in device tree and set its size to 416MiB for all
Colibri iMX8X.
The size is tuned to be enough to play full HD video using gst-play
and to fit in the SKU with the lowest amount of RAM (1GB).

Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>

---

 arch/arm64/boot/dts/freescale/imx8x-colibri.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8x-colibri.dtsi b/arch/arm64/boot/dts/freescale/imx8x-colibri.dtsi
index 32bca4c6f37e..d4bf30d91d69 100644
--- a/arch/arm64/boot/dts/freescale/imx8x-colibri.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8x-colibri.dtsi
@@ -86,6 +86,19 @@ reg_usbh_vbus: regulator-usbh-vbus {
 		regulator-name = "usbh_vbus";
 	};
 
+	reserved-memory {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		linux,cma {
+			compatible = "shared-dma-pool";
+			linux,cma-default;
+			reusable;
+			size = <0 0x1a000000>;
+		};
+	};
+
 	sound-card {
 		compatible = "simple-audio-card";
 		simple-audio-card,bitclock-master = <&dailink_master>;
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v1 2/3] arm64: dts: colibri-imx8x: Add wi-fi 32kHz clock
  2025-10-31 12:49 ` [PATCH v1 2/3] arm64: dts: colibri-imx8x: Add wi-fi 32kHz clock max.oss.09
@ 2025-10-31 18:27   ` Frank Li
  0 siblings, 0 replies; 7+ messages in thread
From: Frank Li @ 2025-10-31 18:27 UTC (permalink / raw)
  To: max.oss.09
  Cc: Max Krummenacher, Conor Dooley, Fabio Estevam,
	Krzysztof Kozlowski, Pengutronix Kernel Team, Rob Herring,
	Sascha Hauer, Shawn Guo, devicetree, imx, linux-arm-kernel,
	linux-kernel

On Fri, Oct 31, 2025 at 01:49:42PM +0100, max.oss.09@gmail.com wrote:
> From: Max Krummenacher <max.krummenacher@toradex.com>
>
> The Wi-Fi module requires a 32kHz clock to support Wi-Fi/BT low power
> operation.

Need extra space line between paragraph.

Frank

> Setting the pinmuxing option on the connected pin to 32kHz is all
> needed to generated the signal.
>
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
> ---
>
>  arch/arm64/boot/dts/freescale/imx8x-colibri.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8x-colibri.dtsi b/arch/arm64/boot/dts/freescale/imx8x-colibri.dtsi
> index 318fe4db1b64..32bca4c6f37e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8x-colibri.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8x-colibri.dtsi
> @@ -490,7 +490,7 @@ &mu1_m0 {
>  /* On-module PCIe for Wi-Fi */
>  &pcieb {
>  	pinctrl-names = "default";
> -	pinctrl-0 = <&pinctrl_pcieb>;
> +	pinctrl-0 = <&pinctrl_pcieb>, <&pinctrl_wifi>;
>  	phys = <&hsio_phy 0 PHY_TYPE_PCIE 0>;
>  	phy-names = "pcie-phy";
>  	reset-gpios = <&lsio_gpio4 0 GPIO_ACTIVE_LOW>;
> --
> 2.42.0
>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v1 0/3] arm64: dts: imx8x-colibri: add additional functionality
  2025-10-31 12:49 [PATCH v1 0/3] arm64: dts: imx8x-colibri: add additional functionality max.oss.09
                   ` (2 preceding siblings ...)
  2025-10-31 12:49 ` [PATCH v1 3/3] arm64: dts: colibri-imx8x: Add cma memory max.oss.09
@ 2025-12-30 10:25 ` Francesco Dolcini
  2025-12-31  2:13   ` Shawn Guo
  3 siblings, 1 reply; 7+ messages in thread
From: Francesco Dolcini @ 2025-12-30 10:25 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Max Krummenacher, Conor Dooley, Fabio Estevam,
	Krzysztof Kozlowski, Pengutronix Kernel Team, Rob Herring,
	Sascha Hauer, Shawn Guo, devicetree, imx, linux-arm-kernel,
	linux-kernel, max.oss.09

Hello Shawn,

On Fri, Oct 31, 2025 at 01:49:40PM +0100, max.oss.09@gmail.com wrote:
> Provide a pwm-backlight.
> Provide the 32kHz Wi-Fi clock used during low-power operation.
> Configure CMA from the device tree.

This series was not applied, any concern? Anything to change?

Thanks,
Francesco



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v1 0/3] arm64: dts: imx8x-colibri: add additional functionality
  2025-12-30 10:25 ` [PATCH v1 0/3] arm64: dts: imx8x-colibri: add additional functionality Francesco Dolcini
@ 2025-12-31  2:13   ` Shawn Guo
  0 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2025-12-31  2:13 UTC (permalink / raw)
  To: Francesco Dolcini
  Cc: Max Krummenacher, Conor Dooley, Fabio Estevam,
	Krzysztof Kozlowski, Pengutronix Kernel Team, Rob Herring,
	Sascha Hauer, devicetree, imx, linux-arm-kernel, linux-kernel,
	max.oss.09

On Tue, Dec 30, 2025 at 11:25:25AM +0100, Francesco Dolcini wrote:
> Hello Shawn,
> 
> On Fri, Oct 31, 2025 at 01:49:40PM +0100, max.oss.09@gmail.com wrote:
> > Provide a pwm-backlight.
> > Provide the 32kHz Wi-Fi clock used during low-power operation.
> > Configure CMA from the device tree.
> 
> This series was not applied, any concern? Anything to change?

Sorry for missing it.  Applied, thanks!

Shawn

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2025-12-31  2:13 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-31 12:49 [PATCH v1 0/3] arm64: dts: imx8x-colibri: add additional functionality max.oss.09
2025-10-31 12:49 ` [PATCH v1 1/3] arm64: dts: colibri-imx8x: Add backlight max.oss.09
2025-10-31 12:49 ` [PATCH v1 2/3] arm64: dts: colibri-imx8x: Add wi-fi 32kHz clock max.oss.09
2025-10-31 18:27   ` Frank Li
2025-10-31 12:49 ` [PATCH v1 3/3] arm64: dts: colibri-imx8x: Add cma memory max.oss.09
2025-12-30 10:25 ` [PATCH v1 0/3] arm64: dts: imx8x-colibri: add additional functionality Francesco Dolcini
2025-12-31  2:13   ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).