[PATCH v3 0/2] iio: proximity: update Lidar-lite v2 and create v3

[PATCH v3 0/2] iio: proximity: update Lidar-lite v2 and create v3

[Rodrigo Gobbi]

This series moves the Lidar v2 binding from trivial to a dedicated place.
It also adds the v3, which was not described yet, in the same place since
it's the same hardware and it is already supported by the driver.
---
Hi, all,
Very few changes in this v3. At the v2 link, there was a discussion about
the PWM output pin and the current support of that. It was suggested to
not add that pin here, at least for now.
Tks and regards.

Changelog:
v3: split things in a patchset
    replace power-gpios to powerdown-gpios
    user proper lidar node name
v2: https://lore.kernel.org/all/20250801224112.135918-1-rodrigo.gobbi.7@gmail.com/
v1: https://lore.kernel.org/all/20250701223341.36835-1-rodrigo.gobbi.7@gmail.com/#t
---
Rodrigo Gobbi (2):
  dt-bindings: iio: proximity: Remove Lidar-lite-v2 from trivial
  dt-bindings: iio: proximity: Add Lidar-lite-v2 and v3

 .../proximity/pulsedlight,lidar-lite-v2.yaml  | 54 +++++++++++++++++++
 .../devicetree/bindings/trivial-devices.yaml  |  2 -
 2 files changed, 54 insertions(+), 2 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/iio/proximity/pulsedlight,lidar-lite-v2.yaml

-- 
2.48.1

[PATCH v3 1/2] dt-bindings: iio: proximity: Remove Lidar-lite-v2 from trivial

[Rodrigo Gobbi]

The lidar-lite-v2 IC is not a trivial device because it has a few more
pins like power-en, mode ctrl and supplies.

Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 2eff6f274302..e344613aa265 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -357,8 +357,6 @@ properties:
           - onnn,adt7462
             # 48-Lane, 12-Port PCI Express Gen 2 (5.0 GT/s) Switch
           - plx,pex8648
-            # Pulsedlight LIDAR range-finding sensor
-          - pulsedlight,lidar-lite-v2
             # Renesas HS3001 Temperature and Relative Humidity Sensors
           - renesas,hs3001
             # Renesas ISL29501 time-of-flight sensor
-- 
2.48.1

[PATCH v3 2/2] dt-bindings: iio: proximity: Add Lidar-lite-v2 and v3

[Rodrigo Gobbi]

Since v2 is not a trivial device, add it to a dedicated place. The v3 is
similar to the v2 version, so add it as a fallback to the v2. Both versions
are already supported by the driver.

Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
---
 .../proximity/pulsedlight,lidar-lite-v2.yaml  | 54 +++++++++++++++++++
 1 file changed, 54 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/proximity/pulsedlight,lidar-lite-v2.yaml

diff --git a/Documentation/devicetree/bindings/iio/proximity/pulsedlight,lidar-lite-v2.yaml b/Documentation/devicetree/bindings/iio/proximity/pulsedlight,lidar-lite-v2.yaml
new file mode 100644
index 000000000000..21c9239c64dc
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/proximity/pulsedlight,lidar-lite-v2.yaml
@@ -0,0 +1,54 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/proximity/pulsedlight,lidar-lite-v2.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Pulsedlight LIDAR-Lite v2 range-finding sensor
+
+maintainers:
+  - Matt Ranostay <mranostay@gmail.com>
+
+description: |
+  Support for LIDAR_Lite v2 and v3 laser rangefinders. These devices
+  can use a simple I2C communication bus or can operate in a PWM mode using a
+  mode control pin to trigger acquisitions and return the measured distance.
+  It also have a power enable pin, which can be used to shut off the device.
+
+properties:
+  compatible:
+    oneOf:
+      - items:
+          - enum:
+              - grmn,lidar-lite-v3
+          - const: pulsedlight,lidar-lite-v2
+      - const: pulsedlight,lidar-lite-v2
+
+  reg:
+    maxItems: 1
+
+  powerdown-gpios:
+    description: GPIO that can be driven low to shut off power to the device.
+    maxItems: 1
+
+  vdd-supply: true
+
+required:
+  - compatible
+  - reg
+  - vdd-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        lidar@62 {
+            compatible = "grmn,lidar-lite-v3", "pulsedlight,lidar-lite-v2";
+            reg = <0x62>;
+            vdd-supply = <&vdd_5v0>;
+        };
+    };
+...
-- 
2.48.1

Re: [PATCH v3 0/2] iio: proximity: update Lidar-lite v2 and create v3

[Krzysztof Kozlowski]

On 02/11/2025 23:10, Rodrigo Gobbi wrote:
> This series moves the Lidar v2 binding from trivial to a dedicated place.
> It also adds the v3, which was not described yet, in the same place since
> it's the same hardware and it is already supported by the driver.
> ---
> Hi, all,
> Very few changes in this v3. At the v2 link, there was a discussion about
> the PWM output pin and the current support of that. It was suggested to
> not add that pin here, at least for now.
> Tks and regards.
> 
> Changelog:
> v3: split things in a patchset

Hm? Why. That's non-bisectable now



Best regards,
Krzysztof

Re: [PATCH v3 1/2] dt-bindings: iio: proximity: Remove Lidar-lite-v2 from trivial

[Krzysztof Kozlowski]

On 02/11/2025 23:10, Rodrigo Gobbi wrote:
> The lidar-lite-v2 IC is not a trivial device because it has a few more
> pins like power-en, mode ctrl and supplies.
> 
> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 --
>  1 file changed, 2 deletions(-)


That's not a separate commit.

Best regards,
Krzysztof

Re: [PATCH v3 2/2] dt-bindings: iio: proximity: Add Lidar-lite-v2 and v3

[Krzysztof Kozlowski]

On 02/11/2025 23:10, Rodrigo Gobbi wrote:
> Since v2 is not a trivial device, add it to a dedicated place. The v3 is

What is v2 and v3? This patchset is v3, don't refer to it in the commit
msg. If you speak about devices then make it obvious. How anyone going
through `git log` can figure out what is v2. Your patch mentions some v2
and v3 but these are different companies, so somehow completely
different products?


> similar to the v2 version, so add it as a fallback to the v2. Both versions
> are already supported by the driver.

Best regards,
Krzysztof

Re: [PATCH v3 2/2] dt-bindings: iio: proximity: Add Lidar-lite-v2 and v3

[Rodrigo Gobbi]

On 11/3/25 05:04, Krzysztof Kozlowski wrote:
> On 02/11/2025 23:10, Rodrigo Gobbi wrote:
>> Since v2 is not a trivial device, add it to a dedicated place. The v3 is
> 
> What is v2 and v3? This patchset is v3, don't refer to it in the commit
> msg. If you speak about devices then make it obvious. How anyone going
> through `git log` can figure out what is v2. Your patch mentions some v2
> and v3 but these are different companies, so somehow completely
> different products?

Sorry for the commit msg, I`ll make it more clear in this case. About different companies, yes,
that is true. It turns out that this is a "special" case because lidar-lite-v2
chipset was manufactured by Pulsedlight vendor. In other hand, the new version from
it, v3, was manufactured by Garmin, which acquired the Pulsedlight.

In previous versions of this patch I`ve reviewed both datasheets, and the pin-out 
is almost the same, that`s why I`ve added in the same binding.

Probably I`ll send a new patch version without using a patchset as pointed here and fixing the
subject/commit msg to make it more clear.

Feel free to suggest anything else or other concerns.
Tks and regards!!!