From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Robert Marko <robimarko@gmail.com>,
Das Srinagesh <quic_gurus@quicinc.com>,
aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com,
trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: soc: qcom: Add qcom,kaanapali-imem compatible
Date: Tue, 4 Nov 2025 09:16:57 +0100 [thread overview]
Message-ID: <20251104-glaring-rebel-pillbug-a467ca@kuoka> (raw)
In-Reply-To: <20251102-knp-soc-binding-v3-1-11255ec4a535@oss.qualcomm.com>
On Sun, Nov 02, 2025 at 11:25:06PM -0800, Jingyi Wang wrote:
> Document qcom,kaanapali-imem compatible. Kaanapali IMEM is not a syscon or
> simple-mfd, also "reboot reason" is not required on Kaanapali like some
I do not see correlation. Something is not a syscon, so you add a new
generic compatible? No.
> other platforms. So define a common "qcom,imem" binding and fallback to it.
You did not define fallback to it!
...
> + - items:
> + - enum:
> + - qcom,kaanapali-imem
> + - const: qcom,imem
I do not understand what this generic compatible is supposed to express,
not explained in commit msg. Considering this wasn't before, it is a
major and really undesired change. It also makes no sesne. There was no
generic compatible before but "if not syscon" now this must have generic
compatible, what?
NAK
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-04 8:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 7:25 [PATCH v3 0/2] dt-bindings: soc: qcom: Add soc related bindings for Kaanapali Jingyi Wang
2025-11-03 7:25 ` [PATCH v3 1/2] dt-bindings: soc: qcom: Add qcom,kaanapali-imem compatible Jingyi Wang
2025-11-04 3:17 ` Bjorn Andersson
2025-11-04 8:16 ` Krzysztof Kozlowski [this message]
2025-11-04 10:41 ` Aiqun(Maria) Yu
2025-11-04 12:32 ` Konrad Dybcio
2025-11-04 14:26 ` Krzysztof Kozlowski
2025-11-04 14:35 ` Konrad Dybcio
2025-11-04 14:37 ` Krzysztof Kozlowski
2025-11-04 14:38 ` Konrad Dybcio
2025-11-04 14:52 ` Krzysztof Kozlowski
2025-11-04 14:58 ` Konrad Dybcio
2025-11-04 15:02 ` Krzysztof Kozlowski
2025-11-04 15:14 ` Konrad Dybcio
2025-11-06 20:24 ` Bjorn Andersson
2025-11-11 8:29 ` Kathiravan Thirumoorthy
2025-11-11 12:08 ` Aiqun(Maria) Yu
2025-11-11 16:38 ` Kathiravan Thirumoorthy
2025-11-03 7:25 ` [PATCH v3 2/2] dt-bindings: firmware: qcom,scm: Document SCM on Kaanapali SOC Jingyi Wang
2025-11-04 3:53 ` (subset) [PATCH v3 0/2] dt-bindings: soc: qcom: Add soc related bindings for Kaanapali Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251104-glaring-rebel-pillbug-a467ca@kuoka \
--to=krzk@kernel.org \
--cc=aiqun.yu@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jingyi.wang@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_gurus@quicinc.com \
--cc=robh@kernel.org \
--cc=robimarko@gmail.com \
--cc=tingwei.zhang@oss.qualcomm.com \
--cc=trilok.soni@oss.qualcomm.com \
--cc=yijie.yang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).