Re: [PATCH 1/3] dt-bindings: clock: imx6ul-clock: add optional clock enet1_ref_pad

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1916 bytes --]

On Thu, Nov 06, 2025 at 12:57:01PM -0500, Frank Li wrote:
> On Thu, Nov 06, 2025 at 05:44:36PM +0000, Conor Dooley wrote:
> > On Wed, Nov 05, 2025 at 11:55:28AM -0500, Frank Li wrote:
> > > Add optional clock source enet1_ref_pad, which input from ENET ref pad.
> > >
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > >  Documentation/devicetree/bindings/clock/imx6q-clock.yaml  | 4 ++++
> > >  Documentation/devicetree/bindings/clock/imx6ul-clock.yaml | 4 ++++
> > >  2 files changed, 8 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> > > index cd3c04c883df4ab02af29582369757df36269cb6..49475aec22a81ba87048eef588368261cbb38465 100644
> > > --- a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> > > +++ b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> > > @@ -29,20 +29,24 @@ properties:
> > >      const: 1
> > >
> > >    clocks:
> > > +    minItems: 4
> > >      items:
> > >        - description: 24m osc
> > >        - description: 32k osc
> > >        - description: ckih1 clock input
> > >        - description: anaclk1 clock input
> > >        - description: anaclk2 clock input
> > > +      - description: clock input from enet1 ref pad
> > >
> > >    clock-names:
> > > +    minItems: 4
> > >      items:
> > >        - const: osc
> > >        - const: ckil
> > >        - const: ckih1
> > >        - const: anaclk1
> > >        - const: anaclk2
> > > +      - const: enet1_ref_pad
> >
> > I think you could drop the _pad from here, and just make it enet1_ref.
> > Only a suggestion though,
> 
> The old dts already use enet1_ref_pad. But anyway, after I double check
> that it should be enet_ref_pad for 6q, enet1_ref_pad for 6ul.

Okay, cool. You can retain the ack on the new version with the 1
removed from 6q.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]