* [PATCH 0/3] ARM: dts: imx6: cleanup imx6/7 CCM related CHECK_DTBS warnings
@ 2025-11-05 16:55 Frank Li
2025-11-05 16:55 ` [PATCH 1/3] dt-bindings: clock: imx6ul-clock: add optional clock enet1_ref_pad Frank Li
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Frank Li @ 2025-11-05 16:55 UTC (permalink / raw)
To: Abel Vesa, Peng Fan, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam
Cc: linux-clk, imx, devicetree, linux-arm-kernel, linux-kernel,
Frank Li
cleanup imx6/7 CCM related CHECK_DTBS warnings
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Frank Li (3):
dt-bindings: clock: imx6ul-clock: add optional clock enet1_ref_pad
ARM: dts: imx6qdl: add label for system clocks
ARM: dts: imx: add required clocks and clock-names for ccm
.../devicetree/bindings/clock/imx6q-clock.yaml | 4 ++++
.../devicetree/bindings/clock/imx6ul-clock.yaml | 4 ++++
arch/arm/boot/dts/nxp/imx/imx6dl-alti6p.dts | 4 ++--
arch/arm/boot/dts/nxp/imx/imx6dl-eckelmann-ci4x10.dts | 4 ++--
arch/arm/boot/dts/nxp/imx/imx6dl-lanmcu.dts | 4 ++--
arch/arm/boot/dts/nxp/imx/imx6dl-plybas.dts | 4 ++--
arch/arm/boot/dts/nxp/imx/imx6dl-plym2m.dts | 4 ++--
arch/arm/boot/dts/nxp/imx/imx6dl-prtmvt.dts | 4 ++--
arch/arm/boot/dts/nxp/imx/imx6dl-qmx6.dtsi | 5 +++--
arch/arm/boot/dts/nxp/imx/imx6dl-victgo.dts | 4 ++--
arch/arm/boot/dts/nxp/imx/imx6q-prtwd2.dts | 4 ++--
arch/arm/boot/dts/nxp/imx/imx6qdl-skov-cpu.dtsi | 4 ++--
arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi | 18 +++++++++++++++---
13 files changed, 44 insertions(+), 23 deletions(-)
---
base-commit: f8a6148698538647188a0f801f686ff90035a8ca
change-id: 20251104-ccm_dts-504ea501251b
Best regards,
--
Frank Li <Frank.Li@nxp.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/3] dt-bindings: clock: imx6ul-clock: add optional clock enet1_ref_pad
2025-11-05 16:55 [PATCH 0/3] ARM: dts: imx6: cleanup imx6/7 CCM related CHECK_DTBS warnings Frank Li
@ 2025-11-05 16:55 ` Frank Li
2025-11-06 17:44 ` Conor Dooley
2025-11-05 16:55 ` [PATCH 2/3] ARM: dts: imx6qdl: add label for system clocks Frank Li
2025-11-05 16:55 ` [PATCH 3/3] ARM: dts: imx: add required clocks and clock-names for ccm Frank Li
2 siblings, 1 reply; 7+ messages in thread
From: Frank Li @ 2025-11-05 16:55 UTC (permalink / raw)
To: Abel Vesa, Peng Fan, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam
Cc: linux-clk, imx, devicetree, linux-arm-kernel, linux-kernel,
Frank Li
Add optional clock source enet1_ref_pad, which input from ENET ref pad.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Documentation/devicetree/bindings/clock/imx6q-clock.yaml | 4 ++++
Documentation/devicetree/bindings/clock/imx6ul-clock.yaml | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
index cd3c04c883df4ab02af29582369757df36269cb6..49475aec22a81ba87048eef588368261cbb38465 100644
--- a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
@@ -29,20 +29,24 @@ properties:
const: 1
clocks:
+ minItems: 4
items:
- description: 24m osc
- description: 32k osc
- description: ckih1 clock input
- description: anaclk1 clock input
- description: anaclk2 clock input
+ - description: clock input from enet1 ref pad
clock-names:
+ minItems: 4
items:
- const: osc
- const: ckil
- const: ckih1
- const: anaclk1
- const: anaclk2
+ - const: enet1_ref_pad
fsl,pmic-stby-poweroff:
$ref: /schemas/types.yaml#/definitions/flag
diff --git a/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml b/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
index d57e18a210cc1d8a836b50058613dfb0308fbf11..035002721a3b3b65fe67734e13b686b91539f328 100644
--- a/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
@@ -29,18 +29,22 @@ properties:
const: 1
clocks:
+ minItems: 4
items:
- description: 32k osc
- description: 24m osc
- description: ipp_di0 clock input
- description: ipp_di1 clock input
+ - description: clock input from enet1 ref pad
clock-names:
+ minItems: 4
items:
- const: ckil
- const: osc
- const: ipp_di0
- const: ipp_di1
+ - const: enet1_ref_pad
required:
- compatible
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/3] ARM: dts: imx6qdl: add label for system clocks
2025-11-05 16:55 [PATCH 0/3] ARM: dts: imx6: cleanup imx6/7 CCM related CHECK_DTBS warnings Frank Li
2025-11-05 16:55 ` [PATCH 1/3] dt-bindings: clock: imx6ul-clock: add optional clock enet1_ref_pad Frank Li
@ 2025-11-05 16:55 ` Frank Li
2025-11-05 16:55 ` [PATCH 3/3] ARM: dts: imx: add required clocks and clock-names for ccm Frank Li
2 siblings, 0 replies; 7+ messages in thread
From: Frank Li @ 2025-11-05 16:55 UTC (permalink / raw)
To: Abel Vesa, Peng Fan, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam
Cc: linux-clk, imx, devicetree, linux-arm-kernel, linux-kernel,
Frank Li
Add label for system clocks and add two missing clocks anaclk[1,2]. Prepare
for fixing ccm related CHECK_DTB warnings.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi
index 45bcfd7faf9db628479359b5c0a26e1011a7c2d3..fde8a60dc297a71646b53b355c57c885745805ba 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi
@@ -54,23 +54,35 @@ aliases {
};
clocks {
- ckil {
+ ckil: ckil {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <32768>;
};
- ckih1 {
+ ckih1: ckih1 {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <0>;
};
- osc {
+ osc: osc {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <24000000>;
};
+
+ anaclk1: anaclk1 {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <0>;
+ };
+
+ anaclk2: anaclk2 {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <0>;
+ };
};
ldb: ldb {
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/3] ARM: dts: imx: add required clocks and clock-names for ccm
2025-11-05 16:55 [PATCH 0/3] ARM: dts: imx6: cleanup imx6/7 CCM related CHECK_DTBS warnings Frank Li
2025-11-05 16:55 ` [PATCH 1/3] dt-bindings: clock: imx6ul-clock: add optional clock enet1_ref_pad Frank Li
2025-11-05 16:55 ` [PATCH 2/3] ARM: dts: imx6qdl: add label for system clocks Frank Li
@ 2025-11-05 16:55 ` Frank Li
2 siblings, 0 replies; 7+ messages in thread
From: Frank Li @ 2025-11-05 16:55 UTC (permalink / raw)
To: Abel Vesa, Peng Fan, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam
Cc: linux-clk, imx, devicetree, linux-arm-kernel, linux-kernel,
Frank Li
Add required clocks and clock-names for ccm to fix below CHECK_DTBS
warnings:
arch/arm/boot/dts/nxp/imx/imx6dl-alti6p.dtb: clock-controller@20c4000 (fsl,imx6q-ccm): clock-names:0: 'osc' was expected
from schema $id: http://devicetree.org/schemas/clock/imx6q-clock.yaml#
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
arch/arm/boot/dts/nxp/imx/imx6dl-alti6p.dts | 4 ++--
arch/arm/boot/dts/nxp/imx/imx6dl-eckelmann-ci4x10.dts | 4 ++--
arch/arm/boot/dts/nxp/imx/imx6dl-lanmcu.dts | 4 ++--
arch/arm/boot/dts/nxp/imx/imx6dl-plybas.dts | 4 ++--
arch/arm/boot/dts/nxp/imx/imx6dl-plym2m.dts | 4 ++--
arch/arm/boot/dts/nxp/imx/imx6dl-prtmvt.dts | 4 ++--
arch/arm/boot/dts/nxp/imx/imx6dl-qmx6.dtsi | 5 +++--
arch/arm/boot/dts/nxp/imx/imx6dl-victgo.dts | 4 ++--
arch/arm/boot/dts/nxp/imx/imx6q-prtwd2.dts | 4 ++--
arch/arm/boot/dts/nxp/imx/imx6qdl-skov-cpu.dtsi | 4 ++--
10 files changed, 21 insertions(+), 20 deletions(-)
diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-alti6p.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-alti6p.dts
index 9bb36db131c21956a33f0a5a013c5bb4cffe1890..50448135329d21f4dfb6259d28d98c961e73604b 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6dl-alti6p.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6dl-alti6p.dts
@@ -193,8 +193,8 @@ &can1 {
};
&clks {
- clocks = <&clock_ksz8081>;
- clock-names = "enet_ref_pad";
+ clocks = <&osc>, <&ckil>, <&ckih1>, <&anaclk1>, <&anaclk2>, <&clock_ksz8081>;
+ clock-names = "osc", "ckil", "ckih1", "anaclk1", "anaclk2", "enet1_ref_pad";
assigned-clocks = <&clks IMX6QDL_CLK_ENET_REF_SEL>;
assigned-clock-parents = <&clock_ksz8081>;
};
diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-eckelmann-ci4x10.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-eckelmann-ci4x10.dts
index 5ed55f74b398f24a69245dbf88f5c93ee0d347d8..de06006d8c6989ea09712c882b0eb01e347d2f13 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6dl-eckelmann-ci4x10.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6dl-eckelmann-ci4x10.dts
@@ -66,8 +66,8 @@ &can2 {
};
&clks {
- clocks = <&rmii_clk>;
- clock-names = "enet_ref_pad";
+ clocks = <&osc>, <&ckil>, <&ckih1>, <&anaclk1>, <&anaclk2>, <&rmii_clk>;
+ clock-names = "osc", "ckil", "ckih1", "anaclk1", "anaclk2", "enet1_ref_pad";
assigned-clocks = <&clks IMX6QDL_CLK_ENET_REF_SEL>;
assigned-clock-parents = <&rmii_clk>;
};
diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-lanmcu.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-lanmcu.dts
index 47a6d63c8e04cf28795310aafcdd3b2b05740830..38dfcf1b0c73b0114042937e02cf596802d21e8c 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6dl-lanmcu.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6dl-lanmcu.dts
@@ -119,8 +119,8 @@ &can2 {
};
&clks {
- clocks = <&clock_ksz8081>;
- clock-names = "enet_ref_pad";
+ clocks = <&osc>, <&ckil>, <&ckih1>, <&anaclk1>, <&anaclk2>, <&clock_ksz8081>;
+ clock-names = "osc", "ckil", "ckih1", "anaclk1", "anaclk2", "enet1_ref_pad";
assigned-clocks = <&clks IMX6QDL_CLK_ENET_REF_SEL>;
assigned-clock-parents = <&clock_ksz8081>;
};
diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-plybas.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-plybas.dts
index 84f34da06267ebd477fbe71b465a44ffe5b4c098..9483ca1a1192b31d74a969c9a01bf047d5aebdaf 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6dl-plybas.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6dl-plybas.dts
@@ -101,8 +101,8 @@ &can2 {
};
&clks {
- clocks = <&clk50m_phy>;
- clock-names = "enet_ref_pad";
+ clocks = <&osc>, <&ckil>, <&ckih1>, <&anaclk1>, <&anaclk2>, <&clk50m_phy>;
+ clock-names = "osc", "ckil", "ckih1", "anaclk1", "anaclk2", "enet1_ref_pad";
assigned-clocks = <&clks IMX6QDL_CLK_ENET_REF_SEL>;
assigned-clock-parents = <&clk50m_phy>;
};
diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-plym2m.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-plym2m.dts
index 0ef24a07dedf986efdf4ce8ad4032814752e7271..ff64b94df5af9f9e103a792c77577635978633da 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6dl-plym2m.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6dl-plym2m.dts
@@ -199,8 +199,8 @@ &can1 {
};
&clks {
- clocks = <&clk50m_phy>;
- clock-names = "enet_ref_pad";
+ clocks = <&osc>, <&ckil>, <&ckih1>, <&anaclk1>, <&anaclk2>, <&clk50m_phy>;
+ clock-names = "osc", "ckil", "ckih1", "anaclk1", "anaclk2", "enet1_ref_pad";
assigned-clocks = <&clks IMX6QDL_CLK_ENET_REF_SEL>;
assigned-clock-parents = <&clk50m_phy>;
};
diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-prtmvt.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-prtmvt.dts
index 2160b71778355623a9f124975e2cd4dfba4be900..d1c49eabfa3730950bb524ec37456c692bf9c50c 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6dl-prtmvt.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6dl-prtmvt.dts
@@ -294,8 +294,8 @@ &can2 {
};
&clks {
- clocks = <&clk50m_phy>;
- clock-names = "enet_ref_pad";
+ clocks = <&osc>, <&ckil>, <&ckih1>, <&anaclk1>, <&anaclk2>, <&clk50m_phy>;
+ clock-names = "osc", "ckil", "ckih1", "anaclk1", "anaclk2", "enet1_ref_pad";
assigned-clocks = <&clks IMX6QDL_CLK_LDB_DI0_SEL>, <&clks IMX6QDL_CLK_ENET_REF_SEL>;
assigned-clock-parents = <&clks IMX6QDL_CLK_PLL5_VIDEO_DIV>, <&clk50m_phy>;
};
diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-qmx6.dtsi b/arch/arm/boot/dts/nxp/imx/imx6dl-qmx6.dtsi
index d5baec5e7a7824c05ca64c36a1839efff0bd7f71..fb674ac2c2485a818ae593c63388bcec548a100e 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6dl-qmx6.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6dl-qmx6.dtsi
@@ -71,8 +71,9 @@ IMX_AUDMUX_V2_PDCR_RXDSEL(MX51_AUDMUX_PORT1_SSI0)
};
&clks {
- clocks = <&rtc_sqw>;
- clock-names = "ckil";
+ clocks = <&osc>, <&rtc_sqw>, <&ckih1>, <&anaclk1>, <&anaclk2>;
+ clock-names = "osc", "ckil", "ckih1", "anaclk1", "anaclk2";
+
assigned-clocks = <&clks IMX6QDL_CLK_LDB_DI0_SEL>,
<&clks IMX6QDL_CLK_LDB_DI1_SEL>;
assigned-clock-parents = <&clks IMX6QDL_CLK_PLL2_PFD0_352M>,
diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-victgo.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-victgo.dts
index 76b0007d20ad22eee738ab40ed126435a8fd17fd..75a6bf4b5308062518a4d1e94e32ee4fe89dac43 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6dl-victgo.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6dl-victgo.dts
@@ -160,8 +160,8 @@ vdiv_hitch_pos: voltage-divider-hitch-pos {
};
&clks {
- clocks = <&clk50m_phy>;
- clock-names = "enet_ref_pad";
+ clocks = <&osc>, <&ckil>, <&ckih1>, <&anaclk1>, <&anaclk2>, <&clk50m_phy>;
+ clock-names = "osc", "ckil", "ckih1", "anaclk1", "anaclk2", "enet1_ref_pad";
assigned-clocks = <&clks IMX6QDL_CLK_ENET_REF_SEL>;
assigned-clock-parents = <&clk50m_phy>;
};
diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-prtwd2.dts b/arch/arm/boot/dts/nxp/imx/imx6q-prtwd2.dts
index 0e02e448db1085e7f508e55cd55d4441d2f51a54..c8bf04238bf565eb2fd1595031d6d1e813aa33ed 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6q-prtwd2.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6q-prtwd2.dts
@@ -57,8 +57,8 @@ &can1 {
};
&clks {
- clocks = <&clk50m_phy>;
- clock-names = "enet_ref_pad";
+ clocks = <&osc>, <&ckil>, <&ckih1>, <&anaclk1>, <&anaclk2>, <&clk50m_phy>;
+ clock-names = "osc", "ckil", "ckih1", "anaclk1", "anaclk2", "enet1_ref_pad";
assigned-clocks = <&clks IMX6QDL_CLK_ENET_REF_SEL>;
assigned-clock-parents = <&clk50m_phy>;
};
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-skov-cpu.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-skov-cpu.dtsi
index c93dbc595ef6eceda5fdf7b90dac57bfed59e489..5fd7c4b52871eafa6bd6c092ed1bd7b516da3a2b 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-skov-cpu.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-skov-cpu.dtsi
@@ -238,8 +238,8 @@ adc: adc@0 {
};
&clks {
- clocks = <&clk50m_phy>;
- clock-names = "enet_ref_pad";
+ clocks = <&osc>, <&ckil>, <&ckih1>, <&anaclk1>, <&anaclk2>, <&clk50m_phy>;
+ clock-names = "osc", "ckil", "ckih1", "anaclk1", "anaclk2", "enet1_ref_pad";
assigned-clocks = <&clks IMX6QDL_CLK_ENET_REF_SEL>;
assigned-clock-parents = <&clk50m_phy>;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] dt-bindings: clock: imx6ul-clock: add optional clock enet1_ref_pad
2025-11-05 16:55 ` [PATCH 1/3] dt-bindings: clock: imx6ul-clock: add optional clock enet1_ref_pad Frank Li
@ 2025-11-06 17:44 ` Conor Dooley
2025-11-06 17:57 ` Frank Li
0 siblings, 1 reply; 7+ messages in thread
From: Conor Dooley @ 2025-11-06 17:44 UTC (permalink / raw)
To: Frank Li
Cc: Abel Vesa, Peng Fan, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, linux-clk, imx,
devicetree, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2524 bytes --]
On Wed, Nov 05, 2025 at 11:55:28AM -0500, Frank Li wrote:
> Add optional clock source enet1_ref_pad, which input from ENET ref pad.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Documentation/devicetree/bindings/clock/imx6q-clock.yaml | 4 ++++
> Documentation/devicetree/bindings/clock/imx6ul-clock.yaml | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> index cd3c04c883df4ab02af29582369757df36269cb6..49475aec22a81ba87048eef588368261cbb38465 100644
> --- a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> @@ -29,20 +29,24 @@ properties:
> const: 1
>
> clocks:
> + minItems: 4
> items:
> - description: 24m osc
> - description: 32k osc
> - description: ckih1 clock input
> - description: anaclk1 clock input
> - description: anaclk2 clock input
> + - description: clock input from enet1 ref pad
>
> clock-names:
> + minItems: 4
> items:
> - const: osc
> - const: ckil
> - const: ckih1
> - const: anaclk1
> - const: anaclk2
> + - const: enet1_ref_pad
I think you could drop the _pad from here, and just make it enet1_ref.
Only a suggestion though,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable
>
> fsl,pmic-stby-poweroff:
> $ref: /schemas/types.yaml#/definitions/flag
> diff --git a/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml b/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
> index d57e18a210cc1d8a836b50058613dfb0308fbf11..035002721a3b3b65fe67734e13b686b91539f328 100644
> --- a/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
> @@ -29,18 +29,22 @@ properties:
> const: 1
>
> clocks:
> + minItems: 4
> items:
> - description: 32k osc
> - description: 24m osc
> - description: ipp_di0 clock input
> - description: ipp_di1 clock input
> + - description: clock input from enet1 ref pad
>
> clock-names:
> + minItems: 4
> items:
> - const: ckil
> - const: osc
> - const: ipp_di0
> - const: ipp_di1
> + - const: enet1_ref_pad
>
> required:
> - compatible
>
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] dt-bindings: clock: imx6ul-clock: add optional clock enet1_ref_pad
2025-11-06 17:44 ` Conor Dooley
@ 2025-11-06 17:57 ` Frank Li
2025-11-06 18:00 ` Conor Dooley
0 siblings, 1 reply; 7+ messages in thread
From: Frank Li @ 2025-11-06 17:57 UTC (permalink / raw)
To: Conor Dooley
Cc: Abel Vesa, Peng Fan, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, linux-clk, imx,
devicetree, linux-arm-kernel, linux-kernel
On Thu, Nov 06, 2025 at 05:44:36PM +0000, Conor Dooley wrote:
> On Wed, Nov 05, 2025 at 11:55:28AM -0500, Frank Li wrote:
> > Add optional clock source enet1_ref_pad, which input from ENET ref pad.
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > Documentation/devicetree/bindings/clock/imx6q-clock.yaml | 4 ++++
> > Documentation/devicetree/bindings/clock/imx6ul-clock.yaml | 4 ++++
> > 2 files changed, 8 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> > index cd3c04c883df4ab02af29582369757df36269cb6..49475aec22a81ba87048eef588368261cbb38465 100644
> > --- a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> > +++ b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> > @@ -29,20 +29,24 @@ properties:
> > const: 1
> >
> > clocks:
> > + minItems: 4
> > items:
> > - description: 24m osc
> > - description: 32k osc
> > - description: ckih1 clock input
> > - description: anaclk1 clock input
> > - description: anaclk2 clock input
> > + - description: clock input from enet1 ref pad
> >
> > clock-names:
> > + minItems: 4
> > items:
> > - const: osc
> > - const: ckil
> > - const: ckih1
> > - const: anaclk1
> > - const: anaclk2
> > + - const: enet1_ref_pad
>
> I think you could drop the _pad from here, and just make it enet1_ref.
> Only a suggestion though,
The old dts already use enet1_ref_pad. But anyway, after I double check
that it should be enet_ref_pad for 6q, enet1_ref_pad for 6ul.
Frank
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> pw-bot: not-applicable
>
> >
> > fsl,pmic-stby-poweroff:
> > $ref: /schemas/types.yaml#/definitions/flag
> > diff --git a/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml b/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
> > index d57e18a210cc1d8a836b50058613dfb0308fbf11..035002721a3b3b65fe67734e13b686b91539f328 100644
> > --- a/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
> > +++ b/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml
> > @@ -29,18 +29,22 @@ properties:
> > const: 1
> >
> > clocks:
> > + minItems: 4
> > items:
> > - description: 32k osc
> > - description: 24m osc
> > - description: ipp_di0 clock input
> > - description: ipp_di1 clock input
> > + - description: clock input from enet1 ref pad
> >
> > clock-names:
> > + minItems: 4
> > items:
> > - const: ckil
> > - const: osc
> > - const: ipp_di0
> > - const: ipp_di1
> > + - const: enet1_ref_pad
> >
> > required:
> > - compatible
> >
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] dt-bindings: clock: imx6ul-clock: add optional clock enet1_ref_pad
2025-11-06 17:57 ` Frank Li
@ 2025-11-06 18:00 ` Conor Dooley
0 siblings, 0 replies; 7+ messages in thread
From: Conor Dooley @ 2025-11-06 18:00 UTC (permalink / raw)
To: Frank Li
Cc: Abel Vesa, Peng Fan, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, linux-clk, imx,
devicetree, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1916 bytes --]
On Thu, Nov 06, 2025 at 12:57:01PM -0500, Frank Li wrote:
> On Thu, Nov 06, 2025 at 05:44:36PM +0000, Conor Dooley wrote:
> > On Wed, Nov 05, 2025 at 11:55:28AM -0500, Frank Li wrote:
> > > Add optional clock source enet1_ref_pad, which input from ENET ref pad.
> > >
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > > Documentation/devicetree/bindings/clock/imx6q-clock.yaml | 4 ++++
> > > Documentation/devicetree/bindings/clock/imx6ul-clock.yaml | 4 ++++
> > > 2 files changed, 8 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> > > index cd3c04c883df4ab02af29582369757df36269cb6..49475aec22a81ba87048eef588368261cbb38465 100644
> > > --- a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> > > +++ b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> > > @@ -29,20 +29,24 @@ properties:
> > > const: 1
> > >
> > > clocks:
> > > + minItems: 4
> > > items:
> > > - description: 24m osc
> > > - description: 32k osc
> > > - description: ckih1 clock input
> > > - description: anaclk1 clock input
> > > - description: anaclk2 clock input
> > > + - description: clock input from enet1 ref pad
> > >
> > > clock-names:
> > > + minItems: 4
> > > items:
> > > - const: osc
> > > - const: ckil
> > > - const: ckih1
> > > - const: anaclk1
> > > - const: anaclk2
> > > + - const: enet1_ref_pad
> >
> > I think you could drop the _pad from here, and just make it enet1_ref.
> > Only a suggestion though,
>
> The old dts already use enet1_ref_pad. But anyway, after I double check
> that it should be enet_ref_pad for 6q, enet1_ref_pad for 6ul.
Okay, cool. You can retain the ack on the new version with the 1
removed from 6q.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-11-06 18:00 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-05 16:55 [PATCH 0/3] ARM: dts: imx6: cleanup imx6/7 CCM related CHECK_DTBS warnings Frank Li
2025-11-05 16:55 ` [PATCH 1/3] dt-bindings: clock: imx6ul-clock: add optional clock enet1_ref_pad Frank Li
2025-11-06 17:44 ` Conor Dooley
2025-11-06 17:57 ` Frank Li
2025-11-06 18:00 ` Conor Dooley
2025-11-05 16:55 ` [PATCH 2/3] ARM: dts: imx6qdl: add label for system clocks Frank Li
2025-11-05 16:55 ` [PATCH 3/3] ARM: dts: imx: add required clocks and clock-names for ccm Frank Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).