From: Conor Dooley <conor@kernel.org>
To: Lakshay Piplani <lakshay.piplani@nxp.com>
Cc: alexandre.belloni@bootlin.com, linux-rtc@vger.kernel.org,
linux-kernel@vger.kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, pankit.garg@nxp.com,
vikash.bansal@nxp.com, priyanka.jain@nxp.com,
shashank.rebbapragada@nxp.com
Subject: Re: [PATCH v5 1/2] dt-bindings: rtc: Add pcf85053 support
Date: Fri, 7 Nov 2025 18:01:56 +0000 [thread overview]
Message-ID: <20251107-pediatric-disarray-606e4ed1f0f6@spud> (raw)
In-Reply-To: <20251107132618.2246407-1-lakshay.piplani@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 796 bytes --]
On Fri, Nov 07, 2025 at 06:56:17PM +0530, Lakshay Piplani wrote:
> + nxp,write-access:
> + type: boolean
> + description: |
> + Request the driver to claim write ownership at probe time by setting
> + CTRL.TWO=1. This property is only valid when nxp,interface="primary".
> + The driver will not modify any other CTRL bits (HF/DM/etc.) and will not
> + clear any status/interrupt flags at probe.
I'm sorry for not noticing this before, can you please remove the
commentary about linux driver specific stuff from here? Probably needs
to be something like "Indicates that write ownership of the RTC can be
should be claimed by setting CTRL.TWO. This property is only valid when
acting as the primary interface (nxp,interface = "primary")" or
something along those lines.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2025-11-07 18:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 13:26 [PATCH v5 1/2] dt-bindings: rtc: Add pcf85053 support Lakshay Piplani
2025-11-07 13:26 ` [PATCH v5 2/2] rtc: Add NXP PCF85053 driver support Lakshay Piplani
2025-11-07 18:01 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251107-pediatric-disarray-606e4ed1f0f6@spud \
--to=conor@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lakshay.piplani@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=pankit.garg@nxp.com \
--cc=priyanka.jain@nxp.com \
--cc=robh@kernel.org \
--cc=shashank.rebbapragada@nxp.com \
--cc=vikash.bansal@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).