From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DE9833B964; Fri, 7 Nov 2025 18:54:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762541691; cv=none; b=jkY1xxdYjxza5rSofW9ivJh8OOZjOYA5gIf97pL06K4vtDDCEu498fMA4Z1vFFQbXF7jZSmOxCjhvtUpLk6HxVJDdNt0G5nCxbNtPfnCFZchXSvXbkxrGYO7ny9UBcve6Dx6U3KOLmg3JC1OXrMc0j71csiFgwimCzCnOCC6Dls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762541691; c=relaxed/simple; bh=T5Rw6eWbPlE27qTm/Y51A5DLe5CKLXrJE8yBA6UrFuw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JHeP3Q/T5KYF7iaWDDKdctcdYNC7174tqdyg67LnaLxSbDvSAkRnVZLw8jMkZfZjkBpoSj9dHpKGaesUlvIvD4PnF7YoxM4UEu6/D8BIeEhLYuxUwbSasCo2/f+yqAcIdgidmgsFetFkDXjv2aBNOR8IVwBKWKSdYuAjGKLM+oc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=wm+Oa9C6; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="wm+Oa9C6" Received: from pendragon.ideasonboard.com (82-203-161-95.bb.dnainternet.fi [82.203.161.95]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 5891B111F; Fri, 7 Nov 2025 19:52:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1762541570; bh=T5Rw6eWbPlE27qTm/Y51A5DLe5CKLXrJE8yBA6UrFuw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wm+Oa9C6Gi4k4YZUlAj74M3wS8m7LFsTeP8uiJemarhggDXSx0cAHpWMnLk5pFtGL czvnQ4dmulBRace93soXdOvIr7hInH9xghsFxPHOY8pIwWDr0nZd5/Qd7cToxKGqmx fx5nvc+2KOD5qgHhY4wmsZ0zyFgl40HA+c0fXv3o= Date: Fri, 7 Nov 2025 20:54:41 +0200 From: Laurent Pinchart To: Michael Riesch Cc: Sakari Ailus , Mehdi Djait , Maxime Chevallier , =?utf-8?B?VGjDqW8=?= Lebrun , Thomas Petazzoni , Gerald Loacker , Bryan O'Donoghue , Markus Elfring , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Kever Yang , Nicolas Dufresne , Sebastian Reichel , Collabora Kernel Team , Paul Kocialkowski , Alexander Shiyan , Val Packett , Rob Herring , Philipp Zabel , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Mehdi Djait , Krzysztof Kozlowski , Bryan O'Donoghue , Chen-Yu Tsai Subject: Re: [PATCH v14 00/18] media: rockchip: add a driver for the rockchip camera interface Message-ID: <20251107185441.GG5558@pendragon.ideasonboard.com> References: <20240220-rk3568-vicap-v14-0-b38b6da0fc80@collabora.com> <074cd08e-0412-49f9-8dd9-b1f96eb11717@collabora.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <074cd08e-0412-49f9-8dd9-b1f96eb11717@collabora.com> On Fri, Nov 07, 2025 at 07:41:59PM +0100, Michael Riesch wrote: > On 11/7/25 18:32, Sakari Ailus wrote: > > On Fri, Oct 24, 2025 at 02:51:29PM +0200, Michael Riesch via B4 Relay wrote: > >> Habidere, > >> > >> This series introduces support for the Rockchip Camera Interface (CIF), > >> which is featured in many Rockchip SoCs in different variations. > >> For example, the PX30 Video Input Processor (VIP) is able to receive > >> video data via the Digital Video Port (DVP, a parallel data interface) > >> and transfer it into system memory using a double-buffering mechanism > >> called ping-pong mode. > >> The RK3568 Video Capture (VICAP) unit, on the other hand, features a > >> DVP and a MIPI CSI-2 receiver that can receive video data independently > >> (both using the ping-pong scheme). > >> The different variants may have additional features, such as scaling > >> and/or cropping. > >> Finally, the RK3588 VICAP unit constitutes an essential piece of the > >> camera interface with one DVP, six MIPI CSI-2 receivers, scale/crop > >> units, and a data path multiplexer (to scaler units, to ISP, ...). > > > > I understand both RK3568 and RK3588 include an ISP. Do you have insight on > > how would this work, should the support for the ISP be added later on? > > Short answer: Yes and yes. > > Long answer: > > The patch series at hand adds support for the PX30 VIP and the RK3568 > VICAP. I cannot really say something about the PX30, but on the RK3568 > VICAP and ISP are orthogonal (the ISP features its own MIPI CSI-2 > receiver, different from that introduced in this series). Thus, ISP > support can be introduced anytime (whenever someone is motivated ;-)). Won't they both be connected to the same sensor though, and probably the same D-PHY in the SoC ? They don't seem entirely separate to me. A block diagram that shows connections between the CSI-2 pins, D-PHY, CSI-2 receivers, VICAP and ISP could help. > Once this patch series is merged, I'll push out changes that introduce > support for the RK3588 VICAP. We can discuss the integration of any > RK3588 ISP in this scope then -- and there may be some things to discuss > as there the VICAP and the ISP(s) are directly connected by means of a > MUX unit in the VICAP. > > Alright? -- Regards, Laurent Pinchart